[Rt-commit] rt branch, 4.4/non-message-squelching, created. rt-4.2.5-200-g9bba7c5

Alex Vandiver alexmv at bestpractical.com
Tue Oct 7 16:18:54 EDT 2014


The branch, 4.4/non-message-squelching has been created
        at  9bba7c5851af578bb9ef4b3c3589f73e1a974132 (commit)

- Log -----------------------------------------------------------------
commit 9bba7c5851af578bb9ef4b3c3589f73e1a974132
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Oct 7 16:07:39 2014 -0400

    Apply squelching information to updates with no messages
    
    Updates from the ticket Reply/Comment page which do not record content,
    merely change the status / owner / etc., do not currently respect the
    squelching checkboxes, despite showing as if they do.  This is because
    the squelching information is stored on the Correspond/Comment
    transaction, and thus only propagated to other transactions if such was
    created.
    
    Even on updates that do not have content, store and respect the
    squelching information.  This builds upon 4a33c662, which made the
    transaction squelching settings apply for the lifetime of the ticket
    object.

diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
index 3782a62..af10017 100644
--- a/lib/RT/Interface/Web.pm
+++ b/lib/RT/Interface/Web.pm
@@ -2265,13 +2265,16 @@ sub ProcessUpdateMessage {
 
     # If, after stripping the signature, we have no message, move the
     # UpdateTimeWorked into adjusted TimeWorked, so that a later
-    # ProcessBasics can deal -- then bail out.
+    # ProcessBasics can deal.  Also store the squelching information in
+    # the ticket object, for notifications triggered by other parts of
+    # the request; then bail out.
     if (    not @attachments
         and not length $args{ARGSRef}->{'UpdateContent'} )
     {
         if ( $args{ARGSRef}->{'UpdateTimeWorked'} ) {
             $args{ARGSRef}->{TimeWorked} = $args{TicketObj}->TimeWorked + delete $args{ARGSRef}->{'UpdateTimeWorked'};
         }
+        _ProcessUpdateMessageRecipients( MessageArgs => {}, %args );
         return;
     }
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list