[Rt-commit] rt branch, 4.2/smime-missing-signing-key, created. rt-4.2.8-8-g294acd7

[Alex Vandiver]

The branch, 4.2/smime-missing-signing-key has been created
        at  294acd781ef80f303d755356ea43552e2190af57 (commit)

- Log -----------------------------------------------------------------
commit 294acd781ef80f303d755356ea43552e2190af57
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Wed Oct 8 13:00:56 2014 -0400

    Ensure that _SignEncrypt always returns ($buf, %hash)
    
    This return point omitted the undef buffer, causing the hash assignment
    in the calling site to be off by one.
    
    Fixes I#30436.

diff --git a/lib/RT/Crypt/SMIME.pm b/lib/RT/Crypt/SMIME.pm
index 47fdeb7..68a0804 100644
--- a/lib/RT/Crypt/SMIME.pm
+++ b/lib/RT/Crypt/SMIME.pm
@@ -338,7 +338,7 @@ sub _SignEncrypt {
                 KeyType   => "secret",
             });
             $res{exit_code} = 1;
-            return %res;
+            return (undef, %res);
         }
         $args{'Passphrase'} = $self->GetPassphrase( Address => $args{'Signer'} )
             unless defined $args{'Passphrase'};

-----------------------------------------------------------------------