[Rt-commit] [rtir] 04/14: Explicit returns for add_constituency

Kevin Falcone falcone at bestpractical.com
Wed Oct 8 18:11:57 EDT 2014


This is an automated email from the git hooks/post-receive script.

falcone pushed a commit to branch 3.4/perlcritic
in repository rtir.

commit 11a0d05312e670431a2566f9c5e2eedf5b816bad
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jul 22 12:35:57 2011 -0400

    Explicit returns for add_constituency
---
 bin/add_constituency.in | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/bin/add_constituency.in b/bin/add_constituency.in
index 5a93074..55aac6d 100755
--- a/bin/add_constituency.in
+++ b/bin/add_constituency.in
@@ -246,6 +246,7 @@ sub add_cf_value {
         die $msg unless $val;
         debug "Added '$value' to the constituency field";
     }
+    return 1;
 }
 
 sub grant_group_queue_rights {
@@ -268,7 +269,8 @@ sub grant_group_queue_rights {
                 die "Failed to grant $right to ". $group->Name ." for Queue ". $queue->Name;
             }
         }
-    } 
+    }
+    return 1;
 }
 
 
@@ -298,7 +300,8 @@ sub grant_group_cf_rights {
                     .".\nError: $msg";
             }
         }
-    } 
+    }
+    return 1;
 }
 
 sub group_exists {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list