[Rt-commit] rt branch, 4.2-trunk, updated. rt-4.2.8-23-g030fef0

Alex Vandiver alexmv at bestpractical.com
Wed Oct 22 00:47:26 EDT 2014


The branch, 4.2-trunk has been updated
       via  030fef05184ad89f2238e2dbed4fe0da4745ad6d (commit)
      from  fa34393b3b8072f424427df40a0cf148705be4f0 (commit)

Summary of changes:
 t/web/cf_date.t     | 2 +-
 t/web/cf_datetime.t | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 030fef05184ad89f2238e2dbed4fe0da4745ad6d
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Tue Oct 21 18:37:30 2014 -0400

    Update tests for warnings as correctly seen post-d34aaa49
    
    Prior to d34aaa49, the test would pass in two circumstances:
     1. There was one warning, which matched "Couldn't parse..."
     2. There were two or more warnings, the first two of which were
        identical
    
    Case (2) was in effect, not case (1) as the code may have mislead one to
    believe.  As such, the test was even more confusingly useless prior.
    
    Update the test to make explicit that it expects the warning twice.

diff --git a/t/web/cf_date.t b/t/web/cf_date.t
index e26d0c5..a383889 100644
--- a/t/web/cf_date.t
+++ b/t/web/cf_date.t
@@ -186,7 +186,7 @@ diag 'check invalid inputs';
 
     my @warnings = $m->get_warnings;
     chomp @warnings;
-    is_deeply( [@warnings], [q{Couldn't parse date 'foodate' by Time::ParseDate}] );
+    is_deeply( [@warnings], [(q{Couldn't parse date 'foodate' by Time::ParseDate})x2] );
 }
 
 diag 'retain values when adding attachments';
diff --git a/t/web/cf_datetime.t b/t/web/cf_datetime.t
index 89e347b..da938ab 100644
--- a/t/web/cf_datetime.t
+++ b/t/web/cf_datetime.t
@@ -212,7 +212,7 @@ diag 'check invalid inputs';
 
     my @warnings = $m->get_warnings;
     chomp @warnings;
-    is_deeply( [@warnings], [q{Couldn't parse date 'foodate' by Time::ParseDate}] );
+    is_deeply( [@warnings], [(q{Couldn't parse date 'foodate' by Time::ParseDate})x2] );
 }
 
 diag 'retain values when adding attachments';

-----------------------------------------------------------------------


More information about the rt-commit mailing list