[Rt-commit] rt branch, 4.0/quick-create-default-queue-config, created. rt-4.0.23-23-g5b8c2ec

? sunnavy sunnavy at bestpractical.com
Thu Apr 23 13:27:21 EDT 2015


The branch, 4.0/quick-create-default-queue-config has been created
        at  5b8c2ec60c506261829fe31411e39451f1bc22b3 (commit)

- Log -----------------------------------------------------------------
commit 5b8c2ec60c506261829fe31411e39451f1bc22b3
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Apr 24 00:57:57 2015 +0800

    respect DefaultQueue/RememberDefaultQueue configs for QuickCreate widget
    
    in cd52b35e, we send Default arg to /Elements/SelectNewTicketQueue, which
    always overrides DefaultQueue/RememberDefaultQueue configs, and it's wrong.
    
    Fixes: I#30913

diff --git a/share/html/Elements/SelectNewTicketQueue b/share/html/Elements/SelectNewTicketQueue
index 57abc44..9c2a112 100644
--- a/share/html/Elements/SelectNewTicketQueue
+++ b/share/html/Elements/SelectNewTicketQueue
@@ -49,11 +49,14 @@
   <& /Elements/SelectQueue, Name => 'Queue', Default => $queue, %ARGS, ShowNullOption => 0, ShowAllQueues => 0 &>
 </label>
 <%INIT>
-my $queue = RT->Config->Get("DefaultQueue", $session{'CurrentUser'});
+my $queue = delete $ARGS{Default};
+if ( !$queue ) {
+    $queue = RT->Config->Get("DefaultQueue", $session{'CurrentUser'});
 
-if (RT->Config->Get("RememberDefaultQueue", $session{'CurrentUser'})) {
-    if (my $session_default = $session{'DefaultQueue'}) {
-        $queue = $session_default;
+    if (RT->Config->Get("RememberDefaultQueue", $session{'CurrentUser'})) {
+        if (my $session_default = $session{'DefaultQueue'}) {
+            $queue = $session_default;
+        }
     }
 }
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list