[Rt-commit] rt branch, 4.4/custom-field-msg, repushed

Dustin Graves dustin at bestpractical.com
Tue Aug 18 12:41:15 EDT 2015


The branch 4.4/custom-field-msg was deleted and repushed:
       was 7058527a74579e3d5c69081e3be77ee5446c84f2
       now ff8e561fb5a10ca28cd6a35cdea5eb1b9ae7c072

1:  7058527 ! 1:  ff8e561 Improve applying a custom field to a queue message
    @@ -23,7 +23,7 @@
     +    if ($object->id) {
     +        $msg = $self->loc( 'Added custom field [_1] to [_2].', $self->Name, $object->Name );
     +    } else {
    -+        $msg = $self->loc( 'Globall added custom field [_1].', $self->Name );
    ++        $msg = $self->loc( 'Globally added custom field [_1].', $self->Name );
     +    }
     +
          return ( $oid, $msg );
    @@ -56,7 +56,7 @@
      $m->tick( $tcf, 0 );         # Associate the new CF with this queue
      $m->click('UpdateObjs');
     -$m->content_like( qr/Object created/, 'TCF added to the queue' );
    -+$m->content_contains("Added custom field img$$ to All Objects", 'TCF added to the queue' );
    ++$m->content_contains("Globally added custom field img$$", 'TCF added to the queue' );
      
      $m->follow_link_ok( { text => 'Articles', url_regex => qr!^/Articles/! },
          'UI -> Articles' );
    @@ -221,7 +221,7 @@
      $m->tick( "AddCustomField-1", 0 );
      $m->click_ok( "UpdateObjs" );
     -$m->content_contains("Object created");
    -+$m->content_contains("Added custom field Images to All Objects");
    ++$m->content_contains("Globally added custom field Images");
      
      
      $m->submit_form_ok({
    @@ -234,7 +234,7 @@
          $m->click('UpdateCFs');
      
     -    $m->content_contains('Object created', 'CF QueueCFTest enabled globally' );
    -+    $m->content_contains("Added custom field QueueCFTest to All Objects", 'CF QueueCFTest enabled globally' );
    ++    $m->content_contains("Globally added custom field QueueCFTest", 'CF QueueCFTest enabled globally' );
      }
      
      diag "Edit the CF value for default queue";
    @@ -260,7 +260,7 @@
      $m->tick('AddCustomField-'.$cf->id => '0'); # Make CF global
      $m->click('UpdateObjs');
     -$m->text_contains('Object created', 'CF applied globally');
    -+$m->text_contains("Added custom field CF1 to All Objects", 'CF applied globally');
    ++$m->text_contains("Globally added custom field CF1", 'CF applied globally');
      
      # Test for preservation when a ticket is submitted and CF validation fails
      for my $try (@form_tries) {



More information about the rt-commit mailing list