[Rt-commit] [rtir] 03/04: Switch tests to 'done_testing' style

Jesse Vincent jesse at bestpractical.com
Wed Mar 4 16:13:14 EST 2015


This is an automated email from the git hooks/post-receive script.

jesse pushed a commit to branch 3.4/remove_old_constituencies
in repository rtir.

commit dd1b257dec3695fb72baf42ddc201c28ed9c1a36
Author: Jesse Vincent <jesse at bestpractical.com>
Date:   Wed Mar 4 13:11:50 2015 -0800

    Switch tests to 'done_testing' style
    
    As we refactor some of the web testing, this change
    means we don't need to recompute all the old test counts
---
 t/000-mason-syntax.t                           | 4 ++--
 t/001-basic-RTIR.t                             | 4 ++--
 t/002-test-reject.t                            | 3 ++-
 t/003-resolve-IR-when-all-incidents-resolved.t | 3 ++-
 t/005-resolve-investigations.t                 | 4 +++-
 t/006-saved-searches.t                         | 4 +++-
 t/009-attachments-processing.t                 | 4 +++-
 t/010-bulk-reject.t                            | 4 +++-
 t/011-merge.t                                  | 4 +++-
 t/019-watchers-on-create.t                     | 3 ++-
 t/articles/basics.t                            | 4 +++-
 t/articles/on-create.t                         | 4 +++-
 t/articles/on-update.t                         | 4 +++-
 t/block/pending-no-regexp.t                    | 4 +++-
 t/block/pending-regexp.t                       | 4 +++-
 t/block/status-basics.t                        | 4 +++-
 t/block/status-editor-regression.t             | 3 ++-
 t/constituency/acl.t                           | 2 +-
 t/constituency/basics.t                        | 3 ++-
 t/constituency/email.t                         | 4 +++-
 t/constituency/email_outgoing.t                | 4 +++-
 t/constituency/propagation-inherit.t           | 4 +++-
 t/constituency/propagation-no.t                | 4 +++-
 t/constituency/propagation-reject.t            | 4 +++-
 t/custom-fields/defaults-config.t              | 4 +++-
 t/custom-fields/defaults-on-linking.t          | 4 +++-
 t/custom-fields/ip.t                           | 4 +++-
 t/custom-fields/ipv6.t                         | 3 ++-
 t/custom-fields/on-transactions.t              | 4 +++-
 t/dates/due-incidents.t                        | 4 +++-
 t/dates/started.t                              | 4 +++-
 t/gnupg/on-create.t                            | 3 +++
 t/gnupg/on-incident.t                          | 4 +++-
 t/gnupg/on-update.t                            | 5 ++++-
 t/incident/abandon.t                           | 3 ++-
 t/incident/bulk-abandon.t                      | 3 ++-
 t/incident/split.t                             | 3 ++-
 t/mail/skip_notification.t                     | 3 ++-
 t/report/status.t                              | 3 ++-
 t/searches/simple.t                            | 4 +++-
 t/tools/lookup.t                               | 3 ++-
 t/upgrade/2.6.0-to-2.9.0.t                     | 4 +++-
 42 files changed, 111 insertions(+), 43 deletions(-)

diff --git a/t/000-mason-syntax.t b/t/000-mason-syntax.t
index 3df3897..3213b8e 100644
--- a/t/000-mason-syntax.t
+++ b/t/000-mason-syntax.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 4;
+use RT::IR::Test tests => undef;
 
 my $ok = 1;
 
@@ -42,4 +42,4 @@ sub compile_file {
     );
     return 1;
 }
-
+done_testing;
diff --git a/t/001-basic-RTIR.t b/t/001-basic-RTIR.t
index e43e5cd..cb91c34 100644
--- a/t/001-basic-RTIR.t
+++ b/t/001-basic-RTIR.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 25;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -42,4 +42,4 @@ $agent->LinkChildToIncident( $report, $second_incident_id);
 
 
 
-
+done_testing;
diff --git a/t/002-test-reject.t b/t/002-test-reject.t
index 2517ab4..85d813c 100644
--- a/t/002-test-reject.t
+++ b/t/002-test-reject.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 107;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -169,3 +169,4 @@ diag "test that after bulk reject links to incidents are still there" if $ENV{'T
     $agent->has_tag('a', "$id", 'we have link to ticket');
 }
 
+done_testing;
diff --git a/t/003-resolve-IR-when-all-incidents-resolved.t b/t/003-resolve-IR-when-all-incidents-resolved.t
index 6b1294e..3a08f4e 100644
--- a/t/003-resolve-IR-when-all-incidents-resolved.t
+++ b/t/003-resolve-IR-when-all-incidents-resolved.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 34;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -43,6 +43,7 @@ like(
 
 ir_status('resolved');
 
+done_testing;
 
 sub ir_status {
     my $status = shift;
diff --git a/t/005-resolve-investigations.t b/t/005-resolve-investigations.t
index 82fdb6f..83aa469 100644
--- a/t/005-resolve-investigations.t
+++ b/t/005-resolve-investigations.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 24;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -31,3 +31,5 @@ like($agent->content, qr/Status changed from \S*open\S* to \S*resolved\S*/, "sit
 
 $agent->follow_link_ok({text => "Re-open"}, "Followed 'open' link");
 like($agent->content, qr/Status changed from \S*resolved\S* to \S*open\S*/, "site says ticket got re-opened");
+
+done_testing;
diff --git a/t/006-saved-searches.t b/t/006-saved-searches.t
index 1b0260a..bc1c596 100644
--- a/t/006-saved-searches.t
+++ b/t/006-saved-searches.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 20;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -65,3 +65,5 @@ is($agent->value('SavedSearchOwner'), "RT::Group-$DT_id", "privacy is correct");
 
 
 # ... should also do tests for the RTIR "refine" thing, which is like QB.
+
+done_testing;
diff --git a/t/009-attachments-processing.t b/t/009-attachments-processing.t
index 395e985..2e61976 100644
--- a/t/009-attachments-processing.t
+++ b/t/009-attachments-processing.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 80;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -233,3 +233,5 @@ $agent->goto_create_rtir_ticket('Blocks');
 
     unlink $filename or die "couldn't delete file '$filename': $!";
 }
+
+done_testing;
diff --git a/t/010-bulk-reject.t b/t/010-bulk-reject.t
index 92ad54a..a58ea6c 100644
--- a/t/010-bulk-reject.t
+++ b/t/010-bulk-reject.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 45;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -62,3 +62,5 @@ $agent->get_ok('/RTIR/index.html', 'open rtir at glance');
 foreach( @irs ) {
     $agent->ticket_status_is( $_, 'rejected', "Ticket #$_ is rejected" );
 }
+
+done_testing;
diff --git a/t/011-merge.t b/t/011-merge.t
index 7df9d21..1341e53 100644
--- a/t/011-merge.t
+++ b/t/011-merge.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 108;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -105,3 +105,5 @@ diag "merge two IRs that are linked to different Incidents" if $ENV{'TEST_VERBOS
 
     $agent->ticket_is_linked_to_inc( $ir1_id, [$inc1_id, $inc2_id] );
 }
+
+done_testing;
diff --git a/t/019-watchers-on-create.t b/t/019-watchers-on-create.t
index 0368811..d0c1c6b 100644
--- a/t/019-watchers-on-create.t
+++ b/t/019-watchers-on-create.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 53;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -86,3 +86,4 @@ SKIP: {
 	$agent->has_watchers( $solo_inv, 'AdminCc');
 }
 
+done_testing;
diff --git a/t/articles/basics.t b/t/articles/basics.t
index e4218b0..5538eab 100644
--- a/t/articles/basics.t
+++ b/t/articles/basics.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 20;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -36,3 +36,5 @@ $agent->display_ticket( $ir_id);
 
 $agent->follow_link_ok({text => $article_name}, "back to article");
 $agent->content_like( qr/this is a summary/, "found the summary of the article");
+
+done_testing();
diff --git a/t/articles/on-create.t b/t/articles/on-create.t
index 0c6ced0..feb5df6 100644
--- a/t/articles/on-create.t
+++ b/t/articles/on-create.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 53;
+use RT::IR::Test tests => undef;
 
 RT->Config->Set( ArticleOnTicketCreate => 1 );
 
@@ -68,3 +68,5 @@ foreach ( 'Incidents', 'Incident Reports', 'Investigations', 'Blocks' ) {
     like( $agent->field( $content_name ), qr/this is a content/ );
 }
 
+
+done_testing;
diff --git a/t/articles/on-update.t b/t/articles/on-update.t
index aab452e..bb1e3b9 100644
--- a/t/articles/on-update.t
+++ b/t/articles/on-update.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 69;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -73,3 +73,5 @@ foreach my $queue ( 'Incidents', 'Incident Reports', 'Investigations', 'Blocks'
     $agent->form_name('TicketUpdate');
     like( $agent->field('UpdateContent'), qr/this is a content/ );
 }
+
+done_testing;
diff --git a/t/block/pending-no-regexp.t b/t/block/pending-no-regexp.t
index 332e007..317b8fa 100644
--- a/t/block/pending-no-regexp.t
+++ b/t/block/pending-no-regexp.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 29;
+use RT::IR::Test tests => undef;
 
 RT->Config->Set('RTIR_BlockAproveActionRegexp', undef);
 
@@ -55,3 +55,5 @@ EOF
     is $id, $block_id, "replied to the ticket";
     $agent->ticket_status_is( $block_id, 'removed');
 }
+
+done_testing;
diff --git a/t/block/pending-regexp.t b/t/block/pending-regexp.t
index dbd790d..e78e93c 100644
--- a/t/block/pending-regexp.t
+++ b/t/block/pending-regexp.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 37;
+use RT::IR::Test tests => undef;
 
 RT->Config->Set('RTIR_BlockAproveActionRegexp', qr/TestPendingBlock/);
 
@@ -86,3 +86,5 @@ EOF
     is $id, $block_id, "replied to the ticket";
     $agent->ticket_status_is( $block_id, 'removed');
 }
+
+done_testing;
diff --git a/t/block/status-basics.t b/t/block/status-basics.t
index d688a1f..1acae7a 100644
--- a/t/block/status-basics.t
+++ b/t/block/status-basics.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 67;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -101,3 +101,5 @@ diag "test activation after reply using Edit page";
     $agent->ticket_status_is( $block_id, 'active');
 }
 
+
+done_testing;
diff --git a/t/block/status-editor-regression.t b/t/block/status-editor-regression.t
index 95e0ce8..fa219c9 100644
--- a/t/block/status-editor-regression.t
+++ b/t/block/status-editor-regression.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 18;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -15,3 +15,4 @@ $agent->goto_edit_block( $block);
 
 $agent->content_unlike(qr{<option (?:value=.*)?>Use system default\(\)</option>}, "The option 'Use system default()' does not exist.");
 
+done_testing();
diff --git a/t/constituency/acl.t b/t/constituency/acl.t
index e082f30..4a22cf0 100644
--- a/t/constituency/acl.t
+++ b/t/constituency/acl.t
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 
 use Test::More skip_all => 'constituencies being rebuilt';
-use RT::IR::Test tests => 13;
+use RT::IR::Test tests => undef;
 use_ok('RT::IR');
 
 my $cf;
diff --git a/t/constituency/basics.t b/t/constituency/basics.t
index e79b4d4..b94b3a0 100644
--- a/t/constituency/basics.t
+++ b/t/constituency/basics.t
@@ -2,7 +2,7 @@ use strict;
 use warnings;
 
 use Test::More skip_all => 'constituencies being rebuilt';
-use RT::IR::Test tests => 166;
+use RT::IR::Test tests => undef;
 
 use_ok('RT::IR');
 
@@ -303,3 +303,4 @@ diag "check defaults when creating inc with inv";
     }
 }
 
+done_testing;
diff --git a/t/constituency/email.t b/t/constituency/email.t
index a8cbc84..1f599cb 100644
--- a/t/constituency/email.t
+++ b/t/constituency/email.t
@@ -4,7 +4,7 @@ use Test::More skip_all => 'constituencies being rebuilt';
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 73;
+use RT::IR::Test tests => undef;
 
 # Test must be run wtih RT_SiteConfig:
 # Set(@MailPlugins, 'Auth::MailFrom');
@@ -120,3 +120,5 @@ EOF
 }
 
 
+
+done_testing;
diff --git a/t/constituency/email_outgoing.t b/t/constituency/email_outgoing.t
index 4afef31..951bffd 100644
--- a/t/constituency/email_outgoing.t
+++ b/t/constituency/email_outgoing.t
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 
 use Test::More skip_all => 'constituencies being rebuilt';
-use RT::IR::Test tests => 39;
+use RT::IR::Test tests => undef;
 
 RT->Config->Get('RTIR_CustomFieldsDefaults')->{'Constituency'} = 'EDUNET';
 
@@ -158,3 +158,5 @@ diag "GOV user creates an IR under EDUNET, check addresses";
     ok $from_ok, 'all From addresses are correct';
 }
 
+
+done_testing;
diff --git a/t/constituency/propagation-inherit.t b/t/constituency/propagation-inherit.t
index 1e9692b..6f6b827 100644
--- a/t/constituency/propagation-inherit.t
+++ b/t/constituency/propagation-inherit.t
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 use Test::More skip_all => 'constituencies being rebuilt';
 
-use RT::IR::Test tests => 186;
+use RT::IR::Test tests => undef;
 
 use_ok('RT::IR');
 RT->Config->Set('_RTIR_Constituency_Propagation' => 'inherit');
@@ -274,3 +274,5 @@ diag "check that constituency propagates from a child to a parent after 'Edit',
     }
 }
 
+
+done_testing;
diff --git a/t/constituency/propagation-no.t b/t/constituency/propagation-no.t
index 116b307..89d82f0 100644
--- a/t/constituency/propagation-no.t
+++ b/t/constituency/propagation-no.t
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 
 use Test::More skip_all => 'constituencies being rebuilt';
-use RT::IR::Test tests => 107;
+use RT::IR::Test tests => undef;
 
 use_ok('RT::IR');
 RT->Config->Set('_RTIR_Constituency_Propagation' => 'no');
@@ -188,3 +188,5 @@ diag "create an incident under GOVNET and create a new IR "
     }
 }
 
+
+done_testing;
diff --git a/t/constituency/propagation-reject.t b/t/constituency/propagation-reject.t
index 0667039..fe37cf8 100644
--- a/t/constituency/propagation-reject.t
+++ b/t/constituency/propagation-reject.t
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 
 use Test::More skip_all => 'constituencies being rebuilt';
-use RT::IR::Test tests => 187;
+use RT::IR::Test tests => undef;
 
 use_ok('RT::IR');
 RT->Config->Set('_RTIR_Constituency_Propagation' => 'reject');
@@ -303,3 +303,5 @@ diag "check that we can change constituency of an unlinked ticket using 'Edit' p
         'no constituency select box';
 }
 
+
+done_testing;
diff --git a/t/custom-fields/defaults-config.t b/t/custom-fields/defaults-config.t
index 76daa15..2ea1626 100644
--- a/t/custom-fields/defaults-config.t
+++ b/t/custom-fields/defaults-config.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 71;
+use RT::IR::Test tests => undef;
 
 my $defaults = RT->Config->Get('RTIR_CustomFieldsDefaults');
 $defaults->{'How Reported'}  = 'Telephone';   # IRs
@@ -80,3 +80,5 @@ my $agent = default_agent();
     }
 }
 
+
+done_testing;
diff --git a/t/custom-fields/defaults-on-linking.t b/t/custom-fields/defaults-on-linking.t
index 566ca01..a26af78 100644
--- a/t/custom-fields/defaults-on-linking.t
+++ b/t/custom-fields/defaults-on-linking.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 32;
+use RT::IR::Test tests => undef;
 
 my $cf_name = 'test';
 {
@@ -74,3 +74,5 @@ my $agent = default_agent();
 }
 
 
+
+done_testing;
diff --git a/t/custom-fields/ip.t b/t/custom-fields/ip.t
index 9ab6576..b4d5687 100644
--- a/t/custom-fields/ip.t
+++ b/t/custom-fields/ip.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 449;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -626,3 +626,5 @@ diag "merge ticket with the same IP";
     is( $has[0], '172.16.0.1', "has value" );
 }
 
+
+done_testing;
diff --git a/t/custom-fields/ipv6.t b/t/custom-fields/ipv6.t
index 512bae0..a59a8d8 100644
--- a/t/custom-fields/ipv6.t
+++ b/t/custom-fields/ipv6.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 698;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -555,3 +555,4 @@ diag "merge ticket with the same IP";
     is( $has[0], '0000:'x6 .'ac10:0001', "has value" );
 }
 
+done_testing();
diff --git a/t/custom-fields/on-transactions.t b/t/custom-fields/on-transactions.t
index 4ab46b4..cb2c233 100644
--- a/t/custom-fields/on-transactions.t
+++ b/t/custom-fields/on-transactions.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 81;
+use RT::IR::Test tests => undef;
 
 my $cf_name = 'test';
 my $cf;
@@ -117,3 +117,5 @@ foreach my $id ( @tickets ) {
     is $txn->FirstCustomFieldValue( $cf_name ), 'not magic', 'correct value';
 }
 
+
+done_testing;
diff --git a/t/dates/due-incidents.t b/t/dates/due-incidents.t
index 98bd6ad..18924b8 100644
--- a/t/dates/due-incidents.t
+++ b/t/dates/due-incidents.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 50;
+use RT::IR::Test tests => undef;
 
 # link on create without due
 {
@@ -190,3 +190,5 @@ use RT::IR::Test tests => 50;
     $inc->Load( $inc->id ); # reload
     is $inc->DueObj->ISO, $ir1->DueObj->ISO;
 }
+
+done_testing;
diff --git a/t/dates/started.t b/t/dates/started.t
index b8e4cc3..ff69bbb 100644
--- a/t/dates/started.t
+++ b/t/dates/started.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 68;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -109,3 +109,5 @@ diag "started date of a block" if $ENV{'TEST_VERBOSE'};
     ok( $block->StartedObj->Unix > 0, 'activation of a block sets started date');
 }
 
+
+done_testing;
diff --git a/t/gnupg/on-create.t b/t/gnupg/on-create.t
index 4fe44be..01b640c 100644
--- a/t/gnupg/on-create.t
+++ b/t/gnupg/on-create.t
@@ -244,6 +244,8 @@ diag "check encrypting of attachments";
     check_text_emails( { Encrypt => 1, Attachment => 1 }, @mail );
 }
 
+done_testing;
+
 sub check_text_emails {
     my %args = %{ shift @_ };
     my @mail = @_;
@@ -276,3 +278,4 @@ sub check_text_emails {
     }
 }
 
+
diff --git a/t/gnupg/on-incident.t b/t/gnupg/on-incident.t
index 48f7f83..88848a0 100644
--- a/t/gnupg/on-incident.t
+++ b/t/gnupg/on-incident.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test::GnuPG tests => 40, gnupg_options => { passphrase => 'rt-test' };
+use RT::IR::Test::GnuPG tests => undef, gnupg_options => { passphrase => 'rt-test' };
 
 my $queue = RT::Test->load_or_create_queue(
     Name              => 'Incident Reports',
@@ -84,3 +84,5 @@ diag "check that things don't work if there is no key";
     my @mail = RT::Test->fetch_caught_mails;
     ok !@mail, 'there are no outgoing emails';
 }
+
+done_testing;
diff --git a/t/gnupg/on-update.t b/t/gnupg/on-update.t
index 9ba942b..a70a3e1 100644
--- a/t/gnupg/on-update.t
+++ b/t/gnupg/on-update.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test::GnuPG tests => 68, gnupg_options => { passphrase => 'rt-test' };
+use RT::IR::Test::GnuPG tests => undef, gnupg_options => { passphrase => 'rt-test' };
 
 my $queue = RT::Test->load_or_create_queue(
     Name              => 'Incident Reports',
@@ -259,6 +259,9 @@ diag "check encrypting of attachments";
     check_text_emails( { Encrypt => 1, Attachment => 1 }, @mail );
 }
 
+
+done_testing;
+
 sub check_text_emails {
     my %args = %{ shift @_ };
     my @mail = @_;
diff --git a/t/incident/abandon.t b/t/incident/abandon.t
index ddda40c..3182988 100644
--- a/t/incident/abandon.t
+++ b/t/incident/abandon.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 48;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -56,5 +56,6 @@ diag "abandon incident with resolved IR" if $ENV{'TEST_VERBOSE'};
     is $agent->ticket_status( $ir_id), 'resolved', 'resolved ir';
 }
 
+done_testing;
 
 
diff --git a/t/incident/bulk-abandon.t b/t/incident/bulk-abandon.t
index 3b078f6..1b0372b 100644
--- a/t/incident/bulk-abandon.t
+++ b/t/incident/bulk-abandon.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 112;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -73,3 +73,4 @@ foreach my $id (@invests) {
     $agent->ticket_status_is( $id, 'resolved', 'correct status' );
 }
 
+done_testing;
diff --git a/t/incident/split.t b/t/incident/split.t
index 091d38f..f7ab38a 100644
--- a/t/incident/split.t
+++ b/t/incident/split.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 22;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -38,3 +38,4 @@ my $rtir_user = rtir_user();
     $agent->ticket_is_not_linked_to_inc( $inv_id, [$id]);
 }
 
+done_testing;
diff --git a/t/mail/skip_notification.t b/t/mail/skip_notification.t
index 1cc060b..d279a50 100644
--- a/t/mail/skip_notification.t
+++ b/t/mail/skip_notification.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 20;
+use RT::IR::Test tests => undef;
 
 RT->Config->Get('RTIR_CustomFieldsDefaults')->{'Constituency'} = 'EDUNET';
 
@@ -61,3 +61,4 @@ diag "create an IR and check that 'SkipNotification' feature works";
     ok $recipient_ok, 'no emails to requestor';
 }
 
+done_testing;
diff --git a/t/report/status.t b/t/report/status.t
index 5d06565..d5dfa56 100644
--- a/t/report/status.t
+++ b/t/report/status.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 30;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -33,3 +33,4 @@ diag "link IR to Inc after create" if $ENV{'TEST_VERBOSE'};
     is $agent->ticket_status($ir_id), 'open', 'auto open kicked in';
 }
 
+done_testing;
diff --git a/t/searches/simple.t b/t/searches/simple.t
index 512c35b..0fd7155 100644
--- a/t/searches/simple.t
+++ b/t/searches/simple.t
@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 
-use RT::IR::Test tests => 24;
+use RT::IR::Test tests => undef;
 
 RT::Test->started_ok;
 my $agent = default_agent();
@@ -31,3 +31,5 @@ my $agent = default_agent();
     $agent->get_ok( "/RTIR/index.html?q=$ir_id" );
     is($agent->uri,$agent->rt_base_url."RTIR/Display.html?id=$ir_id","Directed to the Report Page");
 }
+
+done_testing;
diff --git a/t/tools/lookup.t b/t/tools/lookup.t
index 7c991a3..707bf1d 100644
--- a/t/tools/lookup.t
+++ b/t/tools/lookup.t
@@ -55,4 +55,5 @@ SKIP:{
 }
 
 undef $agent;
-done_testing();
+
+done_testing;
diff --git a/t/upgrade/2.6.0-to-2.9.0.t b/t/upgrade/2.6.0-to-2.9.0.t
index f417b57..6a9dac5 100644
--- a/t/upgrade/2.6.0-to-2.9.0.t
+++ b/t/upgrade/2.6.0-to-2.9.0.t
@@ -8,7 +8,7 @@ BEGIN { unless ( $ENV{RTIR_TEST_UPGRADE} ) {
     Test::More->import( skip_all => "Skipping upgrade tests, it's only for developers" );
 } }
 
-use RT::IR::Test tests => 17;
+use RT::IR::Test tests => undef;
 {
     RT::IR::Test->import_snapshot( 'rtir-2.6.after-rt-upgrade.sql' );
     my ($status, $msg) = RT::IR::Test->apply_upgrade( 'etc/upgrade/', '2.9.0' );
@@ -54,6 +54,8 @@ my @state_cf_ids;
     check_txns($ticket);
 }
 
+done_testing;
+
 sub check_txns {
     my $ticket = shift;
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the rt-commit mailing list