[Rt-commit] rt branch, 4.0/preserve-ticket-basics, repushed

[? sunnavy]

The branch 4.0/preserve-ticket-basics was deleted and repushed:
       was 2879febc29b92c8bbb3ce2ca40696901a60ab59d
       now 238829051bd0d588a3fdf63d5a44af964e4602d8

1:  2e8a49c ! 1:  0a4af10 respect InUnits arg so time input won't be converted automatically
    @@ -35,8 +35,8 @@
     -    $Default = sprintf '%.3f', $Default / 60
     -        unless $Default eq '';
     +if ($Default && $InUnits eq 'hours') {
    -+    $Default = sprintf '%.3f', $Default / 60;
    -+    $Default =~ s!\.000$!!;
    ++    # 0+ here is to remove the ending 0s
    ++    $Default = 0 + sprintf '%.3f', $Default / 60;
      }
      </%INIT>
     
-:  ------- > 2:  060e320 preserve ticket basics in Jumbo
2:  a045e12 ! 3:  15139b4 always handle "2 Owners" case
    @@ -1,27 +1,13 @@
     Author: sunnavy <sunnavy at bestpractical.com>
     
    -    preserve ticket basics in Jumbo
    +    always handle "2 Owners" case
         
    -    so when we are clicking "Add More Files" or "Go"es to search people or groups,
    -    the changes we made could be preserved.
    -    
    -    note that I moved the handling "2 Owners" code out of the condition block so
    -    it can be handled always. without this, the owner input can't be successfully
    -    preserved.  (i.e. you could get an empty default value no matter which owner
    -    you chose)
    +    without this, the owner input can't be successfully preserved.
    +    (i.e. you could get an empty default value no matter which owner you chose)
     
     diff --git a/share/html/Ticket/ModifyAll.html b/share/html/Ticket/ModifyAll.html
     --- a/share/html/Ticket/ModifyAll.html
     +++ b/share/html/Ticket/ModifyAll.html
    -@@
    - <input type="hidden" class="hidden" name="id" value="<%$Ticket->Id%>" />
    - 
    - <&| /Widgets/TitleBox, title => loc('Modify ticket # [_1]', $Ticket->Id), class=>'ticket-info-basics' &>
    --<& Elements/EditBasics, TicketObj => $Ticket &>
    -+<& Elements/EditBasics, TicketObj => $Ticket, defaults => \%ARGS &>
    - <& Elements/EditCustomFields, TicketObj => $Ticket &>
    - </&>
    - 
     @@
      $m->callback( TicketObj => $Ticket, ARGSRef => \%ARGS );
      my @results;
    @@ -49,7 +35,7 @@
     +        elsif (length $owner) {
     +            $ARGS{'Owner'} = $owner unless ($Ticket->OwnerObj->id == $owner);
              }
    - 
    +-
          }
     +}
     +
3:  2879feb = 4:  2388290 test preserved tickets basic fields