[Rt-commit] rt branch, 4.4/sla-typo-and-warning-fixes, created. rt-4.2.11-195-g5d9966a

[? sunnavy]

The branch, 4.4/sla-typo-and-warning-fixes has been created
        at  5d9966a214aa1cb2744d7675e2bd688c4f0c57f7 (commit)

- Log -----------------------------------------------------------------
commit 7627ffbc42f0e1398be5f3864657211769f6b841
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Sep 25 21:59:01 2015 +0800

    typo

diff --git a/etc/RT_Config.pm.in b/etc/RT_Config.pm.in
index 762ab93..51fcd90 100644
--- a/etc/RT_Config.pm.in
+++ b/etc/RT_Config.pm.in
@@ -2924,7 +2924,7 @@ Set(%Lifecycles,
 
 =item C<%ServiceAgreements>
 
-    Set( %ServiceAgreements = (
+    Set( %ServiceAgreements, (
         Default => '4h',
         QueueDefault => {
             'Incident' => '2h',

commit 5d9966a214aa1cb2744d7675e2bd688c4f0c57f7
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Sep 25 22:00:48 2015 +0800

    fix uninitialized warning in case $Default is undef

diff --git a/share/html/Elements/SelectSLA b/share/html/Elements/SelectSLA
index c708ea5..e510863 100644
--- a/share/html/Elements/SelectSLA
+++ b/share/html/Elements/SelectSLA
@@ -50,7 +50,7 @@
 <option value=""<% !$Default ? qq[ selected="selected"] : '' |n %>><%$DefaultLabel |n%></option>
 % }
 % for my $sla ( sort keys %{$RT::ServiceAgreements{'Levels'}} )  {
-<option <% $sla eq $Default ? qq[ selected="selected"] : '' |n %> value="<% $sla %>" ><% $sla %></option>
+<option <% $sla eq ($Default//'') ? qq[ selected="selected"] : '' |n %> value="<% $sla %>" ><% $sla %></option>
 % }
 </select>
 

-----------------------------------------------------------------------