[Rt-commit] rt branch, 4.4/remote-addr-environment-variable, created. rt-4.4.1-156-g1d7c402

[Jim Brandt]

The branch, 4.4/remote-addr-environment-variable has been created
        at  1d7c402a452291090f53839d7c273b6e001281c4 (commit)

- Log -----------------------------------------------------------------
commit 1d7c402a452291090f53839d7c273b6e001281c4
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Mon Dec 12 16:21:18 2016 -0500

    Update REMOTE_ADDR call in ExternalAuth logging
    
    a12a6942 abstracted calls to CGI environment variables, making
    them available via a RequestENV method. Authen::ExternalAuth was
    imported to core and still had the older $ENV reference.

diff --git a/lib/RT/Authen/ExternalAuth.pm b/lib/RT/Authen/ExternalAuth.pm
index eff73bb..652a748 100644
--- a/lib/RT/Authen/ExternalAuth.pm
+++ b/lib/RT/Authen/ExternalAuth.pm
@@ -445,7 +445,7 @@ sub DoAuth {
             $RT::Logger->info(  "Successful login for",
                                 $session->{'CurrentUser'}->Name,
                                 "from",
-                                ($ENV{'REMOTE_ADDR'} || 'UNKNOWN') );
+                                ( RT::Interface::Web::RequestENV('REMOTE_ADDR') || 'UNKNOWN') );
             # Do not delete the session. User stays logged in and
             # autohandler will not check the password again
 

-----------------------------------------------------------------------