[Rt-commit] rt branch, 4.4.0-releng, updated. rt-4.4.0rc2-14-g7197d3d

Shawn Moore shawn at bestpractical.com
Fri Jan 8 15:45:41 EST 2016


The branch, 4.4.0-releng has been updated
       via  7197d3dade64d6ef63a329fe0e4e24bd05ca9cd9 (commit)
      from  8a689c1ea7805e34b5e1dacc9d0bab224d0c116e (commit)

Summary of changes:
 lib/RT/Authen/ExternalAuth/DBI.pm  | 1 -
 lib/RT/Authen/ExternalAuth/LDAP.pm | 1 -
 t/externalauth/sessions.t          | 1 -
 t/externalauth/sqlite.t            | 1 -
 4 files changed, 4 deletions(-)

- Log -----------------------------------------------------------------
commit 7197d3dade64d6ef63a329fe0e4e24bd05ca9cd9
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Fri Jan 8 15:44:55 2016 -0500

    Remove examples mapping ExternalAuthId: it gets cargo culted

diff --git a/lib/RT/Authen/ExternalAuth/DBI.pm b/lib/RT/Authen/ExternalAuth/DBI.pm
index f0945f6..02590df 100644
--- a/lib/RT/Authen/ExternalAuth/DBI.pm
+++ b/lib/RT/Authen/ExternalAuth/DBI.pm
@@ -100,7 +100,6 @@ Provides the database implementation for L<RT::Authen::ExternalAuth>.
             'attr_map' => {
                 'Name'           => 'username',
                 'EmailAddress'   => 'email',
-                'ExternalAuthId' => 'username',
                 'Gecos'          => 'userID',
             },
         },
diff --git a/lib/RT/Authen/ExternalAuth/LDAP.pm b/lib/RT/Authen/ExternalAuth/LDAP.pm
index 444b621..d5da5a0 100644
--- a/lib/RT/Authen/ExternalAuth/LDAP.pm
+++ b/lib/RT/Authen/ExternalAuth/LDAP.pm
@@ -94,7 +94,6 @@ Provides the LDAP implementation for L<RT::Authen::ExternalAuth>.
                 'EmailAddress' => 'mail',
                 'Organization' => 'physicalDeliveryOfficeName',
                 'RealName' => 'cn',
-                'ExternalAuthId' => 'sAMAccountName',
                 'Gecos' => 'sAMAccountName',
                 'WorkPhone' => 'telephoneNumber',
                 'Address1' => 'streetAddress',
diff --git a/t/externalauth/sessions.t b/t/externalauth/sessions.t
index 0a883c2..98eca0c 100644
--- a/t/externalauth/sessions.t
+++ b/t/externalauth/sessions.t
@@ -115,7 +115,6 @@ sub setup_auth_source {
                 'attr_map'        => {
                     'Name'           => 'username',
                     'EmailAddress'   => 'email',
-#                    'ExternalAuthId' => 'username',
                 }
             },
         }
diff --git a/t/externalauth/sqlite.t b/t/externalauth/sqlite.t
index fd119b8..3214b7d 100644
--- a/t/externalauth/sqlite.t
+++ b/t/externalauth/sqlite.t
@@ -54,7 +54,6 @@ RT->Config->Set(
             'attr_map'        => {
                 'Name'           => 'username',
                 'EmailAddress'   => 'email',
-#                'ExternalAuthId' => 'username',
             }
         },
     }

-----------------------------------------------------------------------


More information about the rt-commit mailing list