[Rt-commit] rt branch, 4.4/escape-history-scroll-js, created. rt-4.4.0-249-g972a591

Emannuel Lacour elacour at bestpractical.com
Thu Jun 16 04:01:13 EDT 2016


The branch, 4.4/escape-history-scroll-js has been created
        at  972a591ff13e7228389a11dae2c9b5ac34dce154 (commit)

- Log -----------------------------------------------------------------
commit 972a591ff13e7228389a11dae2c9b5ac34dce154
Author: Emmanuel Lacour <elacour at easter-eggs.com>
Date:   Thu Jun 16 09:59:19 2016 +0200

    Escape history loading error message to avoid breaking JS
    
    Translation of this string may produce a string that contains chars such
    as a single quote which would break javascript parsing.

diff --git a/share/html/Ticket/Elements/ScrollShowHistory b/share/html/Ticket/Elements/ScrollShowHistory
index 6d809ae..7445211 100644
--- a/share/html/Ticket/Elements/ScrollShowHistory
+++ b/share/html/Ticket/Elements/ScrollShowHistory
@@ -108,7 +108,7 @@ jQuery(function(){
         removeLoadingMessage();
         disableLoading = true;
         removeLoadLink();
-        var loadLink = jQuery('<div class="error-load-history"><&|/l&>Could not load ticket history. Reason:</&> ' + reason + '<br/><a href="#"><&|/l&>Try again</&></a></div>');
+        var loadLink = jQuery('<div class="error-load-history"><% loc('Could not load ticket history. Reason:') |h %> ' + reason + '<br/><a href="#"><&|/l&>Try again</&></a></div>');
         jQuery(".history-container").append(loadLink);
     };
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list