[Rt-commit] rt branch, 4.4/show-assets-action-menu, repushed

Dustin Graves dustin at bestpractical.com
Wed Jun 22 18:19:24 EDT 2016


The branch 4.4/show-assets-action-menu was deleted and repushed:
       was 24e07a1e41b59de2102eeeb4f95899feb994b3a0
       now f88d7704e894c6f7477cd43115ffc855336927b8

 1:  f978861 =  1:  15980c8 refactor RT menu building logic into own library module
 2:  95f0bd7 =  2:  76af288 refactor asset menu logic into own function
 3:  fbd1a3f =  3:  c4a93c2 add asset display menu actions to ShowAssets template
 4:  e2db149 !  4:  714afb2 style assets action menu on ShowAssets element
    @@ -14,9 +14,10 @@
     +%# show asset actions menu
     +% HTML::Mason::Commands::PageMenu()->{children} = undef; # clear previous settings from page load so we can show just the actions
      % RT::Interface::Web::MenuBuilder::_BuildAssetMenuActionSubmenu($asset);
    - <& /Elements/Menu, menu => PageMenu(), id => 'asset-actions-menu', parent_id => 'asset' &>
    +-<& /Elements/Menu, menu => PageMenu(), id => 'asset-actions-menu', parent_id => 'asset' &>
    ++<& /Elements/Menu, menu => PageMenu(), id => 'asset-'.$asset->id.'-actions-menu', parent_id => 'asset-'.$asset->id &>
     +<script>
    -+jQuery("#asset-actions-menu").addClass('sf-menu sf-js-enabled sf-shadow').supersubs().superfish({ dropShadows: false, speed: 'fast' }).supposition()
    ++jQuery("#assets-accordion ul.toplevel").addClass('sf-menu sf-js-enabled sf-shadow').supersubs().superfish({ dropShadows: false, speed: 'fast' }).supposition()
     +    .find('a').click(function(ev){
     +        ev.stopPropagation();
     +        return true;
    @@ -35,7 +36,7 @@
          }
      }
     +
    -+#asset-actions-menu {
    ++#assets-accordion ul.toplevel {
     +    position: absolute;
     +    top: 0;
     +    right: 20px;
    @@ -43,16 +44,24 @@
     +    font-size: .9em;
     +}
     +
    -+#asset-actions-menu  a {
    ++#assets-accordion li.has-children {
    ++    background: transparent;
    ++}
    ++
    ++#assets-accordion li.has-children ul {
    ++    min-width: 12em;
    ++}
    ++
    ++#assets-accordion a {
     +    border: none;
     +    color: #000;
     +}
     +
    -+#asset-actions {
    ++#assets-accordion a.sf-with-ul {
     +    padding-top: .3em;
     +}
     +
    -+#asset-actions > .sf-sub-indicator {
    ++#assets-accordion .sf-sub-indicator {
     +    top: .2em;
     +}
     
 5:  24e07a1 < --:  ------- properly support multiple assets in assets action menu on ShowAssets element
--:  ------- >  5:  b1d00fb pass %ARGS to BuildMainNav and BuildSelfServiceNav
--:  ------- >  6:  20f48e5 remove extra whitespace
--:  ------- >  7:  e816d03 make BuildAdminMenu private function
--:  ------- >  8:  00a905f clarify legacy callbacks in RT::Interface::Web::MenuBuilder and pass CallbackPage
--:  ------- >  9:  e89f308 add local "loc" function to remove HTML::Mason::Commands noise
--:  ------- > 10:  d5d95f9 replace repeated calls to HTML::Mason::Commands::Menu() with $top variable
--:  ------- > 11:  ede0a8f replace repeated calls to HTML::Mason::Commands::PageWidgets() with $widgets variable
--:  ------- > 12:  d4eb9e9 replace repeated calls to $HTML::Mason::Commands::session{CurrentUser} with $current_user variable
--:  ------- > 13:  581f1b2 replace repeated calls to HTML::Mason::Commands::PageMenu() with $page variable
--:  ------- > 14:  3561f38 define a new calling convention for menu building functions
--:  ------- > 15:  3b132df replace ugly hack with new RT::Interface::Web::Menu object now that we have our refactored menu functions
--:  ------- > 16:  f88d770 remove hover delay on ShowAssets action menu



More information about the rt-commit mailing list