[Rt-commit] rt branch, 4.2-trunk, updated. rt-4.2.12-121-g61992d4

Shawn Moore shawn at bestpractical.com
Fri May 13 17:57:51 EDT 2016


The branch, 4.2-trunk has been updated
       via  61992d4198cd704f6d23da9f59ccc706f0501a8c (commit)
      from  7baea5a404cbf9e6f451c01bf3210b22007cee2e (commit)

Summary of changes:
 share/html/Elements/ShowTransactionAttachments | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 61992d4198cd704f6d23da9f59ccc706f0501a8c
Author: rachelkelly <rachel at bestpractical.com>
Date:   Fri May 13 17:56:00 2016 -0400

    Remove url-escaping character from attachment name parsing
    
        Attachments in ticket replies and comments are parsed incorrectly
        if they contain html characters.  Included url escaping and added
        requirement that no other escaping be done.  Attachment names
        which include ? and & and other url-sensitive characters will be
        preserved.
    
    Fixes: #I31751

diff --git a/share/html/Elements/ShowTransactionAttachments b/share/html/Elements/ShowTransactionAttachments
index 9d222a5..e0a4b50 100644
--- a/share/html/Elements/ShowTransactionAttachments
+++ b/share/html/Elements/ShowTransactionAttachments
@@ -63,7 +63,7 @@ foreach my $message ( @{ $Attachments->{ $Parent || 0 } || [] } ) {
     if ($should_render_download) {
 </%PERL>
 <div class="downloadattachment">
-<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | u%>"><&|/l&>Download</&> <% length $name ? $name : loc('(untitled)') %></a>\
+<a href="<% $AttachmentPath %>/<% $Transaction->Id %>/<% $message->Id %>/<% $name | un%>"><&|/l&>Download</&> <% length $name ? $name : loc('(untitled)') %></a>\
 % if ( $DownloadableHeaders && ! length $name && $message->ContentType =~ /text/  ) {
  / <a href="<% $AttachmentPath %>/WithHeaders/<% $message->Id %>"><% loc('with headers') %></a>
 % }

-----------------------------------------------------------------------


More information about the rt-commit mailing list