[Rt-commit] rt branch, 4.6/inline-edit, updated. rt-4.4.1-172-g6bda46a

Shawn Moore shawn at bestpractical.com
Tue Sep 20 14:09:31 EDT 2016


The branch, 4.6/inline-edit has been updated
       via  6bda46a6276275cdf36efe3090b57a2b45c6f29f (commit)
       via  2c229f1ab4d8030631bbfa1ebbc0f6183c068324 (commit)
       via  b8d71567c12719ceec596b0025fae3752ac0e56b (commit)
      from  417568ebd2b9c615fa482eef82c65722005e196f (commit)

Summary of changes:
 share/static/css/base/inline-edit.css | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

- Log -----------------------------------------------------------------
commit b8d71567c12719ceec596b0025fae3752ac0e56b
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Tue Sep 20 18:04:25 2016 +0000

    Remove extra, unnecessary padding

diff --git a/share/static/css/base/inline-edit.css b/share/static/css/base/inline-edit.css
index 7c82b09..39b91b6 100644
--- a/share/static/css/base/inline-edit.css
+++ b/share/static/css/base/inline-edit.css
@@ -8,11 +8,6 @@ table.inline-edit td .value {
     padding: 0.25em 0.25em 0.125em 0.125em;
 }
 
-table.inline-edit tr.oddline td.editable.editing,
-table.inline-edit tr.evenline td.editable.editing {
-    padding: 0.5em 0.5em 0.25em 0.25em;
-}
-
 td.editable .value:hover {
     background: #ffd url(../../../static/images/pencil.png) no-repeat top right;
     background-size: auto 100%;

commit 2c229f1ab4d8030631bbfa1ebbc0f6183c068324
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Tue Sep 20 18:06:40 2016 +0000

    Use a :not CSS rule rather than reset
    
    This will let us (and customizations) do things that can't be reset

diff --git a/share/static/css/base/inline-edit.css b/share/static/css/base/inline-edit.css
index 39b91b6..9a34922 100644
--- a/share/static/css/base/inline-edit.css
+++ b/share/static/css/base/inline-edit.css
@@ -8,19 +8,13 @@ table.inline-edit td .value {
     padding: 0.25em 0.25em 0.125em 0.125em;
 }
 
-td.editable .value:hover {
+body:not(.inline-editing) td.editable .value:hover {
     background: #ffd url(../../../static/images/pencil.png) no-repeat top right;
     background-size: auto 100%;
     border-color: black;
     cursor: pointer;
 }
 
-body.inline-editing td.editable .value:hover {
-    background: inherit;
-    border-color: transparent;
-    cursor: inherit;
-}
-
 td.editable > form.editor > .loading > img,
 td.editable > form.editor > .cancel > img {
     height: 1.5em;

commit 6bda46a6276275cdf36efe3090b57a2b45c6f29f
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Tue Sep 20 18:08:55 2016 +0000

    Use constant background-size height
    
    100% means multi-value rows (like a CF) will render the icon as gigantic

diff --git a/share/static/css/base/inline-edit.css b/share/static/css/base/inline-edit.css
index 9a34922..2a8857d 100644
--- a/share/static/css/base/inline-edit.css
+++ b/share/static/css/base/inline-edit.css
@@ -10,7 +10,7 @@ table.inline-edit td .value {
 
 body:not(.inline-editing) td.editable .value:hover {
     background: #ffd url(../../../static/images/pencil.png) no-repeat top right;
-    background-size: auto 100%;
+    background-size: auto 1.5em;
     border-color: black;
     cursor: pointer;
 }

-----------------------------------------------------------------------


More information about the rt-commit mailing list