[Rt-commit] rtir branch, 4.0/walk-test, created. 4.0.0-38-g3822976

[Shawn Moore]

The branch, 4.0/walk-test has been created
        at  382297649457afb36bd982012e288b72f6327893 (commit)

- Log -----------------------------------------------------------------
commit 382297649457afb36bd982012e288b72f6327893
Author: Shawn M Moore <shawn at bestpractical.com>
Date:   Tue Feb 28 16:37:34 2017 +0000

    Fix failing t/walk-web.t tests
    
    Versions of Mason prior to 1.52 throw an undef warning when
    $args{Lifecycle} is not defined, which caused t/walk-web.t to fail
    tests.
    
    Prior to 84672d0cfea5a511c1ae2d66569b850861ac7d8e, this warning didn't
    happen because we'd skipped undef:
    
        % next unless defined $val;
        <input type="hidden" class="hidden" name="<% $key %>" value="<% $val %>" />
    
    Incidentally, the Lifecycle parameter appears to be more or less
    vestigial at this point; nowadays TicketSQL supports Lifecycle as a
    search term.
    
    Fixes: T#181179

diff --git a/html/RTIR/Search/Reporting.html b/html/RTIR/Search/Reporting.html
index a350afa..a4332b8 100644
--- a/html/RTIR/Search/Reporting.html
+++ b/html/RTIR/Search/Reporting.html
@@ -135,8 +135,8 @@ $m->callback( ARGSRef => \%ARGS, QueryArgsRef => \%query );
 <div class="chart-type">
 
 <form method="get" action="<% RT->Config->Get('WebPath') %>/RTIR/Search/Reporting.html">
-<input type="hidden" class="hidden" name="Lifecycle" value="<% $query{Lifecycle} %>" />
-<input type="hidden" class="hidden" name="Query" value="<% $query{Query} %>" />
+<input type="hidden" class="hidden" name="Lifecycle" value="<% $query{Lifecycle} // '' %>" />
+<input type="hidden" class="hidden" name="Query" value="<% $query{Query} // '' %>" />
 <input type="hidden" class="hidden" name="SavedChartSearchId" value="<% $saved_search->{SearchId} || 'new' %>" />
 
 <&| /Widgets/TitleBox, title => loc('Group by'), class => "chart-group-by" &>

-----------------------------------------------------------------------