[Rt-commit] rt branch, 4.4.2-releng, updated. rt-4.4.2rc2-1-gbff32c5

Shawn Moore shawn at bestpractical.com
Thu Jun 29 13:59:29 EDT 2017


The branch, 4.4.2-releng has been updated
       via  bff32c52d6465cf329b280542e48cb976a980078 (commit)
      from  3f9e376a334670e12b5570b9ded1f6f2d7d6c059 (commit)

Summary of changes:
 share/html/Elements/ShowCustomFields | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit bff32c52d6465cf329b280542e48cb976a980078
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Tue Jun 27 08:46:48 2017 -0400

    Apply unset-field when cfs do not have a count
    
    In converting a ternary evaluation of $count to an if,
    523fabb1 missed a 'not' to correctly add unset-field to
    cfs with no values, flipping the set/unset visibility logic.

diff --git a/share/html/Elements/ShowCustomFields b/share/html/Elements/ShowCustomFields
index c6df0d3..2f7d2ae 100644
--- a/share/html/Elements/ShowCustomFields
+++ b/share/html/Elements/ShowCustomFields
@@ -58,7 +58,7 @@
 %   'custom-field',
 %   'custom-field-'.$CustomField->id,
 % );
-% push @classes, 'unset-field' if $count;
+% push @classes, 'unset-field' if not $count;
 % $m->callback( CallbackName => 'ModifyFieldClasses', CustomField => $CustomField,
 %               Object => $Object, Classes => \@classes, Grouping => $Grouping );
   <tr class="<% join(' ', @classes) %>" id="CF-<%$CustomField->id%>-ShowRow">

-----------------------------------------------------------------------


More information about the rt-commit mailing list