[Rt-commit] rt branch, 4.4/unpriv-lifecycle, repushed

Shawn Moore shawn at bestpractical.com
Tue May 23 16:30:13 EDT 2017


The branch 4.4/unpriv-lifecycle was deleted and repushed:
       was db6db0579a02a1856142cea733bfc0117e11fc97
       now be649e73f901a6bb928825aa6613729b960b2c2d

1:  9cc9701 = 1:  9cc9701 Failing tests for lifecycles without SeeQueue
2:  db6db05 ! 2:  be649e7 Walk around ACLs when working with lifecycles
    @@ -2,20 +2,24 @@
     
         Walk around ACLs when working with lifecycles
         
    -    This fixes an issue where unprivileged users - those without SeeQueue -
    -    would be given the default lifecycle instead of the queue's lifecycle.
    +    This fixes an issue where unprivileged users - essentially anyone
    +    without SeeQueue - would be given the default lifecycle instead of the
    +    queue's lifecycle (because $queue->Lifecycle is guarded by SeeQueue).
         This is wholly inappropriate when the queue's lifecycle does not
         resemble the default one. The symptom is that users see unexpected
         errors like "Status 'custom' isn't a valid status for this ticket" even
         when "custom" is a valid status for that ticket's lifecycle, and can be
         transitioned to.
         
    -    So, rather than ignoring the queue's lifecycle, open it up so that if
    +    So, rather than ignoring the queue's lifecycle, open it up so that when
         you're working with a ticket, permissions no longer hide the lifecycle.
         This does potentially open up lifecycles that had been previously hidden
         by rights, but there are a few mitigating factors. A lifecycle is
         unlikely to have private or sensitive information in it. There's also
         very little UI for lifecycles beyond the "select status" dropdown.
    +    
    +    This mirrors prior art to walk around ACLs to maintain consistency, such
    +    as 68b6a66f.
         
         Fixes: I#32799
     



More information about the rt-commit mailing list