[Rt-commit] rt branch, 4.4/validate-default-roles, updated. rt-4.4.3-91-gab2fb018b

[? sunnavy]

The branch, 4.4/validate-default-roles has been updated
       via  ab2fb018bba2ff2bfad61453708d9f3c9acb6634 (commit)
      from  5ed396095275a5e94e4cc86969a2da438f564e40 (commit)

Summary of changes:
 sbin/rt-validator.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit ab2fb018bba2ff2bfad61453708d9f3c9acb6634
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Dec 14 03:39:48 2018 +0800

    Skip merged tickets in role groups validation
    
    Those role groups are not actually used any more, so there is no need to
    re-create them.
    
    Even worse, for "Owner" role group, a simple re-creation is not good
    enough as the group always expects a user in it, which normally could be
    covered by other "resolve" code, but sadly not for merged tickets. So if
    we create an "Owner" role group without a user in it for a merged ticket
    here, rt-validator will always warn something like:
    
        The owner of ticket #2 is inconsistent. The denormalized owner is user #6
        but there is no normalized owner.
        Found a ticket that has no normalized Owner group member.
    
    Let's just not create those useless role groups.

diff --git a/sbin/rt-validator.in b/sbin/rt-validator.in
index 855ee7a59..d8a8d22e9 100644
--- a/sbin/rt-validator.in
+++ b/sbin/rt-validator.in
@@ -336,7 +336,7 @@ push @CHECKS, 'Tickets <-> Role Groups' => sub {
     my $res = 1;
     for my $role (qw/Requestor Owner Cc AdminCc/ ) {
         $res *= check_integrity(
-            'Tickets', 'id' => 'Groups', 'Instance',
+            'Tickets', 'EffectiveId' => 'Groups', 'Instance',
             join_condition   => 't.Domain = ? AND t.Name = ?',
             bind_values => [ 'RT::Ticket-Role', $role ],
             action => sub {

-----------------------------------------------------------------------