[Rt-commit] rt branch, 4.4/optional-articles-ticket-linking, created. rt-4.4.3-80-g314d86670

[Maureen Mirville]

The branch, 4.4/optional-articles-ticket-linking has been created
        at  314d866708fbf9d99cac2a80696cb0b8a17cf09f (commit)

- Log -----------------------------------------------------------------
commit 3283397ad4d306153bf8f1c5aa8bf46b103b73f7
Author: Maureen E. Mirville <maureen at bestpractical.com>
Date:   Thu Dec 6 01:47:48 2018 -0500

    Add option to disable ticket linking in articles by class

diff --git a/share/html/Admin/Articles/Classes/Modify.html b/share/html/Admin/Articles/Classes/Modify.html
index f69a1601d..2bf492ad6 100644
--- a/share/html/Admin/Articles/Classes/Modify.html
+++ b/share/html/Admin/Articles/Classes/Modify.html
@@ -84,6 +84,10 @@
 
 <h3><&|/l&>When inserting articles in this class into emails:</&></h3>
 <ul>
+<li>
+    <input type="checkbox" id="Include-TicketLinking" name="Include-TicketLinking" value="1" <% $include{TicketLinking} %>>
+    <label for="Include-TicketLinking"><&|/l&>Link article to ticket</&></label>
+</li>
 <li>
     <input type="checkbox" id="Include-Name" name="Include-Name" value="1" <% $include{Name} %>>
     <label for="Include-Name"><&|/l&>Include article name</&></label>
@@ -191,7 +195,7 @@ if ((defined $Enabled && $Enabled == 1) or (not defined $Enabled and $Create)) {
     $Disabled = 1;
 }
 
-my %include = (Name => 1, Summary => 1, EscapeHTML => 1);
+my %include = ( Name => 1, Summary => 1, EscapeHTML => 1, TicketLinking => 1 );
 my $subject_cfs = [];
 my $subject_cf_labels = {};
 
diff --git a/share/html/Articles/Elements/BeforeMessageBox b/share/html/Articles/Elements/BeforeMessageBox
index 8c84eb102..259001f4e 100644
--- a/share/html/Articles/Elements/BeforeMessageBox
+++ b/share/html/Articles/Elements/BeforeMessageBox
@@ -164,7 +164,7 @@ if ( $ARGS{id} && $ARGS{id} ne 'new' ) {
             Field => substr($arg, length($name_prefix)),
             Value => $ARGS{$arg},
         );
-        if ($article->Id) {
+        if ($article->Id and not $article->ClassObj->FirstAttribute('Skip-TicketLinking')) {
             $uri{$article->URI}++;
         }
     }

commit 314d866708fbf9d99cac2a80696cb0b8a17cf09f
Author: Maureen E. Mirville <maureen at bestpractical.com>
Date:   Thu Dec 6 16:28:49 2018 -0500

    Update Articles docs to include disabling ticket linking

diff --git a/docs/customizing/articles_introduction.pod b/docs/customizing/articles_introduction.pod
index 09b42d531..23f8c69b4 100644
--- a/docs/customizing/articles_introduction.pod
+++ b/docs/customizing/articles_introduction.pod
@@ -132,6 +132,21 @@ tags per article class. This can be done by unchecking the "Escape HTML"
 box on the Modify Class page. Please note this is potentially unsafe and
 its use should be limited to trusted administrators.
 
+=head3 Disabling Ticket Linking
+
+When an article is included in a ticket's comment or response, the article
+is automatically added as a link to the ticket. This means that the article
+will be listed under the Links portlet on the Ticket Display page, and also
+on the Article display page. Having these links listed can be very useful
+and is RT's default behavior. However, some instances of RT use articles
+heavily, and having a large list of ticket links on the Ticket or Article
+display page, may not be ideal. To make this feature of RT more flexible,
+there is an option to disable ticket linking by class. This can be done by
+visiting the Modify Classes page and unchecking the "Link article to ticket"
+option under "When inserting articles in this class into emails". Note, that
+disabling this feature will only affect future comments/replies on tickets.
+Existing links to articles in the class will remain linked.
+
 =head2 Queue-Specific List of Articles 
 
 You can use Topics to organize a set of Queue-specific Articles.

-----------------------------------------------------------------------