[Rt-commit] rt branch, 4.4/queue-in-orderby, repushed

Brian Duggan brian at bestpractical.com
Tue Jan 9 13:01:40 EST 2018


The branch 4.4/queue-in-orderby was deleted and repushed:
       was 8edd604e04391249d31170d8cb1b6ef00911af49
       now 0fb0b1bb1c469d01a35dd765daf430dc25f14699

1: 92a309753 ! 1: 97fd82ba9 Add test for 'Order by' dropdown content
    @@ -68,17 +68,17 @@
     +    my @scraped_orderbys = $agent->scrape_text_by_attr('name', 'OrderBy');
     +
     +    for my $idx (0.. at scraped_orderbys-1) {
    -+	if ($idx == 0) {
    -+	    is ($scraped_orderbys[$idx], $orderby);
    -+	} else {
    -+	    is ($scraped_orderbys[$idx], '[none] '.$orderby);
    -+	}
    ++        if ($idx == 0) {
    ++            is ($scraped_orderbys[$idx], $orderby);
    ++        } else {
    ++            is ($scraped_orderbys[$idx], '[none] '.$orderby);
    ++        }
     +    }
     +    
     +    my $cf = RT::Test->load_or_create_custom_field(
    -+	Name  => 'Location',
    -+	Queue => 'General',
    -+	Type  => 'FreeformSingle', );
    ++        Name  => 'Location',
    ++        Queue => 'General',
    ++        Type  => 'FreeformSingle', );
     +    isa_ok( $cf, 'RT::CustomField' );
     +
     +    ok($agent->form_name('BuildQuery'), "found the form");
    @@ -94,11 +94,11 @@
     +    @scraped_orderbys = $agent->scrape_text_by_attr('name', 'OrderBy');
     +
     +    for my $idx (0.. at scraped_orderbys-1) {
    -+	if ($idx == 0) {
    -+	    is ($scraped_orderbys[$idx], $orderby);
    -+	} else {
    -+	    is ($scraped_orderbys[$idx], '[none] '.$orderby);
    -+	}
    ++        if ($idx == 0) {
    ++            is ($scraped_orderbys[$idx], $orderby);
    ++        } else {
    ++            is ($scraped_orderbys[$idx], '[none] '.$orderby);
    ++        }
     +    }
     +
     +    $cf->SetDisabled(1);
2: 8edd604e0 = 2: 0fb0b1bb1 Re-add Queue to 'Order by' dropdown in Search Builder



More information about the rt-commit mailing list