[Rt-commit] rt branch, 4.4/shredder-user-uid, repushed

Craig Kaiser craig at bestpractical.com
Mon Jun 4 16:06:55 EDT 2018


The branch 4.4/shredder-user-uid was deleted and repushed:
       was 9f4e4c1c05c230b9f8754cf6c6e92b2ee54b2926
       now 711b822f24a24c9c0914b01a4d3a6d290267cc1e

1: 953868daf < -:  ------- Add test to hit shredder web UI
-:  ------- > 1: 4ad9855bd Add test to hit shredder web UI
2: 9f4e4c1c0 ! 2: 711b822f2 Restrict Name checks to RT::User objects when shredding
    @@ -1,9 +1,15 @@
     Author: Craig Kaiser <craig at bestpractical.com>
     
    -    Only check for Name on user objects for rt shredder
    +    Restrict Name checks to RT::User objects when shredding
         
    -    For CastObjectsToRecords in Shredder.pm do not want to check for Name
    -    method unless the object provided is a user object
    +    92dc904 updated the id check in Shredder to allow usernames to be
    +    passed in addition to numeric ids. However, it relies on the ->Name
    +    method and not all shreddable objects have that method, resulting
    +    in errors like:
    +    
    +    error: RT::Ticket::Name Unimplemented in RT::Shredder
    +    
    +    Restrict the ->Name check to only RT::User objects.
     
     diff --git a/lib/RT/Shredder.pm b/lib/RT/Shredder.pm
     --- a/lib/RT/Shredder.pm



More information about the rt-commit mailing list