[Rt-commit] rt branch, 4.4/fix-deserialize-recently-viewed-tickets, repushed

Craig Kaiser craig at bestpractical.com
Mon Oct 29 17:01:17 EDT 2018


The branch 4.4/fix-deserialize-recently-viewed-tickets was deleted and repushed:
       was 12ad6d48afb1c6a0902224adaa3c5c2d91e54a01
       now fb3b54b7967c12b3eb7144f4425550efb42c17d6

1: 12ad6d48a ! 1: fb3b54b79 Load Content rather than Attribute object for RecentlyViewedTickets
    @@ -1,6 +1,17 @@
     Author: Craig Kaiser <craig at bestpractical.com>
     
    -    Check if attribute content exist not the attribute
    +    Load Content rather than Attribute object for RecentlyViewedTickets
    +    
    +    Previously, if the RecentlyViewedTickets content somehow was set
    +    to undef, $content still evaluated to true because it was an
    +    RT::Attribute object. Calling the Content method then resulted in:
    +    
    +        Can't use an undefined value as an ARRAY reference
    +    
    +    This caused a 500 error for the end-user.
    +    
    +    Loading the content provides the intended true/false value and handles
    +    the empty content case.
     
     diff --git a/lib/RT/User.pm b/lib/RT/User.pm
     --- a/lib/RT/User.pm



More information about the rt-commit mailing list