[Rt-commit] rt branch, master, updated. rt-4.4.4-56-g9e0a58aba

Jim Brandt jbrandt at bestpractical.com
Thu Apr 4 14:43:58 EDT 2019


The branch, master has been updated
       via  9e0a58aba687f62c8935aacfcb5a5aea9281795c (commit)
      from  6b37a3036e39cc7bc059bcb5eb49fb501a2e3611 (commit)

Summary of changes:
 t/web/quicksearch.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 9e0a58aba687f62c8935aacfcb5a5aea9281795c
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Apr 4 14:35:55 2019 -0400

    Refine TODO test for content on merged tickets
    
    Setting ShowSearchResultCount on by default puts the string
    "(Found n ticket)" next to searches on the home page. The search
    in this test also looks for that string, but in the context of
    a search result. Having it appear on the home page caused the
    TODO test to incorrectly pass.
    
    Refine the search to match only on the string when found in an
    h1 header line.

diff --git a/t/web/quicksearch.t b/t/web/quicksearch.t
index 922dc318f..b8fc963c4 100644
--- a/t/web/quicksearch.t
+++ b/t/web/quicksearch.t
@@ -45,6 +45,6 @@ $m->form_with_fields('q');
 $m->field(q => 'fulltext:MERGEDAWAY');
 TODO:  {
     local $TODO = "We don't yet handle merged ticket content searches right";
-$m->content_contains('Found 1 ticket');
+$m->content_contains('<h1>Found 1 ticket</h1>');
 }
 $m->content_contains('base ticket', "base ticket is found, not the merged-away ticket");

-----------------------------------------------------------------------


More information about the rt-commit mailing list