[Rt-commit] rt branch, 4.6/inline-edit-new-theme, repushed

? sunnavy sunnavy at bestpractical.com
Thu Dec 5 17:04:50 EST 2019


The branch 4.6/inline-edit-new-theme was deleted and repushed:
       was 57eb90363a39e39b24c61fc53d616c1654416904
       now 75f7353496cf9e6dfdde4c6f8eccc967b6b1cb57

 1: 6a56e9b0ee =  1: 6a56e9b0ee Add a helper AJAX endpoint for generic ticket update
 2: 5542087952 =  2: 5542087952 Add comment explaining why HasRights is called without checking return value
 3: b42e835ab8 =  3: b42e835ab8 Add jGrowl 1.4.5
 4: 5c2e1696d3 =  4: 5c2e1696d3 Add InlineEdit config and preference
 5: be9b6791bc =  5: be9b6791bc Add an AJAX helper for refreshing CollectionList rows
 6: dc986f4a45 =  6: dc986f4a45 Add a way to omit id from date pickers
 7: 3107ed1662 =  7: 3107ed1662 Add fontawesome pencil-alt icon for inline edit
 8: 91c913785f =  8: 91c913785f Add fontawesome times icon as "Cancel" for inline edit
 9: 57eb90363a !  9: 12ffc2dd82 Support inline edit on ticket search results and display pages
    @@ -464,7 +464,7 @@
     +    my $modify_inline
     +        = '<a class="inline-edit-toggle edit" href="'
     +        . $m->interp->apply_escapes( ( $modify_url || '#' ), 'h' ) . '">'
    -+        . qq{<span class="fas fa-cog icon-bordered fa-2x" alt="$edit_label" data-toggle="tooltip" data-placement="top" data-original-title="$edit_label"></span>}
    ++        . qq{<span class="fas fa-pencil-alt icon-bordered fa-2x" alt="$edit_label" data-toggle="tooltip" data-placement="top" data-original-title="$edit_label"></span>}
     +        . '</a>'
     +        . '<a class="inline-edit-toggle cancel hidden" href="#">'
     +        . qq{<span class="fas fa-times icon-bordered fa-2x" alt="$cancel_label" data-toggle="tooltip" data-placement="top" data-original-title="$cancel_label"></span>}
    @@ -784,7 +784,7 @@
     +my $modify_url = RT->Config->Get('WebPath')."/Ticket/Modify.html?id=".$Ticket->Id;
     +my $modify_inline
     +    = '<a class="inline-edit-toggle edit" href="%s">'
    -+    . qq{<span class="fas fa-cog icon-bordered fa-2x" alt="$edit_label" data-toggle="tooltip" data-placement="top" data-original-title="$edit_label"></span>}
    ++    . qq{<span class="fas fa-pencil-alt icon-bordered fa-2x" alt="$edit_label" data-toggle="tooltip" data-placement="top" data-original-title="$edit_label"></span>}
     +    . '</a>'
     +    . '<a class="inline-edit-toggle cancel hidden" href="#">'
     +    . qq{<span class="fas fa-times icon-bordered fa-2x" alt="$cancel_label" data-toggle="tooltip" data-placement="top" data-original-title="$cancel_label"></span>}
    @@ -1004,6 +1004,15 @@
     +  display: inline;
     +  float: right;
     +  margin-top: 0.25em;
    ++  visibility: hidden;
    ++}
    ++
    ++td.editable .value:hover .edit-icon {
    ++  visibility: visible;
    ++}
    ++
    ++td.editable .value:hover .edit-icon:hover {
    ++  cursor: pointer;
     +}
     +
     +td .value .edit-icon {
    @@ -1373,3 +1382,4 @@
      // focus jquery object in window, only moving the screen when necessary
      function scrollToJQueryObject(obj) {
          if (!obj.length) return;
    +
--:  ------- > 10: 75f7353496 Update tests for the new added inline-edit feature



More information about the rt-commit mailing list