[Rt-commit] rt branch, master, updated. rt-4.4.4-542-g5bf8c70ba6

? sunnavy sunnavy at bestpractical.com
Fri Dec 6 16:04:22 EST 2019


The branch, master has been updated
       via  5bf8c70ba6c00e5652909a464fa505abbe1e9319 (commit)
      from  b808f3126affb4540a88debaa359361ed72f066a (commit)

Summary of changes:
 share/html/Elements/ShowSearch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 5bf8c70ba6c00e5652909a464fa505abbe1e9319
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Sat Dec 7 04:37:32 2019 +0800

    Don't show edit icon if there is no link to edit page for searches
    
    When there is no link, the Edit icon is unclickable and useless.
    
    Previously when we converted "Edit" to an icon, the $customize conditon
    check got removed by accident. This commit adds it back.
    
    See also e571ceb5b2

diff --git a/share/html/Elements/ShowSearch b/share/html/Elements/ShowSearch
index c541237458..89d6814dbf 100644
--- a/share/html/Elements/ShowSearch
+++ b/share/html/Elements/ShowSearch
@@ -51,7 +51,7 @@
     title => loc(RT::SavedSearch->EscapeDescription($search->Description), $ProcessedSearchArg->{'Rows'}),
     title_raw => $title_raw,
     title_href => $query_link_url.$QueryString,
-    titleright_raw => qq[<span class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
+    titleright_raw => $customize ? qq[<span class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>] : '',
     titleright_href => $customize,
     hideable => $hideable,
     class => 'fullwidth' &>

-----------------------------------------------------------------------


More information about the rt-commit mailing list