[Rt-commit] rt branch, 4.6/fix-menu-overflows, repushed

Blaine Motsinger blaine at bestpractical.com
Fri Dec 20 20:16:00 EST 2019


The branch 4.6/fix-menu-overflows was deleted and repushed:
       was 116d2df1a724997ff1ea0c08bffeac7ca0f620d1
       now d4e443fae47909f1de6b73ad5fc44406fda6e13f

1: f3bc81d61b = 1: f3bc81d61b Fix overflow for main and page navigation
2: df61ca1a72 ! 2: 4d59a877f8 Add collapse to topactions buttons
    @@ -1,13 +1,15 @@
     Author: Blaine Motsinger <blaine at bestpractical.com>
     
    -    Re-add collapsing topactions buttons
    +    Add collapse to topactions buttons
         
    -    This commit re-adds the topactions collapsing functionality to
    -    allow more space for app-nav before it overflows to the "more" menu.
    +    This commit makes the topactions buttons collapse for smaller
    +    window sizes.
         
    -    The functionality is slightly different as it doesn't contain the
    -    dropdown for queue selection, but uses the classes which were
    -    already in place.
    +    The search and create buttons previously collapsed in a similar
    +    way before removing the queue selection dropdown from topactions.
    +    This update has slightly different styling and removes the easing
    +    animation on window sizes smaller than 1300px to save colliding
    +    with the main-navigation.
     
     diff --git a/share/html/Elements/CreateTicket b/share/html/Elements/CreateTicket
     --- a/share/html/Elements/CreateTicket
    @@ -53,25 +55,69 @@
          -webkit-appearance: textfield;
      }
      
    -+/* search focus in #topactions */
    - #topactions input[type="search"]:focus {
    +-#topactions input[type="search"]:focus {
     -    width: 16em;
    +-    -webkit-transition: width 0.25s ease-in-out;
    +-    -moz-transition: width 0.25s ease-in-out;
    +-    -ms-transition: width 0.25s ease-in-out;
    +-    transition: width 0.25s ease-in-out;
    ++/* topactions search box sizes and easing definitions
    ++
    ++for browser sizes
    ++- 1300px or greater, when in focus grow to 16em with easing then shrink back to 10em with easing.
    ++- smaller than 1300px, don't grow and disable easing, but size remains 10em.
    ++- 900px or smaller, change size to 4.7em.
    ++
    ++*/
    ++#topactions input,
    ++#topactions button {
     +    width: 10em;
    -     -webkit-transition: width 0.25s ease-in-out;
    -     -moz-transition: width 0.25s ease-in-out;
    -     -ms-transition: width 0.25s ease-in-out;
    -     transition: width 0.25s ease-in-out;
    - }
    - 
    -+ at media (max-width: 900px) or (max-width: 600px) {
    ++}
    ++
    ++ at media (min-width: 1300px) {
    ++    #topactions input,
    ++    #topactions button {
    ++        -webkit-transition: width 0.25s ease-in-out;
    ++        -moz-transition: width 0.25s ease-in-out;
    ++        -ms-transition: width 0.25s ease-in-out;
    ++        transition: width 0.25s ease-in-out;
    ++    }
    ++
     +    #topactions input[type="search"]:focus {
    -+        width: 4.7em;
    ++        width: 16em;
     +    }
     +}
     +
    ++ at media (max-width: 900px) {
    ++    #topactions input {
    ++        width: 4.7em;
    ++    }
    + }
    + 
      #topactions input[type="search"]::-webkit-search-cancel-button {
    -     /* hide webkit x button for searches */
    -     -webkit-appearance: none;
    +@@
    +     padding-left: 0.5em;
    +     padding-right: 0.5em;
    +     vertical-align: middle;
    +-
    +-    width: 10em;
    +-    -webkit-transition: width 0.25s ease-in-out;
    +-    -moz-transition: width 0.25s ease-in-out;
    +-    -ms-transition: width 0.25s ease-in-out;
    +-    transition: width 0.25s ease-in-out;
    + }
    + 
    + @-moz-document url-prefix() {
    +@@
    +     #topactions .create-medium { display: block; }
    +     #topactions .create-narrow { display: none; }
    + 
    +-    #topactions input[type="search"] {
    +-        width: 2em;
    +-    }
    +     #topactions form {
    +         margin-left: 0;
    +     }
     @@
          div#header h1 {
              right: 10em;
3: c8225d8b06 ! 3: d5fb13834f Update layout to support wrapping subject
    @@ -1,6 +1,12 @@
     Author: Blaine Motsinger <blaine at bestpractical.com>
     
         Update layout to support wrapping subject
    +    
    +    This commit makes changes to the positions, floats, padding, and
    +    margins to allow the header h1 subject line to wrap.  The other
    +    elements in the theme need to respond relative to the size of the
    +    subject, so needed to be adjusted for position, padding, and margin
    +    to compensate for the positioning change.
     
     diff --git a/share/static/css/elevator-light/boxes.css b/share/static/css/elevator-light/boxes.css
     --- a/share/static/css/elevator-light/boxes.css
    @@ -9,7 +15,8 @@
      .titlebox {
     -    margin-top: 1em;
     -    margin-bottom: 2em;
    -+    margin-top: 1.5em;
    ++    margin-top: 1.2em;
    ++    margin-bottom: 1em;
          padding: 5px;
      }
      
    @@ -22,7 +29,7 @@
      div#body {
          padding: 0 2.5em;
     -    margin-top: 4em;
    -+    margin-top: 1.5em;
    ++    margin-top: 3em;
          margin-right: 0;
          margin-bottom: 0em;
          background: #fff;
4: 4300557abe ! 4: dbfca8a2c3 Fix page-menu display issues
    @@ -1,6 +1,11 @@
     Author: Blaine Motsinger <blaine at bestpractical.com>
     
         Fix page-menu display issues
    +    
    +    The inner elements of page-menu had an incorrect border-radius,
    +    alignment, and margin-top being set.  This showed in the superfish
    +    dropdown center aligning the text and rounded hover on square
    +    buttons.
     
     diff --git a/share/static/css/elevator-light/nav.css b/share/static/css/elevator-light/nav.css
     --- a/share/static/css/elevator-light/nav.css
5: 8901c9f387 < -:  ------- Fix margin on topaction and logo
6: 4613a87cea < -:  ------- Fix padding-top on not-logged-in message
7: 116d2df1a7 < -:  ------- Set max-width for subject line only when needed
-:  ------- > 5: d4e443fae4 Fix centering on topactions, logo, and not-logged-in



More information about the rt-commit mailing list