[Rt-commit] rt branch, 4.6/fix-people-long-emails, repushed

Blaine Motsinger blaine at bestpractical.com
Tue Dec 24 14:22:10 EST 2019


The branch 4.6/fix-people-long-emails was deleted and repushed:
       was 05aaedf5c2bd77cbff6f48e4e459b335384dcad4
       now ff155610c179dfe45d78d6bb9029bacd080f7ad6

1: 05aaedf5c2 ! 1: ff155610c1 Allow longer email addresses for value on People
    @@ -2,8 +2,12 @@
     
         Allow longer email addresses for value on People
         
    -    This commit expands the value col size for the 'Add new watchers'
    -    input form-row to allow for longer email addresses before wrapping.
    +    This commit expands the value col size for the "Add new watchers"
    +    input form-rows to allow for longer email addresses before wrapping.
    +    
    +    The auto populated rows are longer (col-md-9) than the text input
    +    rows (col-md-6) to allow for "friendly name" <email at example.com>,
    +    which could likely be longer than col-md-6 would allow.
     
     diff --git a/share/html/Ticket/Elements/AddWatchers b/share/html/Ticket/Elements/AddWatchers
     --- a/share/html/Ticket/Elements/AddWatchers
    @@ -13,7 +17,43 @@
            <&|/l&>Type</&>
          </div>
     -    <div class="col-md-3">
    -+    <div class="col-md-6">
    ++    <div class="col-md-9">
    +       <&|/l&>Username</&>
    +     </div>
    +   </div>
    +@@
    +         Queue => $Ticket->QueueObj,
    +       &>
    +     </div>
    +-    <div class="col-md-3">
    ++    <div class="col-md-9">
    +       <span class="form-control current-value">
    +         <& '/Elements/ShowUser', User => $u, style=>'verbose' &>
    +       </span>
    +@@
    +     <div class="col-md-3">
    +       <&|/l&>Type</&>
    +     </div>
    +-    <div>
    ++    <div class="col-md-9">
    +       <&|/l&>Group</&>
    +     </div>
    +   </div>
    +@@
    +         Queue => $Ticket->QueueObj,
    +       &>
    +     </div>
    +-    <div class="col-md-3">
    ++    <div class="col-md-9">
    +       <span class="form-control current-value">
    +         <%$g->Name%> (<%$g->Description%>)
    +       </span>
    +@@
    +     <div class="col-md-3">
    +       <&|/l&>Type</&>
    +     </div>
    +-    <div class="col-md-3">
    ++    <div class="col-md-9">
            <&|/l&>Email</&>
          </div>
        </div>
    @@ -22,7 +62,7 @@
            <&/Elements/SelectWatcherType, Name => "WatcherTypeEmail".$counter, Queue => $Ticket->QueueObj &>
          </div>
     -    <div class="col-md-3">
    -+    <div class="col-md-6">
    ++    <div class="col-md-9">
            <input type="hidden" name="WatcherAddressEmail<%$counter%>" value="<%$email->format%>">
            <span class="form-control current-value">
              <%$email->format%>



More information about the rt-commit mailing list