[Rt-commit] rt branch, 4.6/core-group-management-extensions, repushed

Blaine Motsinger blaine at bestpractical.com
Fri May 31 13:03:24 EDT 2019


The branch 4.6/core-group-management-extensions was deleted and repushed:
       was 0520c232fddd22de0b9c3b24eca505b4e0323138
       now a69f07885ad4234416cdd6732db509236c199626

1: 5abeb826e = 1: 5abeb826e Core RT-Extension-GroupLinks
2: 79ba37d51 = 2: 79ba37d51 Core RT-Extension-GroupSummary
3: dd273ca7a = 3: dd273ca7a Core RT-Extension-GroupSelfService
4: 0520c232f ! 4: a69f07885 Fix tests for initialdata change
    @@ -1,9 +1,9 @@
     Author: Blaine Motsinger <blaine at bestpractical.com>
     
    -    Fix test for initialdata change
    +    Fix tests for initialdata change
         
    -    Use the custom field id created through the test instead of the
    -    previously hardcoded value.
    +    Use the custom field id created through the tests instead of the
    +    previously hardcoded values.
     
     diff --git a/t/web/cf_image.t b/t/web/cf_image.t
     --- a/t/web/cf_image.t
    @@ -37,3 +37,44 @@
      $m->click_ok("SubmitTicket");
      $m->content_lacks("/Download/CustomFieldValue/1/bpslogo.png");
      
    +
    +diff --git a/t/web/cf_onqueue.t b/t/web/cf_onqueue.t
    +--- a/t/web/cf_onqueue.t
    ++++ b/t/web/cf_onqueue.t
    +@@
    + 
    + ok $m->login, 'logged in';
    + 
    ++my $cfid;
    ++
    + diag "Create a queue CF";
    + {
    +     $m->follow_link( id => 'admin-custom-fields-create');
    +@@
    +         },
    +     );
    +     $m->content_contains('Object created', 'CF QueueCFTest created' );
    ++
    ++    # set the custom field id for the rest of the tests to use
    ++    $cfid = $m->form_name('ModifyCustomField')->value('id');
    + }
    + 
    + diag "Apply the new CF globally";
    +@@
    +     $m->content_contains('QueueCFTest', 'CF QueueCFTest displayed on page' );
    + 
    +     $m->form_name('EditCustomFields');
    +-    $m->tick( AddCustomField => 2 );
    ++    $m->tick( AddCustomField => $cfid );
    +     $m->click('UpdateCFs');
    + 
    +     $m->content_contains("Globally added custom field QueueCFTest", 'CF QueueCFTest enabled globally' );
    +@@
    +         # The following doesn't want to works :(
    +         #with_fields => { 'Object-RT::Queue-1-CustomField-2-Value' },
    +         fields => {
    +-            'Object-RT::Queue-1-CustomField-2-Value' => 'QueueCFTest content',
    ++            "Object-RT::Queue-1-CustomField-$cfid-Value" => 'QueueCFTest content',
    +         },
    +     );
    +     $m->content_contains('QueueCFTest QueueCFTest content added', 'Content filed in CF QueueCFTest for default queue' );



More information about the rt-commit mailing list