[Rt-commit] rt branch, 4.6/fontawesome-icons, repushed

Blaine Motsinger blaine at bestpractical.com
Mon Nov 4 18:43:14 EST 2019


The branch 4.6/fontawesome-icons was deleted and repushed:
       was 71c02a6b18c30fc7b88fae023af47982bb7462b9
       now df5400f1b370060082c6e7c967dbdf38083cee19

1: 4f90e82c96 = 1: 4f90e82c96 Add project-diagram to fontawesome SVG build
2: a94b7b92a5 ! 2: e571ceb5b2 Replace text links with fontawesome SVGs
    @@ -10,7 +10,7 @@
      
          if ( $request_path =~ /^\/(?:index.html|$)/ ) {
     -        $page->child( edit => title => loc('Edit'), path => '/Prefs/MyRT.html' );
    -+        $page->child( edit => raw_html => q[<a id="page-edit" class="menu-item" href="] . RT->Config->Get('WebPath') . q[/Prefs/MyRT.html"><img class="fas fa-cog" alt="] . loc('Edit') . q[" /></a>] );
    ++        $page->child( edit => raw_html => q[<a id="page-edit" class="menu-item" href="] . RT->Config->Get('WebPath') . q[/Prefs/MyRT.html"><span class="fas fa-cog" alt="] . loc('Edit') . q["></span></a>] );
          }
      
          # due to historical reasons of always having been in /Elements/Tabs
    @@ -23,7 +23,7 @@
          title => loc('Dashboards'),
          title_href => RT->Config->Get('WebPath').'/Dashboards/index.html',
     -    titleright => loc("Edit"),
    -+    titleright_raw => q[<img class="fas fa-cog" alt="] . loc('Edit') . q[" />],
    ++    titleright_raw => q[<span class="fas fa-cog" alt="] . loc('Edit') . q["></span>],
          titleright_href => RT->Config->Get('WebPath').'/Dashboards/index.html',
      &>
      
    @@ -36,7 +36,7 @@
          class => "fullwidth",
          bodyclass => "",
     -    titleright => loc("Edit"),
    -+    titleright_raw => q[<img class="fas fa-cog" alt="] . loc('Edit') . q[" />],
    ++    titleright_raw => q[<span class="fas fa-cog" alt="] . loc('Edit') . q["></span>],
          titleright_href => RT->Config->Get('WebPath').'/Prefs/QueueList.html',
      &>
      <& $comp,
    @@ -44,15 +44,6 @@
     diff --git a/share/html/Elements/ShowHistoryHeader b/share/html/Elements/ShowHistoryHeader
     --- a/share/html/Elements/ShowHistoryHeader
     +++ b/share/html/Elements/ShowHistoryHeader
    -@@
    - $ShowHeaders       => 0
    - $ShowTitle         => 1
    - $ShowDisplayModes  => 1
    --$ScrollShowHistory => 0
    -+$ScrollShowHistory => 1
    - </%ARGS>
    - <%INIT>
    - my $record_type = $Object->RecordType;
     @@
          my $title = $ShowTitle
                          ? loc('History')
    @@ -109,7 +100,7 @@
          }
      
     +    # build the new link
    -+    my $titleright = q{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><img class="fas fa-cog" /></a><ul class="dropdown-menu dropdown-menu-right">};
    ++    my $titleright = q{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><span class="fas fa-cog"></span></a><ul class="dropdown-menu dropdown-menu-right">};
     +
     +    # foreach of the elements, build a new <li>$element</li> and append to the output.
     +    foreach my $element ( @elements ) {
    @@ -130,7 +121,7 @@
          title_raw => $title_raw,
          title_href => $query_link_url.$QueryString,
     -    titleright => $customize ? loc('Edit') : '',
    -+    titleright_raw => q[<img class="fas fa-cog" alt="] . loc('Edit') . q[" />],
    ++    titleright_raw => q[<span class="fas fa-cog" alt="] . loc('Edit') . q["></span>],
          titleright_href => $customize,
          hideable => $hideable,
          class => 'fullwidth' &>
    @@ -146,7 +137,7 @@
     +my $titleright = qq{
     +<div class="btn-group dropdown">
     +  <a id="metadata-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
    -+    <img class="fas fa-cog" alt="} . loc('Edit') . qq{"/>
    ++    <span class="fas fa-cog" alt="} . loc('Edit') . qq{"></span>
     +  </a>
     +  <ul class="dropdown-menu dropdown-menu-right">
     +    <li class="dropdown-item">
    @@ -166,10 +157,10 @@
      <a href="<% $url %>" onclick="jQuery.get(<% $url |n,j %>, function(data){ jQuery('.toggle-bookmark-'+<% $id |n,j%>).replaceWith(data) }); return false;" >
      % if ( $is_bookmarked ) {
     -<img src="<% RT->Config->Get('WebPath') %>/static/images/star-full.png" alt="<% loc('Remove Bookmark') %>" />
    -+<img class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% loc('Remove Bookmark') %>" \>
    ++<span class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% loc('Remove Bookmark') %>"></span>
      % } else {
     -<img src="<% RT->Config->Get('WebPath') %>/static/images/star-empty.png" alt="<% loc('Add Bookmark') %>" />
    -+<img class="far fa-bookmark" style="color:black" alt="<% loc('Add Bookmark') %>" \>
    ++<span class="far fa-bookmark" style="color:black" alt="<% loc('Add Bookmark') %>"></span>
      % }
      </a>
      </span>
    @@ -182,7 +173,7 @@
      <span class="timer-link">
          <a href="<% $url %>" onclick="window.open(<% $url |n,j %>, '_blank', 'height=200,width=200'); return false;" >
     -        <img src="<% RT->Config->Get('WebPath') %>/static/images/stopwatch.png" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>" />
    -+        <img class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>" />
    ++        <span class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>"></span>
          </a>
      </span>
     
    @@ -194,7 +185,7 @@
      % $m->callback( %ARGS, CallbackName => 'AfterDates' );
      % my (@extra);
     -% push @extra, titleright_raw => '<a href="'. RT->Config->Get('WebPath'). '/Ticket/Graphs/index.html?id='.$Ticket->id.'">'.loc('Graph').'</a>' unless RT->Config->Get('DisableGraphViz');
    -+% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"/></a>' unless RT->Config->Get('DisableGraphViz');
    ++% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
      <& /Ticket/Elements/ShowAssets, Ticket => $Ticket &>
      % $m->callback( %ARGS, CallbackName => 'LinksExtra', extra => \@extra );
          <&| /Widgets/TitleBox, title => loc('Links'),
    @@ -207,7 +198,7 @@
      % $m->callback( CallbackName => 'FormStart', ARGSRef => \%ARGS );
      % my (@extra);
     -% push @extra, titleright_raw => '<a href="'. RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id='.$Ticket->id.'">'.loc('Graph').'</a>' unless RT->Config->Get('DisableGraphViz');
    -+% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"/></a>' unless RT->Config->Get('DisableGraphViz');
    ++% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
      <&| /Widgets/TitleBox, title => loc('Edit Links'), class=>'ticket-info-links', @extra &>
      <& /Elements/EditLinks, Object => $Ticket &>
      </&>
3: a57b22952f ! 3: 257d577303 Remove timer and bookmark css and images
    @@ -1,19 +1,6 @@
     Author: Blaine Motsinger <blaine at bestpractical.com>
     
         Remove timer and bookmark css and images
    -
    -diff --git a/share/html/Ticket/Elements/Bookmark b/share/html/Ticket/Elements/Bookmark
    ---- a/share/html/Ticket/Elements/Bookmark
    -+++ b/share/html/Ticket/Elements/Bookmark
    -@@
    - $id
    - $Toggle => 0
    - </%ARGS>
    --<span class="toggle-bookmark toggle-bookmark-<% $id %>">
    -+<span class="toggle-bookmark-<% $id %>">
    - % my $url = RT->Config->Get('WebPath') ."/Helpers/Toggle/TicketBookmark?id=". $id;
    - <a href="<% $url %>" onclick="jQuery.get(<% $url |n,j %>, function(data){ jQuery('.toggle-bookmark-'+<% $id |n,j%>).replaceWith(data) }); return false;" >
    - % if ( $is_bookmarked ) {
     
     diff --git a/share/html/Ticket/Elements/PopupTimerLink b/share/html/Ticket/Elements/PopupTimerLink
     --- a/share/html/Ticket/Elements/PopupTimerLink
    @@ -24,11 +11,11 @@
      </%INIT>
     -<span class="timer-link">
     -    <a href="<% $url %>" onclick="window.open(<% $url |n,j %>, '_blank', 'height=200,width=200'); return false;" >
    --        <img class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>" />
    +-        <span class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>"></span>
     -    </a>
     -</span>
     +<a href="<% $url %>" onclick="window.open(<% $url |n,j %>, '_blank', 'height=200,width=200'); return false;" >
    -+  <img class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>" />
    ++  <span class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>"></span>
     +</a>
     
     diff --git a/share/static/css/elevator-light/misc.css b/share/static/css/elevator-light/misc.css
4: 209457ae21 ! 4: c60962d032 Add alt and title tooltips for new icons
    @@ -9,9 +9,9 @@
          }
      
          if ( $request_path =~ /^\/(?:index.html|$)/ ) {
    --        $page->child( edit => raw_html => q[<a id="page-edit" class="menu-item" href="] . RT->Config->Get('WebPath') . q[/Prefs/MyRT.html"><img class="fas fa-cog" alt="] . loc('Edit') . q[" /></a>] );
    +-        $page->child( edit => raw_html => q[<a id="page-edit" class="menu-item" href="] . RT->Config->Get('WebPath') . q[/Prefs/MyRT.html"><span class="fas fa-cog" alt="] . loc('Edit') . q["></span></a>] );
     +        my $alt = loc('Edit');
    -+        $page->child( edit => raw_html => q[<a id="page-edit" class="menu-item" href="] . RT->Config->Get('WebPath') . qq[/Prefs/MyRT.html"><img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" /></a>] );
    ++        $page->child( edit => raw_html => q[<a id="page-edit" class="menu-item" href="] . RT->Config->Get('WebPath') . qq[/Prefs/MyRT.html"><span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span></a>] );
          }
      
          # due to historical reasons of always having been in /Elements/Tabs
    @@ -28,8 +28,8 @@
      <&|/Widgets/TitleBox,
          title => loc('Dashboards'),
          title_href => RT->Config->Get('WebPath').'/Dashboards/index.html',
    --    titleright_raw => q[<img class="fas fa-cog" alt="] . loc('Edit') . q[" />],
    -+    titleright_raw => qq[<img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    +-    titleright_raw => q[<span class="fas fa-cog" alt="] . loc('Edit') . q["></span>],
    ++    titleright_raw => qq[<span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
          titleright_href => RT->Config->Get('WebPath').'/Dashboards/index.html',
      &>
      
    @@ -48,8 +48,8 @@
          title => loc("Queue list"),
          class => "fullwidth",
          bodyclass => "",
    --    titleright_raw => q[<img class="fas fa-cog" alt="] . loc('Edit') . q[" />],
    -+    titleright_raw => qq[<img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    +-    titleright_raw => q[<span class="fas fa-cog" alt="] . loc('Edit') . q["></span>],
    ++    titleright_raw => qq[<span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
          titleright_href => RT->Config->Get('WebPath').'/Prefs/QueueList.html',
      &>
      <& $comp,
    @@ -58,21 +58,12 @@
     --- a/share/html/Elements/ShowHistoryHeader
     +++ b/share/html/Elements/ShowHistoryHeader
     @@
    - $ShowHeaders       => 0
    - $ShowTitle         => 1
    - $ShowDisplayModes  => 1
    --$ScrollShowHistory => 1
    -+$ScrollShowHistory => 0
    - </%ARGS>
    - <%INIT>
    - my $record_type = $Object->RecordType;
    -@@
          }
      
          # build the new link
    --    my $titleright = q{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><img class="fas fa-cog" /></a><ul class="dropdown-menu dropdown-menu-right">};
    +-    my $titleright = q{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><span class="fas fa-cog"></span></a><ul class="dropdown-menu dropdown-menu-right">};
     +    my $alt = loc('Edit');
    -+    my $titleright = qq{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" /></a><ul class="dropdown-menu dropdown-menu-right">};
    ++    my $titleright = qq{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span></a><ul class="dropdown-menu dropdown-menu-right">};
      
          # foreach of the elements, build a new <li>$element</li> and append to the output.
          foreach my $element ( @elements ) {
    @@ -90,8 +81,8 @@
          title => loc(RT::SavedSearch->EscapeDescription($search->Description), $ProcessedSearchArg->{'Rows'}),
          title_raw => $title_raw,
          title_href => $query_link_url.$QueryString,
    --    titleright_raw => q[<img class="fas fa-cog" alt="] . loc('Edit') . q[" />],
    -+    titleright_raw => qq[<img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    +-    titleright_raw => q[<span class="fas fa-cog" alt="] . loc('Edit') . q["></span>],
    ++    titleright_raw => qq[<span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
          titleright_href => $customize,
          hideable => $hideable,
          class => 'fullwidth' &>
    @@ -107,8 +98,8 @@
      my $titleright = qq{
      <div class="btn-group dropdown">
        <a id="metadata-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
    --    <img class="fas fa-cog" alt="} . loc('Edit') . qq{"/>
    -+    <img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"/>
    +-    <span class="fas fa-cog" alt="} . loc('Edit') . qq{"></span>
    ++    <span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>
        </a>
        <ul class="dropdown-menu dropdown-menu-right">
          <li class="dropdown-item">
    @@ -120,13 +111,13 @@
      % my $url = RT->Config->Get('WebPath') ."/Helpers/Toggle/TicketBookmark?id=". $id;
      <a href="<% $url %>" onclick="jQuery.get(<% $url |n,j %>, function(data){ jQuery('.toggle-bookmark-'+<% $id |n,j%>).replaceWith(data) }); return false;" >
      % if ( $is_bookmarked ) {
    --<img class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% loc('Remove Bookmark') %>" \>
    +-<span class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% loc('Remove Bookmark') %>"></span>
     +% my $alt = loc('Remove Bookmark');
    -+<img class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>" \>
    ++<span class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>"></span>
      % } else {
    --<img class="far fa-bookmark" style="color:black" alt="<% loc('Add Bookmark') %>" \>
    +-<span class="far fa-bookmark" style="color:black" alt="<% loc('Add Bookmark') %>"></span>
     +% my $alt = loc('Add Bookmark');
    -+<img class="far fa-bookmark" style="color:black" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>" \>
    ++<span class="far fa-bookmark" style="color:black" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>"></span>
      % }
      </a>
      </span>
    @@ -141,8 +132,8 @@
     +my $alt = loc('Open Timer');
      </%INIT>
      <a href="<% $url %>" onclick="window.open(<% $url |n,j %>, '_blank', 'height=200,width=200'); return false;" >
    --  <img class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>" />
    -+  <img class="far fa-clock" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>" />
    +-  <span class="far fa-clock" alt="<% loc('Open Timer') %>" title="<% loc('Open Timer') %>"></span>
    ++  <span class="far fa-clock" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>"></span>
      </a>
     
     diff --git a/share/html/Ticket/Elements/ShowSummary b/share/html/Ticket/Elements/ShowSummary
    @@ -154,8 +145,8 @@
      % $m->callback( %ARGS, CallbackName => 'AfterDates' );
     +% my $alt = loc('Graph ticket links');
      % my (@extra);
    --% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"/></a>' unless RT->Config->Get('DisableGraphViz');
    -+% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' . $alt . '" /></a>' unless RT->Config->Get('DisableGraphViz');
    +-% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
    ++% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' . $alt . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
      <& /Ticket/Elements/ShowAssets, Ticket => $Ticket &>
      % $m->callback( %ARGS, CallbackName => 'LinksExtra', extra => \@extra );
          <&| /Widgets/TitleBox, title => loc('Links'),
    @@ -169,8 +160,8 @@
      % $m->callback( CallbackName => 'FormStart', ARGSRef => \%ARGS );
     +% my $alt = loc('Graph ticket links');
      % my (@extra);
    --% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"/></a>' unless RT->Config->Get('DisableGraphViz');
    -+% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' .  $alt . '" /></a>' unless RT->Config->Get('DisableGraphViz');
    +-% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . loc('Graph ticket links') . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
    ++% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' .  $alt . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
      <&| /Widgets/TitleBox, title => loc('Edit Links'), class=>'ticket-info-links', @extra &>
      <& /Elements/EditLinks, Object => $Ticket &>
      </&>
5: 7b54aa3f5a ! 5: 4033683ef3 Enable bootstrap tooltips
    @@ -19,13 +19,13 @@
     +++ b/share/html/Ticket/Elements/Bookmark
     @@
      </%ARGS>
    - <span class="toggle-bookmark-<% $id %>">
    + <span class="toggle-bookmark toggle-bookmark-<% $id %>">
      % my $url = RT->Config->Get('WebPath') ."/Helpers/Toggle/TicketBookmark?id=". $id;
     -<a href="<% $url %>" onclick="jQuery.get(<% $url |n,j %>, function(data){ jQuery('.toggle-bookmark-'+<% $id |n,j%>).replaceWith(data) }); return false;" >
     +<a href="<% $url %>" onclick="toggle_bookmark(<% $url |n,j %>, <% $id |n,j%>); return false;" >
      % if ( $is_bookmarked ) {
      % my $alt = loc('Remove Bookmark');
    - <img class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>" \>
    + <span class="fas fa-bookmark bookmark-selected" data-fa-transform="shrink-2 up-0.25" alt="<% $alt %>" data-toggle="tooltip" data-placement="top" data-original-title="<% $alt %>"></span>
     
     diff --git a/share/static/js/util.js b/share/static/js/util.js
     --- a/share/static/js/util.js
6: 910f3399d2 ! 6: f63758b940 Add border styling for icons
    @@ -9,8 +9,8 @@
      <&|/Widgets/TitleBox,
          title => loc('Dashboards'),
          title_href => RT->Config->Get('WebPath').'/Dashboards/index.html',
    --    titleright_raw => qq[<img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    -+    titleright_raw => qq[<img class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    +-    titleright_raw => qq[<span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
    ++    titleright_raw => qq[<span class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
          titleright_href => RT->Config->Get('WebPath').'/Dashboards/index.html',
      &>
      
    @@ -22,8 +22,8 @@
          title => loc("Queue list"),
          class => "fullwidth",
          bodyclass => "",
    --    titleright_raw => qq[<img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    -+    titleright_raw => qq[<img class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    +-    titleright_raw => qq[<span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
    ++    titleright_raw => qq[<span class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
          titleright_href => RT->Config->Get('WebPath').'/Prefs/QueueList.html',
      &>
      <& $comp,
    @@ -35,8 +35,8 @@
      
          # build the new link
          my $alt = loc('Edit');
    --    my $titleright = qq{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" /></a><ul class="dropdown-menu dropdown-menu-right">};
    -+    my $titleright = qq{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><img class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" /></a><ul class="dropdown-menu dropdown-menu-right">};
    +-    my $titleright = qq{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span></a><ul class="dropdown-menu dropdown-menu-right">};
    ++    my $titleright = qq{<div class="btn-group dropdown"><a id="history-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><span class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span></a><ul class="dropdown-menu dropdown-menu-right">};
      
          # foreach of the elements, build a new <li>$element</li> and append to the output.
          foreach my $element ( @elements ) {
    @@ -48,8 +48,8 @@
          title => loc(RT::SavedSearch->EscapeDescription($search->Description), $ProcessedSearchArg->{'Rows'}),
          title_raw => $title_raw,
          title_href => $query_link_url.$QueryString,
    --    titleright_raw => qq[<img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    -+    titleright_raw => qq[<img class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt" />],
    +-    titleright_raw => qq[<span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
    ++    titleright_raw => qq[<span class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>],
          titleright_href => $customize,
          hideable => $hideable,
          class => 'fullwidth' &>
    @@ -61,8 +61,8 @@
      my $titleright = qq{
      <div class="btn-group dropdown">
        <a id="metadata-dropdown" href="#" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
    --    <img class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"/>
    -+    <img class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"/>
    +-    <span class="fas fa-cog" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>
    ++    <span class="fas fa-cog icon-bordered fa-2x" alt="$alt" data-toggle="tooltip" data-placement="top" data-original-title="$alt"></span>
        </a>
        <ul class="dropdown-menu dropdown-menu-right">
          <li class="dropdown-item">
    @@ -74,8 +74,8 @@
      % $m->callback( %ARGS, CallbackName => 'AfterDates' );
      % my $alt = loc('Graph ticket links');
      % my (@extra);
    --% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' . $alt . '" /></a>' unless RT->Config->Get('DisableGraphViz');
    -+% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram icon-bordered fa-2x" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' . $alt . '" /></a>' unless RT->Config->Get('DisableGraphViz');
    +-% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' . $alt . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
    ++% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram icon-bordered fa-2x" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' . $alt . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
      <& /Ticket/Elements/ShowAssets, Ticket => $Ticket &>
      % $m->callback( %ARGS, CallbackName => 'LinksExtra', extra => \@extra );
          <&| /Widgets/TitleBox, title => loc('Links'),
    @@ -87,8 +87,8 @@
      % $m->callback( CallbackName => 'FormStart', ARGSRef => \%ARGS );
      % my $alt = loc('Graph ticket links');
      % my (@extra);
    --% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' .  $alt . '" /></a>' unless RT->Config->Get('DisableGraphViz');
    -+% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><img class="fas fa-project-diagram icon-bordered fa-2x" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' .  $alt . '" /></a>' unless RT->Config->Get('DisableGraphViz');
    +-% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' .  $alt . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
    ++% push @extra, titleright_raw => '<a href="' . RT->Config->Get('WebPath') . '/Ticket/Graphs/index.html?id=' . $Ticket->id . '"><span class="fas fa-project-diagram icon-bordered fa-2x" alt="' . $alt . '" data-toggle="tooltip" data-placement="top" data-original-title="' .  $alt . '"></span></a>' unless RT->Config->Get('DisableGraphViz');
      <&| /Widgets/TitleBox, title => loc('Edit Links'), class=>'ticket-info-links', @extra &>
      <& /Elements/EditLinks, Object => $Ticket &>
      </&>
7: f2ee99dba6 = 7: 911f9570fb Update test for removing bookmark imgs
8: 71c02a6b18 = 8: df5400f1b3 Fix test to find link via regex instead of text



More information about the rt-commit mailing list