[Rt-commit] rt branch, 4.6/tweak-footer-style, created. rt-4.4.4-491-ge74fb1d9ab

? sunnavy sunnavy at bestpractical.com
Wed Nov 6 15:58:58 EST 2019


The branch, 4.6/tweak-footer-style has been created
        at  e74fb1d9ab43cee7508d24027d78465c8bc3953d (commit)

- Log -----------------------------------------------------------------
commit 0180179f4a6a9fd882a092af6a62cd5b68ab0b64
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Oct 29 13:43:43 2019 +0800

    Put footer to the end of viewport when the page is short
    
    When the page is long, the footer is still after all the content instead
    of always showing at the end of viewport.

diff --git a/share/html/Elements/Footer b/share/html/Elements/Footer
index 41d60ad476..e1cabccbaa 100644
--- a/share/html/Elements/Footer
+++ b/share/html/Elements/Footer
@@ -66,6 +66,7 @@
 <%$d->Dump() %>
 </pre>
 % }
+    </div>
   </body>
 </html>
 <%ARGS>
diff --git a/share/html/Elements/Header b/share/html/Elements/Header
index b9538e66f8..ed630642db 100644
--- a/share/html/Elements/Header
+++ b/share/html/Elements/Header
@@ -98,6 +98,7 @@
 
 </head>
   <body class="<% join( ' ',@{$ARGS{'BodyClass'}}, RT->Config->Get('WebDefaultStylesheet', $session{CurrentUser}) =~ /-dark$/ ? 'darkmode' : ()) %>" <% $id && qq[id="comp-$id"] |n %>>
+    <div class="main-container">
 
 % if ($ShowBar) {
 <& /Elements/Logo, %ARGS &>
diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index ca630eb912..6a028233da 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -32,14 +32,13 @@ div#body {
 
 div#footer {
     position: absolute;
-    right: 0;
     text-align: right;
     font-size: 0.9em;
-    margin-top: 2em;
     background: #fff;
-    margin-bottom: 0;
     padding-left: 3em;
     padding-right: 1em;
+    bottom: 0;
+    width: 100%;
 }
 
 div#footer #time {
@@ -161,3 +160,11 @@ ul ul {
 ol ol {
   list-style-type: upper-alpha;
 }
+
+.main-container {
+  min-height: 100vh;
+  overflow: hidden;
+  display: block;
+  position: relative;
+  padding-bottom: 5em;
+}

commit 37d249bcef0a64a849fa5cd07116de4406d946e5
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Oct 30 03:21:38 2019 +0800

    Move bpscredits in footer to center

diff --git a/share/html/Elements/Footer b/share/html/Elements/Footer
index e1cabccbaa..43c3b81916 100644
--- a/share/html/Elements/Footer
+++ b/share/html/Elements/Footer
@@ -49,14 +49,18 @@
   <hr class="clear" />
 </div>
 % $m->callback( %ARGS );
-<div id="footer" title="Best Practical Solutions, LLC, copyright and logo">
+<div id="footer" title="Best Practical Solutions, LLC, copyright and logo" class="row">
 % if ($m->{'rt_base_time'}) {
   <p id="time"><span><&|/l&>Time to display</&>: <%Time::HiRes::tv_interval( $m->{'rt_base_time'} )%></span></p>
 %}
+    <div class="col-md-4 offset-md-4 col-sm-12">
   <p id="bpscredits"><span><&|/l_unsafe,     '»|«', $RT::VERSION, '2019', '<a href="http://www.bestpractical.com?rt='.$RT::VERSION.'">Best Practical Solutions, LLC</a>', &>[_1] RT [_2] Copyright 1996-[_3] [_4].</&>
 </span></p>
+    </div>
 % if (!$Menu) {
+    <div class="col-md-4 col-sm-12">
   <p id="legal"><&|/l_unsafe, '<a href="http://www.gnu.org/licenses/gpl-2.0.html">', '</a>' &>Distributed under [_1]version 2 of the GNU GPL[_2].</&><br /><&|/l_unsafe, '<a href="mailto:sales at bestpractical.com">sales at bestpractical.com</a>' &>To inquire about support, training, custom development or licensing, please contact [_1].</&><br /></p>
+    </div>
 % }
 </div>
 % if ($Debug >= 2 ) {
diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index 6a028233da..b8b6fbee0c 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -35,10 +35,17 @@ div#footer {
     text-align: right;
     font-size: 0.9em;
     background: #fff;
-    padding-left: 3em;
-    padding-right: 1em;
+    padding-left: 15px;
+    padding-right: 15px;
     bottom: 0;
     width: 100%;
+    margin-left: 0;
+    margin-right: 0;
+}
+
+div#footer > div {
+    padding-left: 0;
+    padding-right: 0;
 }
 
 div#footer #time {
@@ -46,11 +53,15 @@ div#footer #time {
 }
 
 div#footer #bpscredits {
-    text-align: right;
-    background: url(../../../static/images/bpslogo.png) no-repeat top right;
+    text-align: center;
+    background: url(../../../static/images/bpslogo.png) no-repeat top center;
     padding-top: 4em;
 }
 
+div#footer #legal {
+    padding-top: 1.5em;
+}
+
 /* logo stuff */
 
 div#logo {

commit 18ac28b647b6a031af15c05c2fca6f2720c8cf15
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Oct 30 03:22:53 2019 +0800

    Smaller font size in footer

diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index b8b6fbee0c..80971fe2a6 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -33,7 +33,7 @@ div#body {
 div#footer {
     position: absolute;
     text-align: right;
-    font-size: 0.9em;
+    font-size: 0.8em;
     background: #fff;
     padding-left: 15px;
     padding-right: 15px;

commit 3cc8b901661a64c1c6b1d0a02fa34b6b1d4c41c8
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Oct 30 03:27:42 2019 +0800

    Set footer's background color to dark

diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index 80971fe2a6..a5e48ce247 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -41,6 +41,7 @@ div#footer {
     width: 100%;
     margin-left: 0;
     margin-right: 0;
+    background: #2C3539;
 }
 
 div#footer > div {
@@ -62,6 +63,10 @@ div#footer #legal {
     padding-top: 1.5em;
 }
 
+div#footer a {
+    color: white;
+}
+
 /* logo stuff */
 
 div#logo {

commit e74fb1d9ab43cee7508d24027d78465c8bc3953d
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Oct 30 03:29:35 2019 +0800

    Show bpslogo in footer with dark theme

diff --git a/share/static/css/elevator-light/layout.css b/share/static/css/elevator-light/layout.css
index a5e48ce247..e73de21af9 100644
--- a/share/static/css/elevator-light/layout.css
+++ b/share/static/css/elevator-light/layout.css
@@ -55,7 +55,7 @@ div#footer #time {
 
 div#footer #bpscredits {
     text-align: center;
-    background: url(../../../static/images/bpslogo.png) no-repeat top center;
+    background: url(../../../static/images/bpslogo.png) no-repeat top center !important;
     padding-top: 4em;
 }
 

-----------------------------------------------------------------------


More information about the rt-commit mailing list