[Rt-commit] rt branch, 4.6/configindatabase-themed, repushed
? sunnavy
sunnavy at bestpractical.com
Wed Nov 27 13:55:52 EST 2019
The branch 4.6/configindatabase-themed was deleted and repushed:
was 6fe368f89e9e8f0bfb35c36312f4029d408a5ee0
now fab269a7fc423df51d018d95177559ef389b626a
1: b28dc30467 = 1: b28dc30467 Allow specifying size for Integer and String widgets
2: 94744da2c6 = 2: 94744da2c6 Allow String widget to have a value of "0"
3: 59334314c9 = 3: 59334314c9 Add RadioStyle option to Boolean widget
4: 534bba3102 = 4: 534bba3102 Make booleans with RadioStyle use true/false logic
5: baf23200cd = 5: baf23200cd DatabaseSetting schema updates
6: a888aa6cb0 = 6: a888aa6cb0 Add ORM classes for DatabaseSettings
7: 05db0b9b37 = 7: 05db0b9b37 Port database config loading and refreshing from extension
8: 7648dd10f1 = 8: 7648dd10f1 Add Code and MultilineString widgets
9: 21f6abfb8c = 9: 21f6abfb8c Port EditConfig page from extension
10: 165422a396 = 10: 165422a396 Annotate Immutable options
11: f2f0b772d7 = 11: f2f0b772d7 Add widget metadata for config options
12: 5803325e5f = 12: 5803325e5f Hide deprecated options
13: b878fb9786 = 13: b878fb9786 List Database as source of configuration on Sys Config page
14: 02b6a1a9fb = 14: 02b6a1a9fb Render config with EditLink as readonly
15: 94cbaf03d2 = 15: 94cbaf03d2 Switch from Storable::dclone to Clone::clone to handle code/regex
16: c0d5683bfb = 16: c0d5683bfb Migrate MultilineString to new themes
17: 9fcde4980a ! 17: 941e99b3ba Add LabelLink support for form widgets
@@ -11,7 +11,7 @@
<div class="col-md-3 label">
- <% $Description // '' %>
+% if( $LabelLink ) {
-+ <a href="<% $LabelLink %>"><% $Description %></a>
++ <a href="<% $LabelLink %>" target="_blank"><% $Description %></a>
+% } else {
+ <% $Description %>
+% }
@@ -36,7 +36,7 @@
<div class="col-md-3 label">
- <% $Description // '' %>
+% if( $LabelLink ) {
-+ <a href="<% $LabelLink %>"><% $Description %></a>
++ <a href="<% $LabelLink %>" target="_blank"><% $Description %></a>
+% } else {
+ <% $Description %>
+% }
@@ -60,7 +60,7 @@
<div id="form-box-<% lc $Name %>" class="widget form-row <% $Class %>">
<div class="col-md-3 label">
+% if( $LabelLink ) {
-+ <a href="<% $LabelLink %>"><% $Description %></a>
++ <a href="<% $LabelLink %>" target="_blank"><% $Description %></a>
+% } else {
<% $Description %>
+% }
@@ -85,7 +85,7 @@
<div class="col-md-3 label">
- <% $Description // '' %>
+% if( $LabelLink ) {
-+ <a href="<% $LabelLink %>"><% $Description %></a>
++ <a href="<% $LabelLink %>" target="_blank"><% $Description %></a>
+% } else {
+ <% $Description %>
+% }
@@ -109,7 +109,7 @@
<div id="form-box-<% lc $Name %>" class="widget form-row">
<div class="col-md-3 label">
+% if( $LabelLink ) {
-+ <a href="<% $LabelLink %>"><% $Description %></a>
++ <a href="<% $LabelLink %>" target="_blank"><% $Description %></a>
+% } else {
<% $Description // '' %>
+% }
18: 1eee9b8f55 ! 18: dbb1df6f1e Vertically align boolean label/value
@@ -13,7 +13,7 @@
+<div id="form-box-<% lc $Name %>" class="widget form-row boolean">
<div class="col-md-3 label">
% if( $LabelLink ) {
- <a href="<% $LabelLink %>"><% $Description %></a>
+ <a href="<% $LabelLink %>" target="_blank"><% $Description %></a>
diff --git a/share/static/css/elevator-light/forms.css b/share/static/css/elevator-light/forms.css
--- a/share/static/css/elevator-light/forms.css
19: fb5f04660a ! 19: 6c337ce659 Add tabs to the Configuration in DB feature
@@ -235,6 +235,7 @@
+my $name = $option->{Name};
+my $meta = RT->Config->Meta( $name );
+return if $meta->{Invisible} || $meta->{Deprecated};
++return if $name =~ /Password/i && $name !~ /MinimumPasswordLength|AllowLoginPasswordAutoComplete/;
+
+my $has_execute_code = $session{CurrentUser}->HasRight(Right => 'ExecuteCode', Object => RT->System);
+
@@ -243,7 +244,7 @@
+my $doc_url = "https://docs.bestpractical.com/rt/$doc_version/RT_Config.html#$option->{Help}";
+my $widget = $meta->{'Widget'} || '/Widgets/Form/Code';
+my $is_code = $widget eq '/Widgets/Form/Code';
-+my $is_password = ($name =~ /Password/i and $name !~ /MinimumPasswordLength|AllowLoginPasswordAutoComplete/ );
++
+my $is_immutable = $meta->{Immutable}
+ || $meta->{Obfuscate}
+ || ($is_code && $val =~ s/sub \{ "DUMMY" \}/sub { ... }/g)
@@ -293,8 +294,6 @@
+</ul>
+<br /><em><% loc('Must modify in config file' ) %></em>
+<% $row_end |n%>
-+% } elsif ( $is_password ) {
-+<em><% loc('Must modify in config file' ) %></em><br />
+% } elsif ( $is_immutable ) {
+% if ($widget eq '/Widgets/Form/MultilineString' || $widget eq '/Widgets/Form/Code') {
+<% $row_start |n %><textarea disabled class="<% $is_code ? 'code' : '' %> form-control" rows="6" cols="80"><% $current_value %></textarea>
21: 5523105073 = 20: de365025c8 Rename DatabaseSetting to Configuration
22: 001d08162d = 21: 1406bdc301 Validate Content of Configurations
23: 018f6a442e = 22: 1a6ad6f99f Use Data::Dumper instead in Configuration to support regex
24: 5048fa4270 = 23: 28b3068606 Note RT::Extension::ConfigInDatabase is cored and the main backend change
26: 4713731b8d = 24: 7bcae0bec8 Add container div for configuration pages
27: 347b9e0c00 = 25: fd41af8f62 Move Edit link to the page menu on the configuration page
28: e31fdb0f7a ! 26: 62bf81b5c0 Add some basic help to configuration pages
@@ -7,6 +7,53 @@
--- /dev/null
+++ b/share/html/Admin/Elements/ConfigHelp
@@
++%# BEGIN BPS TAGGED BLOCK {{{
++%#
++%# COPYRIGHT:
++%#
++%# This software is Copyright (c) 1996-2019 Best Practical Solutions, LLC
++%# <sales at bestpractical.com>
++%#
++%# (Except where explicitly superseded by other copyright notices)
++%#
++%#
++%# LICENSE:
++%#
++%# This work is made available to you under the terms of Version 2 of
++%# the GNU General Public License. A copy of that license should have
++%# been provided with this software, but in any event can be snarfed
++%# from www.gnu.org.
++%#
++%# This work is distributed in the hope that it will be useful, but
++%# WITHOUT ANY WARRANTY; without even the implied warranty of
++%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
++%# General Public License for more details.
++%#
++%# You should have received a copy of the GNU General Public License
++%# along with this program; if not, write to the Free Software
++%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
++%# 02110-1301 or visit their web page on the internet at
++%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
++%#
++%#
++%# CONTRIBUTION SUBMISSION POLICY:
++%#
++%# (The following paragraph is not intended to limit the rights granted
++%# to you to modify and distribute this software under the terms of
++%# the GNU General Public License and is only of importance to you if
++%# you choose to contribute your changes and enhancements to the
++%# community by submitting them to Best Practical Solutions, LLC.)
++%#
++%# By intentionally submitting any modifications, corrections or
++%# derivatives to this work, or any other work intended for use with
++%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
++%# you are the copyright holder for those contributions and you grant
++%# Best Practical Solutions, LLC a nonexclusive, worldwide, irrevocable,
++%# royalty-free, perpetual, license to use, copy, create derivative
++%# works based on those contributions, and sublicense and distribute
++%# those contributions and any derivatives thereof.
++%#
++%# END BPS TAGGED BLOCK }}}
+<div class="help" id="rt-help-text">
+<&| /Widgets/TitleBox, title => loc('RT Configuration') &>
+<p>RT has dozens of configuration options to allow you to modify RT to meet your needs. You can view details about each configuration option online in the <a href="https://docs.bestpractical.com/rt/latest/RT_Config.html" target="_blank">RT documentation</a> or in the file <code>etc/RT_Config.pm</code> on your RT server. You can set global configuration options in the file <code>etc/RT_SiteConfig.pm</code> or right in the browser by clicking the Edit link.</p>
29: 6fe368f89e ! 27: 6726e9391a Add configuration documentation in POD
@@ -51,3 +51,4 @@
=head1 Base configuration
=over 4
+
--: ------- > 28: 7bf8a0e2df Add the missing $LDAPOptions to RT_Config.pm
20: 21ff2fa0c2 ! 29: 77dc32c2e0 Add missing config options to %META
@@ -63,4 +63,39 @@
AssetSearchFormat => {
Widget => '/Widgets/Form/MultilineString',
},
+@@
+ Widget => '/Widgets/Form/Select',
+ WidgetArguments => { Values => [qw(ASC DESC)] },
+ },
++
++ LDAPHost => {
++ Widget => '/Widgets/Form/String',
++ },
++ LDAPOptions => {
++ Widget => '/Widgets/Form/MultilineString',
++ },
++ LDAPUser => {
++ Widget => '/Widgets/Form/String',
++ },
++ LDAPPassword => {
++ Widget => '/Widgets/Form/String',
++ },
++ LDAPFilter => {
++ Widget => '/Widgets/Form/String',
++ },
++ LDAPMapping => {
++ Widget => '/Widgets/Form/MultilineString',
++ },
++ LDAPGroupBase => {
++ Widget => '/Widgets/Form/String',
++ },
++ LDAPGroupFilter => {
++ Widget => '/Widgets/Form/String',
++ },
++ LDAPGroupMapping => {
++ Widget => '/Widgets/Form/MultilineString',
++ },
+ );
+ my %OPTIONS = ();
+ my @LOADED_CONFIGS = ();
25: 4117e8957a ! 30: 00d9352016 Add test for /Admin/Tools/EditConfig.html
@@ -21,7 +21,8 @@
+my ( $url, $m ) = RT::Test->started_ok;
+ok( $m->login(), 'logged in' );
+
-+$m->follow_link_ok( { text => 'Edit Configuration' }, 'followed link to "Edit Configuration"' );
++$m->follow_link_ok( { text => 'System Configuration' }, 'followed link to "System Configuration"' );
++$m->follow_link_ok( { text => 'Edit' }, 'followed link to Edit page' );
+
+my $tests = [
+ {
--: ------- > 31: 625deb36fc Refactor SectionMap to get the whole structure from RT_Config.pm
--: ------- > 32: fab269a7fc Re-organize RT_Config.pm to update config stucture on "RT Configuration"
More information about the rt-commit
mailing list