[Rt-commit] rt branch, 4.6/tweak-rights-inspector, repushed

? sunnavy sunnavy at bestpractical.com
Fri Oct 11 15:45:01 EDT 2019


The branch 4.6/tweak-rights-inspector was deleted and repushed:
       was 5571ffed405df194f69895aa3e7b410a08ce1148
       now 22b4994a6219e2a53726566aca8a937ab59cca47

 1: 3b7922dfc =  1: 3b7922dfc Process inspector js only on rights inspector page
 2: 1529df474 =  2: 1529df474 Make Revoke spinner really work
 3: 381c9e13d =  3: 381c9e13d Clean up obsolete .loading spinner css rules
 4: c407339ea =  4: c407339ea Show spinner right before Ajax calls and hide it right after *any* response
 5: 02457e587 =  5: 02457e587 Localize error/no_results/contains/disabled messages in rights inspector
 6: 92261bb85 =  6: 92261bb85 Clean up as returned records do not have highlight/match keys
 7: 2c374921d =  7: 2c374921d Drop default function params as it's unsupported in IE
 8: bad7ceb1e =  8: bad7ceb1e Use consistent margin for headers as record rows
 9: e910740bf =  9: e910740bf Localize input placeholders
10: 819b05942 ! 10: ec83d9599 Vertically align cells in rights inspector
    @@ -4,6 +4,8 @@
         
         Seems the 0.3/0.4em padding-tops tried to center right/revoke columns
         but it didn't look good enough.
    +    
    +    The .unused cell is to not fill striped background to left unused ones
     
     diff --git a/share/static/css/elevator-dark/main.css b/share/static/css/elevator-dark/main.css
     --- a/share/static/css/elevator-dark/main.css
    @@ -15,6 +17,14 @@
     +.darkmode #rights-inspector .results .result:nth-child(even),
      .darkmode #rights-inspector .results .result:nth-child(even) * {
          background-color: #111 !important;
    + }
    + 
    ++.darkmode #rights-inspector .results .result:nth-child(even) .unused {
    ++  background: #171A1F !important;
    ++}
    ++
    + .darkmode #rights-inspector .results .result .match {
    +     background-color: #114 !important;
      }
     
     diff --git a/share/static/css/elevator-light/admin.css b/share/static/css/elevator-light/admin.css
    @@ -29,6 +39,13 @@
          background-color: rgb(236, 246, 252);
      }
      
    ++#rights-inspector .results .result:nth-child(even) .unused {
    ++    background-color: white;
    ++}
    ++
    + #rights-inspector .results .result .match {
    +     background-color: rgb(255, 253, 56);
    +     font-weight: bold;
     @@
          display: none;
      }
    @@ -49,6 +66,14 @@
     --- a/share/static/js/rights-inspector.js
     +++ b/share/static/js/rights-inspector.js
     @@
    +                     alert(response.msg);
    +                 }
    +                 else {
    ++                    button.closest('.revoke').siblings('.unused').remove();
    +                     button.closest('.revoke').removeClass('col-md-1').addClass('col-md-3').text(response.msg);
    +                 }
    +                 delete revoking[action];
    +@@
      
      function render_inspector_result (item) {
          return '<div class="result form-row">'
    @@ -62,5 +87,8 @@
     +        +  '  <div class="revoke cell col-md-1 my-auto">'
              +       revoke_button(item)
              + '  </div>'
    ++        +  '  <div class="unused cell col-md-2" />'
              + '</div>'
    +     ;
    + }
     
11: 8b064236f = 11: 8e96e2895 Use balanced spaces with ()
12: 5571ffed4 = 12: 22b4994a6 Use the same margin for ajax spinner too



More information about the rt-commit mailing list