[Rt-commit] rt branch, 5.0/lifecycle-ui, repushed

? sunnavy sunnavy at bestpractical.com
Thu Apr 30 04:51:13 EDT 2020


The branch 5.0/lifecycle-ui was deleted and repushed:
       was 85f9244c50488da0868779f98791a5af8d7b0116
       now c6930e214c94474fe490b27d9765cbb3945f01e2

 1: 939eb04218 !  1: 17dbf9e487 Core RT::Extension::LifecycleUI
    @@ -16,9 +16,9 @@
     --- a/lib/RT.pm
     +++ b/lib/RT.pm
     @@
    -     'RT::Extension::ConfigInDatabase' => '5.0',
          'RT::Extension::CustomRole::Visibility' => '5.0',
          'RT::Extension::PriorityAsString' => '5.0',
    +     'RT::Extension::AssetSQL' => '5.0',
     +    'RT::Extension::LifecycleUI' => '5.0',
      );
      
 2: d2253a575d =  2: a2cd069d49 Switch to semicolon as query param delimiter in MenuBuilder for lifecycle menus
 3: 65c076ceec !  3: 90ab779575 Migrate lifecycle UI pages to new elevator themes
    @@ -23,10 +23,10 @@
     -</tr>
     +<&| /Widgets/TitleBox, class => 'lifecycle-info-basics', content_class => 'mx-auto width-sm' &>
     +  <div class="form-row">
    -+    <div class="col-md-3 label">
    ++    <div class="col-3 label">
     +      <&|/l&>Lifecycle Name</&>:
     +    </div>
    -+    <div class="col-md-9 value">
    ++    <div class="col-9 value">
     +      <input type="text" name="Name" value="<% $Name %>" class="form-control" />
     +    </div>
     +  </div>
    @@ -34,8 +34,8 @@
     -<tr><td align="right"><&|/l&>Type</&>:</td>
     -<td><select name="Type">
     +  <div class="form-row">
    -+    <div class="col-md-3 label"><&|/l&>Type</&>:</div>
    -+    <div class="col-md-9 value">
    ++    <div class="col-3 label"><&|/l&>Type</&>:</div>
    ++    <div class="col-9 value">
     +      <select name="Type" class="form-control selectpicker">
      % for my $type (@types) {
     -<option value="<% $type %>" <% $type eq $Type ? "selected=selected" : "" %>><% loc($type) %></option>
    @@ -49,10 +49,10 @@
     -<tr><td align="right"><&|/l&>Clone Lifecycle</&>:</td><td>
     -<label><input type="radio" name="Clone" value="" <% ($Clone//'') eq '' ? "checked=checked" : "" %> /> (none)</label>
     +  <div class="form-row">
    -+    <div class="col-md-3 label">
    ++    <div class="col-3 label">
     +      <&|/l&>Clone Lifecycle</&>:
     +    </div>
    -+    <div class="col-md-9 value">
    ++    <div class="col-9 value">
     +      <ul class="list-group list-group-compact">
     +        <li class="list-group-item">
     +          <div class="custom-control custom-radio">
    @@ -84,7 +84,7 @@
      
     -<& /Elements/Submit, Name => 'Create', Label => loc('Create') &>
     +  <div class="form-row">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <& /Elements/Submit, Name => 'Create', Label => loc('Create') &>
     +    </div>
     +  </div>
    @@ -119,7 +119,7 @@
     -<table>
     +<&| /Widgets/TitleBox, title => $Other->Name &>
     +  <div class="form-row">
    -+    <div class="col-md-6">
    ++    <div class="col-6">
     +      <h6 class="text-center my-3"><&|/l, $Other->Name, $LifecycleObj->Name &>From [_1] to [_2]</&></h6>
      % for my $OtherStatus (@OtherStatuses) {
     -  <tr>
    @@ -127,10 +127,10 @@
     -    <td><& /Elements/SelectStatus, Statuses => \@MyStatuses, Default => $FromMapping->{$OtherStatus}, Name => 'map-' . $Other->Name . '-' . $OtherStatus . '--' . $LifecycleObj->Name&></td>
     -  </tr>
     +      <div class="form-row">
    -+        <div class="col-md-4 label">
    ++        <div class="col-4 label">
     +          <% $OtherStatus %>:
     +        </div>
    -+        <div class="col-md-8 value">
    ++        <div class="col-8 value">
     +          <& /Elements/SelectStatus, Statuses => \@MyStatuses, Default => $FromMapping->{$OtherStatus}, Name => 'map-' . $Other->Name . '-' . $OtherStatus . '--' . $LifecycleObj->Name&>
     +        </div>
     +      </div>
    @@ -140,7 +140,7 @@
      
     -<h3><&|/l, $LifecycleObj->Name, $Other->Name &>Changing from [_1] to [_2]:</&></h3>
     -<table>
    -+    <div class="col-md-6">
    ++    <div class="col-6">
     +      <h6 class="text-center my-3"><&|/l, $LifecycleObj->Name, $Other->Name &>From [_1] to [_2]</&></h6>
      % for my $MyStatus (@MyStatuses) {
     -  <tr>
    @@ -148,10 +148,10 @@
     -    <td><& /Elements/SelectStatus, Statuses => \@OtherStatuses, Default => $ToMapping->{$MyStatus}, Name => 'map-' . $LifecycleObj->Name . '-' . $MyStatus . '--' . $Other->Name &></td>
     -  </tr>
     +      <div class="form-row">
    -+        <div class="col-md-4 label">
    ++        <div class="col-4 label">
     +          <% $MyStatus %>:
     +        </div>
    -+        <div class="col-md-8 value">
    ++        <div class="col-8 value">
     +          <& /Elements/SelectStatus, Statuses => \@OtherStatuses, Default => $ToMapping->{$MyStatus}, Name => 'map-' . $LifecycleObj->Name . '-' . $MyStatus . '--' . $Other->Name &>
     +        </div>
     +      </div>
    @@ -166,7 +166,7 @@
      
     -<& /Elements/Submit, Name => 'Update', Label => loc('Save Changes') &>
     +  <div class="form-row">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <& /Elements/Submit, Name => 'Update', Label => loc('Save Changes') &>
     +    </div>
     +  </div>
    @@ -184,7 +184,7 @@
     -<& /Elements/Submit, Label => loc('Save Changes') &>
     -
     +  <div class="form-row">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <& /Elements/Submit, Label => loc('Save Changes') &>
     +    </div>
     +  </div>
 4: 86f358ba4f =  4: 41df0459f9 Add POD doc for new added public methods
 5: 3b563551c6 =  5: 6cc14c8de1 Ensure lifecycle cache is updated across threads when flagged
 6: 951e41ffa2 =  6: fa33147c0f Add select/create links on all lifecycle admin pages like other objects
 7: 090c6908d9 =  7: 3cc659d8e4 Limit lifecycle admin pages only to superusers
 8: 9ec185ff25 !  8: e4e3f327c6 Support to disable lifecycles
    @@ -29,13 +29,13 @@
     -<h1><&|/l&>Lifecycles</&></h1>
     +<form method="post" action="<% RT->Config->Get('WebPath') %>/Admin/Lifecycles/index.html">
     +  <div class="form-row">
    -+    <div class="col-md-auto">
    ++    <div class="col-auto">
     +      <div class="custom-control custom-checkbox">
     +        <input type="checkbox" class="custom-control-input checkbox" id="FindDisabledLifecycles" name="FindDisabledLifecycles" value="1" <% $FindDisabledLifecycles ? 'checked="checked"': '' |n%> />
     +        <label class="custom-control-label" for="FindDisabledLifecycles"><&|/l&>Include disabled lifecycles in listing.</&></label>
     +      </div>
     +    </div>
    -+    <div class="col-md-auto">
    ++    <div class="col-auto">
     +      <input type="submit" name="Go" class="form-control btn btn-primary" value="<&|/l&>Go!</&>" />
     +    </div>
     +  </div>
    @@ -80,7 +80,7 @@
     +  </table>
     +
     +  <div class="form-row">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <div align="right">
     +        <input type="submit" name="Submit" class="form-control btn btn-primary" value="<&|/l&>Update</&>" />
     +      </div>
 9: 4e8e706ff2 =  9: 2a423e8ae9 Add d3.js to RT
10: 0128707d65 = 10: 347f041c54 Abstract ValidateLifecycle and ValidateLifecycleMaps from FillCache
11: b214374bac ! 11: 9e9c46c1fe New lifecycle editor based on original extension and Craig's big refactor
    @@ -80,7 +80,7 @@
     +
     +  <& /Elements/Lifecycle/Graph, Name => $Name, Config => $Config, Layout => $Layout &>
        <div class="form-row">
    -     <div class="col-md-12">
    +     <div class="col-12">
     -      <& /Elements/Submit, Label => loc('Save Changes') &>
     +      <& /Elements/Submit, Name => 'Update', Label => loc('Save Changes') &>
          </div>
    @@ -227,19 +227,19 @@
     +    <input type="hidden" name="id" />
     +    <div class="alert alert-warning invalid-name hidden"><&|/l&>Invalid name</&></div>
     +    <div class="form-row">
    -+      <div class="col-md-3 label">
    ++      <div class="col-3 label">
     +        <label for="name"><&|/l&>Name</&>:</label>
     +      </div>
    -+      <div class="col-md-9 value">
    ++      <div class="col-9 value">
     +        <input class="form-control" type="text" id="name" name="name" value="" />
     +      </div>
     +    </div>
     +
     +    <div class="form-row">
    -+      <div class="col-md-3 label">
    ++      <div class="col-3 label">
     +        <label for="type"><&|/l&>Type</&>:</label>
     +      </div>
    -+      <div class="col-md-9 value">
    ++      <div class="col-9 value">
     +        <select class="selectpicker form-control" id="type" name="type">
     +          <option value="initial"><&|/l&>Initial</&></option>
     +          <option value="active"><&|/l&>Active</&></option>
    @@ -248,7 +248,7 @@
     +      </div>
     +    </div>
     +    <div class="form-row">
    -+      <div class="col-md-12 text-right">
    ++      <div class="col-12 text-right">
     +        <button class="btn btn-light" id="CancelNode"><&|/l&>Cancel</&></button>
     +        <button class="button btn btn-primary form-control" id="SaveNode"><&|/l&>Save</&></button>
     +      </div>
    @@ -256,7 +256,7 @@
     +  </div>
     +
     +  <div class="form-row">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <svg></svg>
     +    </div>
     +  </div>
    @@ -267,7 +267,7 @@
     +    });
     +  </script>
     +  <div class="row">
    -+    <div class="col-md-auto">
    ++    <div class="col-auto">
     +      <span class="current-value form-control">
     +        <div class="custom-control custom-checkbox">
     +          <input class="custom-control-input" type="checkbox" id="enableSimulation" name="enableSimulation" />
    @@ -279,7 +279,7 @@
     +    </div>
     +  </div>
     +  <div class="row">
    -+    <div class="col-md-auto">
    ++    <div class="col-auto">
     +      <p>
     +        <&|/l&>Click in the open space to <strong>add a node</strong>.<br>
     +To <strong>delete</strong> a node click on the node to select it and press the 'd' key.<br>
12: 5e768c0c39 ! 12: ac964e55ed Add lifecycle UI Advanced page
    @@ -75,22 +75,22 @@
     +  <input type="hidden" class="hidden" name="Type" value="<% $LifecycleObj->Type %>" />
     +
     +  <div class="form-row">
    -+    <span class="col-md-12">
    ++    <span class="col-12">
     +      <textarea class="form-control" rows="30" name="Config"><% $Config |n %></textarea>
     +    </span>
     +  </div>
     +
     +  <div class="form-row invalid-json hidden">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <div class="alert alert-danger mb-0"><&|/l&>Invalid JSON</&></div>
     +    </div>
     +  </div>
     +
     +  <div class="form-row">
    -+    <div class="col-md-6 d-flex">
    ++    <div class="col-6 d-flex">
     +      <& /Elements/Submit, Label => loc('Validate'), Name => 'Validate' &>
     +    </div>
    -+    <div class="col-md-6">
    ++    <div class="col-6">
     +      <& /Elements/Submit, Label => loc('Save Changes'), Name => 'Update' &>
     +    </div>
     +  </div>
13: da17b067f2 ! 13: ce0d00fdeb Add lifecycle UI Actions page
    @@ -128,7 +128,7 @@
     +% }
     +  </table>
     +  <div class="form-row">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <& /Elements/Submit, Label => loc('Save Changes'), Name => 'Update' &>
     +    </div>
     +  </div>
14: 19d17d3e6c ! 14: 54884727d6 Add lifecycle UI Rights page
    @@ -115,7 +115,7 @@
     +  </table>
     +
     +  <div class="form-row">
    -+    <div class="col-md-12">
    ++    <div class="col-12">
     +      <& /Elements/Submit, Label => loc('Save Changes'), Name => 'Update' &>
     +    </div>
     +  </div>
15: a857a2fd6d = 15: 5a96380c42 Default on_create to the first initial status
16: e2675be97a = 16: 2f3a6ca41c Skip form and show hints if mapping is not needed
17: 4dc948e73e = 17: e494c51735 Redirect to Advanced page on lifecycle modify page for IE
18: 89d3a490f0 ! 18: cbca7a71d2 Add inline documentation to guide lifecycle users
    @@ -10,7 +10,7 @@
      <& /Elements/Tabs &>
      <& /Elements/ListActions, actions => \@results &>
     +<div class="form-row">
    -+  <div class="col-md-12">
    ++  <div class="col-12">
     +    <p><&|/l&>Create actions that will appear in the Actions menu for tickets or assets.</&></p>
     +    <ul>
     +      <li><&|/l&>From and To define the status transition.</&></li>
    @@ -31,7 +31,7 @@
      <& /Elements/Tabs &>
      <& /Elements/ListActions, actions => \@results &>
     +<div class="form-row">
    -+  <span class="col-md-12">
    ++  <span class="col-12">
     +    <p><&|/l&>The advanced view gives you direct access to the full lifecycle configuration for advanced changes.</&></p>
     +  </span>
     +</div>
    @@ -47,7 +47,7 @@
      <& /Elements/Tabs &>
      <& /Elements/ListActions, actions => \@results &>
     +<div class="form-row">
    -+  <div class="col-md-12">
    ++  <div class="col-12">
     +    <p><&|/l&>If a ticket is moved from one queue or catalog to another, these mappings define how statuses should be updated.</&></p>
     +  </div>
     +</div>
    @@ -63,7 +63,7 @@
      <& /Elements/Tabs &>
      <& /Elements/ListActions, actions => \@results &>
     +<div class="form-row">
    -+  <div class="col-md-12">
    ++  <div class="col-12">
     +    <p><&|/l&>Create statuses for your lifecycle and define the transitions allowed between them.</&></p>
     +  </div>
     +</div>
    @@ -79,7 +79,7 @@
      <& /Elements/Tabs &>
      <& /Elements/ListActions, actions => \@results &>
     +<div class="form-row">
    -+  <div class="col-md-12">
    ++  <div class="col-12">
     +    <p><&|/l&>Define custom rights and apply them to status transitions.  Once defined, these rights will appear on RT rights pages, like queue group rights, where you can assign them.</&></p>
     +  </div>
     +</div>
    @@ -101,7 +101,7 @@
            </span>
     @@
        <div class="row">
    -     <div class="col-md-auto">
    +     <div class="col-auto">
            <p>
     -        <&|/l&>Click in the open space to <strong>add a node</strong>.<br>
     -To <strong>delete</strong> a node click on the node to select it and press the 'd' key.<br>
19: 85f9244c50 = 19: c6930e214c Add file configs as fallbacks for hash database configs



More information about the rt-commit mailing list