[Rt-commit] rt branch, 4.6/search-selection-next, repushed

Blaine Motsinger blaine at bestpractical.com
Tue Feb 4 18:49:45 EST 2020


The branch 4.6/search-selection-next was deleted and repushed:
       was 06b3eb4f417502fa7b5d38179c8a414f5de1e980
       now 6adc6c6955ca441fc3e2c58b4b856c6243be08c7

1: 6a6be39aa4 = 1: 6a6be39aa4 Add RT-Extension-DashboardSelectionUI to core
2: c363780e3f = 2: c363780e3f Upgrade jQuery ui sortable and add disableSelection
3: b561b6c116 = 3: b561b6c116 Update DashboardSelectionUI to elevator-light
4: 329695eb79 = 4: 329695eb79 Switch remove icon to fontawesome
5: 033072132d = 5: 033072132d Fix reset to defaults
6: 06b3eb4f41 ! 6: 6adc6c6955 Force redirect back to the current page on submit
    @@ -18,13 +18,14 @@
                      success: function (response) {
                          if (response.ok) {
     -                        window.location.reload();
    -+                        // force redirect back to the current page after submitting the form.
    -+                        // this does two things.
    -+                        // first, we ensure the preferences in the page are current with the database.
    -+                        // second, we reset last operation in the browser cache for the page so it's not holding a previous post.
    -+                        // if the user "resets to defaults", that operation would otherwise stay cached.
    -+                        // so when the user then saves new values, two posts are done; one to save new values, and one
    -+                        // to reset them again, effectively wiping out the changes they just made.
    ++                        // Force redirect back to the current page on submit.
    ++                        // If the user submits a post to "reset to default", then immediately
    ++                        // a post to save new changes, the JS was instructing the browser to
    ++                        // reload which then submitted the reset post again.
    ++
    ++                        // Instead of reload, the JS now redirects back to the current page
    ++                        // to clear out the previous post "state" so not to immediately reset
    ++                        // the new changes.
     +                        var current_location = window.location;
     +                        window.location.replace( current_location );
                          }



More information about the rt-commit mailing list