[Rt-commit] rt branch, 4.6/auto-width-refresh-dropdown, created. rt-4.4.4-725-g1e4280c626

? sunnavy sunnavy at bestpractical.com
Wed Feb 5 14:37:32 EST 2020


The branch, 4.6/auto-width-refresh-dropdown has been created
        at  1e4280c626811ac78a721a60d8a59beb72fcf651 (commit)

- Log -----------------------------------------------------------------
commit f6510320b7f6f3df1fec6341b60102991acc766f
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Feb 6 01:51:47 2020 +0800

    Set refresh dropdown width to auto
    
    There is no need to force the small dropdown to take the whole width.
    Thus in normal size screens, we could have the dropdown and submit
    button in the same row, just like previous RT versions.

diff --git a/share/html/Elements/RefreshHomepage b/share/html/Elements/RefreshHomepage
index 16839ce20b..aa6e1f8640 100644
--- a/share/html/Elements/RefreshHomepage
+++ b/share/html/Elements/RefreshHomepage
@@ -48,14 +48,12 @@
 <&|/Widgets/TitleBox, title => loc('Refresh')&>
 <form method="get" action="<% RT->Config->Get('WebPath') . $m->request_path %>">
 <div class="form-row">
-  <div class="col-md-12">
-<& /Elements/Refresh, Name => 'HomeRefreshInterval', 
-    Default => $session{'home_refresh_interval'}||RT->Config->Get('HomePageRefreshInterval', $session{'CurrentUser'}) &>
+  <div class="col-auto">
+    <& /Elements/Refresh, Name => 'HomeRefreshInterval',
+      Default => $session{'home_refresh_interval'}||RT->Config->Get('HomePageRefreshInterval', $session{'CurrentUser'}) &>
   </div>
-</div>
-<div class="form-row">
-  <div class="col-md-12">
-<& /Elements/Submit,  Label => loc('Go!') &>
+  <div class="col-auto">
+    <& /Elements/Submit,  Label => loc('Go!') &>
   </div>
 </div>
 </form>
diff --git a/share/html/Search/Results.html b/share/html/Search/Results.html
index 766b79ee40..863c761eb5 100644
--- a/share/html/Search/Results.html
+++ b/share/html/Search/Results.html
@@ -86,9 +86,11 @@
 % foreach my $key (keys(%hiddens)) {
 <input type="hidden" class="hidden" name="<%$key%>" value="<% defined($hiddens{$key})?$hiddens{$key}:'' %>" />
 % }
-<& /Elements/Refresh, Name => 'TicketsRefreshInterval', Default => $session{$interval_name}||RT->Config->Get('SearchResultsRefreshInterval', $session{'CurrentUser'}) &>
 <div class="form-row">
-  <div class="col-md-12">
+  <div class="col-auto">
+    <& /Elements/Refresh, Name => 'TicketsRefreshInterval', Default => $session{$interval_name}||RT->Config->Get('SearchResultsRefreshInterval', $session{'CurrentUser'}) &>
+  </div>
+  <div class="col-auto">
     <input type="submit" class="button btn btn-primary form-control" value="<&|/l&>Change</&>" />
   </div>
 </div>

commit 1e4280c626811ac78a721a60d8a59beb72fcf651
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Feb 6 02:02:15 2020 +0800

    Lower keyboard shortcuts help text a bit
    
    As refresh dropdown and submit button are in the same row now, the
    following keyboard shortcuts div is too close to them.  0.5rem is the
    same as the margin-top of .form-row.

diff --git a/share/static/css/elevator-light/keyboard-shortcuts.css b/share/static/css/elevator-light/keyboard-shortcuts.css
index 690a64bb1e..aa16e55fa1 100644
--- a/share/static/css/elevator-light/keyboard-shortcuts.css
+++ b/share/static/css/elevator-light/keyboard-shortcuts.css
@@ -12,6 +12,7 @@
 
 .keyboard-shortcuts.footer{
     font-size: 0.9em;
+    margin-top: 0.5rem;
 }
 
 .keyboard-shortcuts .keyboard-shortcuts-key {

-----------------------------------------------------------------------


More information about the rt-commit mailing list