[Rt-commit] rt branch, 4.6/lifecycle-ui-dev, repushed

Craig Kaiser craig at bestpractical.com
Wed Feb 26 16:20:02 EST 2020


The branch 4.6/lifecycle-ui-dev was deleted and repushed:
       was 0fb30a3025f5e109f73a69d0ef96652b875864d2
       now 5a134b9ce1e64168bb9a2fcf077f89ef3064579a

 1: bcbef5b8a =  1: bcbef5b8a Core lifecycle-UI
 2: d9e6ba9c0 =  2: d9e6ba9c0 Use RT::Configuration to store lifecycle config instead of RT::Attribute
 3: 5d6ddbc25 =  3: 5d6ddbc25 Migrate lifecycle UI pages to elevator theme
 4: d7ee8a9f3 =  4: d7ee8a9f3 Ensure lifecycle cache is updated across threads when flagged
 5: 6adda0c9f =  5: 6adda0c9f Add lifecycle UI Advanced page
 6: f116a2e8f =  6: f116a2e8f Add lifecycle UI Actions page
 7: 6ba6d1da6 =  7: 6ba6d1da6 Add lifecycle UI Rights page
 8: c535bab62 =  8: c535bab62 Add lifecycle Rights/Actions/Advanced pages to menu
 9: 41006367d =  9: 41006367d Increase column size on lifecycle mappings page
10: 9d4a46221 ! 10: 53c5b5ce2 Allow for lifecycle to be set to disabled
    @@ -125,12 +125,12 @@
     +        if ( $ARGS{"enable-lifecycle-$lifecycle"} ) {
     +            if ( $lifecycles{$lifecycle}{'disabled'} && $lifecycles{$lifecycle}{'disabled'} eq 1 ) {
     +              $lifecycles{$lifecycle}{'disabled'} = 0;
    -+              push @results, loc("Set lifecycle $lifecycle to enabled");
    ++              push @results, loc("Set lifecycle [_1] to enabled", $lifecycle);
     +            }
     +        }
     +        elsif ( !$lifecycles{$lifecycle}{'disabled'} ) {
     +            $lifecycles{$lifecycle}{'disabled'} = 1;
    -+            push @results, loc("Set lifecycle $lifecycle to disabled");
    ++            push @results, loc("Set lifecycle [_1] to disabled", $lifecycle);
     +        }
     +    }
     +
11: 4c5661611 = 11: bb3031fd8 Add 'remove' checkbox for lifecycle rights and actions page"
12: 622c4bf0c = 12: 0b6c1d31d Only check if status needs to be removed from maps if we are updating one lifecycle
13: 641b490bc = 13: 2bb62d28d Make changes to lifecycle Configuration in context of current user
14: 7e42eb7da ! 14: a739c60b6 Ensure lifecycle cache is flagged for updating on rights and actions change
    @@ -20,15 +20,22 @@
     --- a/lib/RT/Interface/Web.pm
     +++ b/lib/RT/Interface/Web.pm
     @@
    -     }
      
          RT->Config->RefreshConfigFromDatabase();
    + 
    +-    MaybeRebuildLifecycleCache();
     -
    --    MaybeRebuildLifecycleCache();
    +     $HTML::Mason::Commands::r->content_type("text/html; charset=utf-8");
    + 
    +     $HTML::Mason::Commands::m->{'rt_base_time'} = [ Time::HiRes::gettimeofday() ];
    +@@
    +     MaybeShowInstallModePage();
    + 
    +     MaybeRebuildCustomRolesCache();
     +    RT::System::MaybeRebuildLifecycleCache();
      
    -     $HTML::Mason::Commands::r->content_type("text/html; charset=utf-8");
    - 
    +     $HTML::Mason::Commands::m->comp( '/Elements/SetupSessionCookie', %$ARGS );
    +     SendSessionCookie();
     @@
          }
      }
15: f54de048a = 15: 2419e8644 Use standard update lifecycle method on index page
16: 972f735c0 = 16: 0c9e84e08 Allow for spaces in actions key
17: 0f119f7ce = 17: 267c20711 Set sensible default value for "on_create" if not provided
18: c1b19d79a = 18: 932566eda Do not re-load displayed config value if lifecycle fails validation
19: d09c2b3cc = 19: 6f97cf0ba Remove unused code
20: f99c3b24b = 20: da846849b Convert node name checks and transitions to lowercase
21: ea263be68 = 21: aedad301f Ensure we flag the lifecycle cache needs updating on lifecycle save
22: f3f9df9e8 = 22: 238894b89 Skip warning if unecessary default key is not provided
23: 0fb30a302 = 23: 5a134b9ce Validate the lifecycle submitted on the Modify page before saving



More information about the rt-commit mailing list