[Rt-commit] rt branch, 4.6/core-customrole-visibility, updated. rt-4.4.4-571-gc6776c71cd

Blaine Motsinger blaine at bestpractical.com
Tue Jan 7 20:13:29 EST 2020


The branch, 4.6/core-customrole-visibility has been updated
       via  c6776c71cd87c860d49a0c024346bb996a88689e (commit)
      from  b24a8cea737144953bfcb1f72b7ade9049cdc03a (commit)

Summary of changes:
 share/html/Ticket/Elements/EditBasics | 1 +
 share/html/Ticket/Elements/EditPeople | 8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit c6776c71cd87c860d49a0c024346bb996a88689e
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Tue Jan 7 18:47:10 2020 -0600

    Update role entry hints to tooltips
    
    For the custom role display in EditBasics, the ShowEntryHint arg is
    set to 0 to keep the hint from displaying below the input.

diff --git a/share/html/Ticket/Elements/EditBasics b/share/html/Ticket/Elements/EditBasics
index f89782f4e2..d3f81e9c54 100644
--- a/share/html/Ticket/Elements/EditBasics
+++ b/share/html/Ticket/Elements/EditBasics
@@ -153,6 +153,7 @@ unless ($ExcludeCustomRoles) {
                 role    => $role,
                 Ticket  => $TicketObj,
                 Default => $defaults{$role->GroupType},
+                ShowEntryHint => 0,
             }
         };
     }
diff --git a/share/html/Ticket/Elements/EditPeople b/share/html/Ticket/Elements/EditPeople
index 7899187d4e..e2b390b04c 100644
--- a/share/html/Ticket/Elements/EditPeople
+++ b/share/html/Ticket/Elements/EditPeople
@@ -88,8 +88,12 @@
 % $m->callback( CustomRoles => $single_roles, SingleRoles => 1, Ticket => $Ticket, %ARGS, CallbackName => 'ModifyCustomRoles' );
 % while (my $role = $single_roles->Next) {
 <div class="form-row">
-  <div class="col-md-3 label"><% $role->Name %>:</div>
-  <div class="col-md-6 value"><& /Elements/SingleUserRoleInput, role => $role, Ticket => $Ticket &></div>
+  <div class="form-group col-md-3 label"><% $role->Name %>:
+% if ($role->EntryHint) {
+    <span class="far fa-question-circle icon-helper" data-toggle="tooltip" data-placement="top" data-original-title="<% $role->EntryHint %>"></span>
+% }
+  </div>
+  <div class="col-md-6 value"><& /Elements/SingleUserRoleInput, role => $role, Ticket => $Ticket, ShowEntryHint => 0 &></div>
 </div>
 
 % }

-----------------------------------------------------------------------


More information about the rt-commit mailing list