[Rt-commit] rtir branch, 5.0.0-releng, updated. 5.0.0beta1-13-g675ed904

[Jim Brandt]

The branch, 5.0.0-releng has been updated
       via  675ed904d652ce3f4031b3ca7b4c30ffd2f4855e (commit)
       via  86222ffc1f4550eb26bb88a774dccd4278a6df14 (commit)
      from  5a26a422d2602560f89b4b79da3ee1a143fc2aa8 (commit)

Summary of changes:
 html/Callbacks/RTIR/Elements/Tabs/Privileged | 4 ----
 t/009-attachments-processing.t               | 5 -----
 2 files changed, 9 deletions(-)

- Log -----------------------------------------------------------------
commit 86222ffc1f4550eb26bb88a774dccd4278a6df14
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Jul 2 02:22:07 2020 +0800

    Remove the confusing incident Reply page menu
    
    The incident reply page, accessed via "Reply to Reporters" or
    "Reply to All" had a "Reply" entry in the submenu. This menu
    was originally to allow users to navigate back to the reply
    page after using "Edit Search". Users can now do this by
    clicking on "Show Results" after modifying their search.
    
    Showing it on the reply page itself is confusing since it
    takes you to the page you are already on.

diff --git a/html/Callbacks/RTIR/Elements/Tabs/Privileged b/html/Callbacks/RTIR/Elements/Tabs/Privileged
index 44eca7d1..16fb1979 100644
--- a/html/Callbacks/RTIR/Elements/Tabs/Privileged
+++ b/html/Callbacks/RTIR/Elements/Tabs/Privileged
@@ -461,10 +461,6 @@ if ( $request_path =~ m{(?:$re_rtir_path)(?:$re_rtir_types/)?(Display|Edit|Updat
         RTIR             => 1,
     );
 
-    PageMenu()->child(
-        link => title => loc('Reply'),
-        path => RT::IR->HREFTo("Incident/Reply/?". $query_string->( %args ), IncludeWebPath => 0),
-    );
     PageMenu()->child(
         edit_search => title => loc('Edit Search'),
         path => '/Search/Build.html?' . $query_string->( %args, ResultPage => RT::IR->HREFTo('Incident/Reply/') ),
diff --git a/t/009-attachments-processing.t b/t/009-attachments-processing.t
index 70e7ea24..07e8ce45 100644
--- a/t/009-attachments-processing.t
+++ b/t/009-attachments-processing.t
@@ -203,11 +203,6 @@ $agent->goto_create_rtir_ticket('Countermeasures');
 
     $agent->display_ticket( $inc_id);
     $agent->follow_link_ok({text => 'Reply to Reporters'}, "go to 'Reply to Reporters'");
-    $agent->content_contains( "<input type=\"checkbox\" name=\"SelectedReportsAll\" value=\"1\" checked=\"checked\"",
-                              'Checkboxes checked for reply all');
-
-    $agent->follow_link_ok({text => 'Reply'}, "Confirm 'Reply' link returns here in same state");
-
     $agent->content_contains( "<input type=\"checkbox\" name=\"SelectedReportsAll\" value=\"1\" checked=\"checked\"",
                               'Checkboxes checked for reply all');
 

commit 675ed904d652ce3f4031b3ca7b4c30ffd2f4855e
Merge: 5a26a422 86222ffc
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Jul 10 15:26:59 2020 -0400

    Merge branch '5.0/remove-incident-reply-page-menu' into 5.0.0-releng


-----------------------------------------------------------------------