[Rt-commit] rtir branch, 5.0/travis-test, created. 4.0.1rc1-200-g96154478

Jim Brandt jbrandt at bestpractical.com
Thu Jun 11 14:03:45 EDT 2020


The branch, 5.0/travis-test has been created
        at  96154478e9b6cf77b4aa592f28cb2bb4f8997ae5 (commit)

- Log -----------------------------------------------------------------
commit a243aa1b068c7e9ff98dabad8774da014917e9f6
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Apr 16 13:13:32 2020 -0400

    Update Module::Install
    
    Needed for new Module::Install::RTx.

diff --git a/META.yml b/META.yml
index 7e75d1a6..9901c2f7 100644
--- a/META.yml
+++ b/META.yml
@@ -34,6 +34,6 @@ requires:
 resources:
   license: http://opensource.org/licenses/gpl-license.php
 version: 4.0.1rc1
-x_module_install_rtx_version: '0.40'
+x_module_install_rtx_version: '0.41'
 x_requires_rt: 4.6.0
-x_rt_too_new: 4.8.0
+x_rt_too_new: 5.2.0
diff --git a/inc/Module/Install/RTx.pm b/inc/Module/Install/RTx.pm
index 7cad5299..d371af9b 100644
--- a/inc/Module/Install/RTx.pm
+++ b/inc/Module/Install/RTx.pm
@@ -8,7 +8,7 @@ no warnings 'once';
 
 use Module::Install::Base;
 use base 'Module::Install::Base';
-our $VERSION = '0.40';
+our $VERSION = '0.41';
 
 use FindBin;
 use File::Glob     ();
@@ -53,7 +53,7 @@ sub RTx {
         my @look = @INC;
         unshift @look, grep {defined and -d $_} @try;
         push @look, grep {defined and -d $_}
-            map { ( "$_/rt4/lib", "$_/lib/rt4", "$_/lib" ) } @prefixes;
+            map { ( "$_/rt5/lib", "$_/lib/rt5", "$_/rt4/lib", "$_/lib/rt4", "$_/lib" ) } @prefixes;
         last if eval {local @INC = @look; require RT; $RT::LocalLibPath};
 
         warn

commit 06620230967d2a38c3ecc96dd9089e581c7246db
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Apr 16 17:20:17 2020 -0400

    Initial travis testing file

diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 00000000..3691e3af
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,20 @@
+language: bash
+services: docker
+
+notifications:
+  slack:
+    secure: ebb/6lbr1ob7wMh04C5PzM5/NNz6IstEUaUROA7BATuKKgPetl6qwmQNwvlwE5zYvJQBWQwKJ70JaCzJkXK6JVMVRRAWsXINJTzMfSqsoXEcJ59c5isf0bsnspVO7jxHTfXF/NZngR4EuPwH5v5lWp9m++j90t9nBKFFVi34WUE=
+
+env:
+    - RT_DBA_USER=root RT_DBA_PASSWORD=password DB_VERSION_TAG=10.3
+
+# $TRAVIS_BUILD_DIR will have a clone of the current branch
+before_install:
+    - docker run --name mariadb -e MYSQL_ROOT_PASSWORD=password -d mariadb:$DB_VERSION_TAG
+    - docker build -t rt-base .
+    - docker run -d -v $TRAVIS_BUILD_DIR:/rtir --name rtir --link mariadb:db rt-base
+    - docker ps -a
+    - docker exec -it rtir bash -c "cd /rtir && perl Makefile.PL"
+
+script:
+    - docker exec -it rtir bash -c "cd /rtir && prove -l t/*"
diff --git a/Dockerfile b/Dockerfile
new file mode 100644
index 00000000..a7e3f809
--- /dev/null
+++ b/Dockerfile
@@ -0,0 +1,25 @@
+FROM bpssysadmin/rt-base-debian-stretch
+
+LABEL maintainer="Best Practical Solutions <contact at bestpractical.com>"
+
+# Valid values are RT branches like 5.0-trunk or version tags like rt-4.4.4
+ENV RT_VERSION 5.0-trunk
+ENV RT_TEST_DEVEL 1
+ENV RT_DBA_USER root
+ENV RT_DBA_PASSWORD password
+ENV RT_TEST_DB_HOST=172.17.0.2
+ENV RT_TEST_RT_HOST=172.17.0.3
+
+RUN cd /usr/local/src \
+  && git clone https://github.com/bestpractical/rt.git \
+  && cd rt \
+  && git checkout $RT_VERSION \
+  && ./configure.ac \
+    --disable-gpg --disable-smime --enable-developer --enable-gd --enable-graphviz --with-db-type=SQLite \
+  && make install \
+  && make initdb \
+  && rm -rf /usr/local/src/*
+
+RUN cpanm Parse::BooleanLogic
+
+CMD tail -f /dev/null

commit f5d0e726564aeeef5dd556bc4b29842002c7a823
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Fri Apr 17 17:27:11 2020 -0400

    Check individual linked incidents on split page
    
    The previous is_deeply call failed when running on the Debian
    test Docker container because it appears to display the second
    linked incident twice. This shows up in the dumped HTML and in the
    params returned in the test.
    
    Unable to reproduce this manually in a running RTIR, this update converts the
    test to an affirmative test for the links. However the test may be
    revealing a bug that only happens in certain circumstances, so leaving
    a comment for further investigation.

diff --git a/t/report/split.t b/t/report/split.t
index 9e09d3c1..e0dc6959 100644
--- a/t/report/split.t
+++ b/t/report/split.t
@@ -3,7 +3,9 @@ use warnings;
 
 use RT::IR::Test tests => undef;
 
-RT::Test->started_ok;
+my ($baseurl, $agent) = RT::Test->started_ok;
+diag "Test server running at: $baseurl";
+
 my $m = default_agent();
 
 my %viewed = ( '/NoAuth/Logout.html' => 1 );    # in case logout
@@ -24,7 +26,11 @@ my $extra_incident = $m->create_incident({ Subject => "further test Incident" })
     $m->follow_link_ok({text => "Split"}, "Followed link");
     $m->form_number(3);
 
-    is_deeply([grep $_, $m->current_form->param('Incident')],[$first_incident,$second_incident],"Both Incidents are Checked");
+    # TODO: check the split form to see if the second incident is being displayed twice
+    my @ir_params = $m->current_form->param('Incident');
+    is($ir_params[0], $first_incident, "First incident is checked");
+    is($ir_params[1], $second_incident, "Second incident is checked");
+
     $m->click_ok('Create',"Split the Report");
 
     my $new_ir = $m->get_ticket_id;
@@ -40,7 +46,10 @@ my $extra_incident = $m->create_incident({ Subject => "further test Incident" })
     $m->follow_link_ok({text => "Split"}, "Followed link");
     $m->form_number(3);
 
-    is_deeply([grep $_, $m->current_form->param('Incident')],[$first_incident,$second_incident],"Both Incidents are Checked");
+    my @ir_params = $m->current_form->param('Incident');
+    is($ir_params[0], $first_incident, "First incident is checked");
+    is($ir_params[1], $second_incident, "Second incident is checked");
+
     $m->untick('Incident',1);
     $m->click_ok('Create',"Split the Report");
 
@@ -57,7 +66,10 @@ my $extra_incident = $m->create_incident({ Subject => "further test Incident" })
     $m->follow_link_ok({text => "Split"}, "Followed link");
     $m->form_number(3);
 
-    is_deeply([grep $_, $m->current_form->param('Incident')],[$first_incident,$second_incident],"Both Incidents are Checked");
+    my @ir_params = $m->current_form->param('Incident');
+    is($ir_params[0], $first_incident, "First incident is checked");
+    is($ir_params[1], $second_incident, "Second incident is checked");
+
     $m->untick('Incident',1);
     $m->untick('Incident',2);
     $m->field('Incident',$extra_incident,3);

commit 6e46436708e34ab15bd9dcc00efeafc1a85ebdbc
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Jun 11 11:20:49 2020 -0400

    Install new module dependency

diff --git a/Dockerfile b/Dockerfile
index a7e3f809..e702c3c6 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -20,6 +20,7 @@ RUN cd /usr/local/src \
   && make initdb \
   && rm -rf /usr/local/src/*
 
+RUN cpanm Net::Whois::RIPE
 RUN cpanm Parse::BooleanLogic
 
 CMD tail -f /dev/null

commit 96154478e9b6cf77b4aa592f28cb2bb4f8997ae5
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Jun 11 14:03:11 2020 -0400

    Remove explicit disabling of gpg and smime

diff --git a/Dockerfile b/Dockerfile
index e702c3c6..9ed0b5a3 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -15,7 +15,7 @@ RUN cd /usr/local/src \
   && cd rt \
   && git checkout $RT_VERSION \
   && ./configure.ac \
-    --disable-gpg --disable-smime --enable-developer --enable-gd --enable-graphviz --with-db-type=SQLite \
+    --enable-developer --enable-gd --enable-graphviz --with-db-type=SQLite \
   && make install \
   && make initdb \
   && rm -rf /usr/local/src/*

-----------------------------------------------------------------------


More information about the rt-commit mailing list