[Rt-commit] rt branch, 4.4/txn-text-cf-ui, repushed

? sunnavy sunnavy at bestpractical.com
Thu Mar 12 18:44:57 EDT 2020


The branch 4.4/txn-text-cf-ui was deleted and repushed:
       was 7346078faed484648fe890fbbd8f520fa25419aa
       now 81011570c05227ed3c77a1f97d2f101e2e666810

1: 7346078fa ! 1: 81011570c Friendly transaction UI of text CF changes especially for large contents
    @@ -5,28 +5,28 @@
         Previously the single-line description was hardly readable for large
         contents, e.g.
         
    -        intro RT is an enterprise-grade issue tracking system. It allows
    -        organizations to keep track of their to-do lists, who is working on
    -        which tasks, what's already been done, and when tasks were completed. It
    -        is available under the terms of version 2 of the GNU General Public
    -        License (GPL), so it doesn't cost anything to set up and use. changed to
    -        RT is commercially-supported software. To purchase support, training,
    -        custom development, or professional services, please get in touch with
    -        us at <sales at bestpractical.com>.
    +      intro RT is an enterprise-grade issue tracking system. It allows
    +      organizations to keep track of their to-do lists, who is working on
    +      which tasks, what's already been done, and when tasks were completed. It
    +      is available under the terms of version 2 of the GNU General Public
    +      License (GPL), so it doesn't cost anything to set up and use. changed to
    +      RT is commercially-supported software. To purchase support, training,
    +      custom development, or professional services, please get in touch with
    +      us at <sales at bestpractical.com>.
         
         Now it's like:
         
    -        intro changed
    -    
    -        From: RT is an enterprise-grade issue tracking system. It allows
    -              organizations to keep track of their to-do lists, who is working on
    -              which tasks, what's already been done, and when tasks were completed.
    -              It is available under the terms of version 2 of the GNU General
    -              Public License (GPL), so it doesn't cost anything to set up and use.
    -    
    -        To:   RT is commercially-supported software. To purchase support,
    -              training, custom development, or professional services, please get in
    -              touch with us at .
    +      intro changed
    +    
    +      From: RT is an enterprise-grade issue tracking system. It allows
    +            organizations to keep track of their to-do lists, who is working on
    +            which tasks, what's already been done, and when tasks were completed.
    +            It is available under the terms of version 2 of the GNU General
    +            Public License (GPL), so it doesn't cost anything to set up and use.
    +    
    +      To:   RT is commercially-supported software. To purchase support,
    +            training, custom development, or professional services, please get in
    +            touch with us at <sales at bestpractical.com>.
         
         Which is way more clear and friendly.
     
    @@ -39,10 +39,10 @@
                  }
     +            elsif ( $cf->Type =~ /text/i ) {
     +                if ( !defined($old) || $old eq '' ) {
    -+                    return ("[_1] added", $field);   #loc()
    ++                    return ("[_1] added", $field);      #loc()
     +                }
     +                else {
    -+                    return ("[_1] changed", $field);   #loc()
    ++                    return ("[_1] changed", $field);    #loc()
     +                }
     +            }
              }
    @@ -90,7 +90,6 @@
     +%   }
     +      </table>
     +    </div>
    -+    </pre>
     +% }
        </div>
      % $m->callback( %ARGS, Transaction => $Transaction, CallbackName => 'AfterContent' );
    @@ -106,10 +105,10 @@
     +    $cf->Load( $Transaction->Field );
     +    if ( $cf->Id && $cf->Type =~ /text/i ) {
     +        $old = $Transaction->OldValue // loc('(no value)');
    -+        $new = $Transaction->NewValue // loc('(no value)');
     +        $old = $m->comp('/Elements/ScrubHTML', Content => $old);
     +        $old =~ s|\n|<br />|g;
     +
    ++        $new = $Transaction->NewValue // loc('(no value)');
     +        $new = $m->comp('/Elements/ScrubHTML', Content => $new);
     +        $new =~ s|\n|<br />|g;
     +



More information about the rt-commit mailing list