[Rt-commit] rt branch, 5.0/hide-pencil-button-if-no-rights, repushed

Michel Rodriguez michel at bestpractical.com
Thu Mar 26 08:37:54 EDT 2020


The branch 5.0/hide-pencil-button-if-no-rights was deleted and repushed:
       was f38f8a1f27a5825955bea5f3f3d489a57e6e9ec3
       now fe851269c4f26f292799345d089d14d440301d9c

1: 53b4119956 < -:  ------- Bug fix: use the right CurrentUserCanSetOwner return value.
-:  ------- > 1: 698258c750 Bug fix: use the right CurrentUserCanSetOwner return value.
2: f38f8a1f27 ! 2: fe851269c4 Hide the pencil icon if the user doesn't have the rights.
    @@ -9,11 +9,18 @@
     --- a/share/html/Ticket/Elements/ShowSummary
     +++ b/share/html/Ticket/Elements/ShowSummary
     @@
    +     . '<a class="inline-edit-toggle cancel hidden" href="#">'
    +     . qq{<span class="fas fa-times icon-bordered fa-2x" alt="$cancel_label" data-toggle="tooltip" data-placement="top" data-original-title="$cancel_label"></span>}
    +     . '</a>';
    +-my $modify_basics = sprintf( $modify_inline, $m->interp->apply_escapes( $modify_url, 'h' ) );
    ++my $modify_basics = ($can_modify || $can_modify_cf) ? sprintf( $modify_inline, $m->interp->apply_escapes( $modify_url, 'h' ) ) : '';
    + my $modify_behavior = $InlineEdit ? ($inline_edit_behavior{Basics} || $inline_edit_behavior{_default} || 'link') : 'hide';
    + </%PERL>
      
          <&| /Widgets/TitleBox, title => loc('The Basics'),
              (($can_modify || $can_modify_cf) ? (title_href => $modify_url) : ()),
     -        ($modify_behavior =~ /^(link|click)$/ ? (titleright_raw => $modify_basics) : ()),
    -+        (($can_modify || $can_modify_cf) && $modify_behavior =~ /^(link|click)$/ ? ( titleright_raw => $modify_basics ) : ()),
    ++        ( $modify_basics && $modify_behavior =~ /^(link|click)$/ ? ( titleright_raw => $modify_basics ) : ()),
              class => (join " ", 'ticket-info-basics', ($modify_behavior eq 'always' ? 'editing' : ())),
              data => { 'inline-edit-behavior' => $modify_behavior },
          &>



More information about the rt-commit mailing list