[Rt-commit] rt branch, 5.0/IE11-fixes, repushed

Blaine Motsinger blaine at bestpractical.com
Thu May 7 12:55:43 EDT 2020


The branch 5.0/IE11-fixes was deleted and repushed:
       was ee9512b094ff1cc4bb1da0c63994b8f914107e25
       now 7b0c448aaaf057dd07427cc8cb0751eaeee8531e

1: 6c1777b215 < -:  ------- Fix flex-wrap for query builder in IE11
2: 233f43039c = 1: 3b59cb0295 Fix col overlap for ticket display in IE11
3: ee9512b094 ! 2: 1088cc5571 Fix missing chevrons in menus for IE11
    @@ -5,6 +5,10 @@
         IE11 is a lot more specific about what it allows for svg url
         background definitions. Rather than change the svg we know works
         for every other browser, load the chevron pngs for IE11 only.
    +    
    +    Targeting IE11 in CSS is much easier and cleaner to do in JS. If
    +    IE11, add the 'IE11' class to body to make for easier selector
    +    specificity.
     
     diff --git a/share/static/css/elevator-light/nav.css b/share/static/css/elevator-light/nav.css
     --- a/share/static/css/elevator-light/nav.css
    @@ -37,3 +41,27 @@
     diff --git a/share/static/images/chevron-right.png b/share/static/images/chevron-right.png
     new file mode 100644
     Binary files /dev/null and b/share/static/images/chevron-right.png differ
    +
    +diff --git a/share/static/js/util.js b/share/static/js/util.js
    +--- a/share/static/js/util.js
    ++++ b/share/static/js/util.js
    +@@
    +         jQuery('.toggle-bookmark-' + id).replaceWith(data);
    +     });
    + }
    ++
    ++// Targeting IE11 in CSS isn't the cleanest or easiest to do.
    ++// If the browser is IE11, add a class to the body to easily detect.
    ++// This could easily be added to for other browser versions if need.
    ++jQuery(function() {
    ++    var ua = window.navigator.userAgent;
    ++    if (ua.indexOf('Trident/') > 0) {
    ++        var rv = ua.indexOf('rv:');
    ++        var version = parseInt(ua.substring(rv + 3, ua.indexOf('.', rv)), 10);
    ++
    ++        if (version === 11) {
    ++            document.body.classList.add('IE11');
    ++        }
    ++    }
    ++});
    +
-:  ------- > 3: 7b0c448aaa Fix max-width for query builder in IE11



More information about the rt-commit mailing list