[Rt-commit] rt branch, 5.0/chartjs-documentation, created. rt-5.0.0alpha1-33-g8807f05c9c

[Craig Kaiser]

The branch, 5.0/chartjs-documentation has been created
        at  8807f05c9c10e6de9562c23da3f95137ea2cb6b1 (commit)

- Log -----------------------------------------------------------------
commit 570f651cd7812e04f3111436354d580b48c8b975
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Mar 23 15:25:28 2020 -0400

    Move one time suggestion boxes closer to relevant input

diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index aa4be3bd1b..7dc1ae2180 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -57,7 +57,7 @@
   </div>
 </div>
 
-<div class="form-row">
+<div class="form-row one-time-cc">
   <div class="col-md-2 label"></div>
   <div class="col-md-9 value">
     <div class="form-row">
@@ -112,7 +112,7 @@
 <div class="form-row">
   <div class="col-md-2 label"></div>
   <div class="col-md-9 value">
-    <div class="form-row">
+    <div class="form-row one-time-bcc">
 %if (scalar @one_time_Ccs) {
 %   if ($hide_cc_suggestions) {
       <a href="#" class="ToggleSuggestions" data-hide-label="<% $hide_label %>" data-show-label="<% $show_label %>">
diff --git a/share/static/css/elevator-light/ticket-form.css b/share/static/css/elevator-light/ticket-form.css
index dc2523c002..8361b5c137 100644
--- a/share/static/css/elevator-light/ticket-form.css
+++ b/share/static/css/elevator-light/ticket-form.css
@@ -75,3 +75,8 @@
 .refreshing {
     opacity: 0.3;
 }
+
+.one-time-bcc, .one-time-cc {
+    margin-top: 0;
+    margin-bottom: 1.0em;
+}

commit 52ffb48c5ae39f5bf9878673990252368948a2ee
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Mar 23 15:40:52 2020 -0400

    Use tooltips for one-time suggestion hint

diff --git a/share/html/Ticket/Elements/UpdateCc b/share/html/Ticket/Elements/UpdateCc
index 7dc1ae2180..5efb7f842f 100644
--- a/share/html/Ticket/Elements/UpdateCc
+++ b/share/html/Ticket/Elements/UpdateCc
@@ -69,7 +69,7 @@
       <div class="OneTimeCcs d-flex flex-wrap hidden">
 %   }
 
-      <i class="col-md-auto">(<&|/l&>check to add</&>)</i>
+      <div class="col-md-auto"><span class="far fa-question-circle icon-helper" data-toggle="tooltip" data-placement="top" data-original-title="<&|/l&>check to add</&>"></span></div>
       <div class="custom-control custom-checkbox">
         <input type="checkbox" class="custom-control-input" id="AllSuggestedCc" name="AllSuggestedCc" value="1" onclick="setCheckbox(this, /^UpdateCc-/, null, true)">
         <label class="custom-control-label" for="AllSuggestedCc"><% loc('All recipients') %></label>
@@ -121,7 +121,7 @@
       <div class="OneTimeCcs d-flex flex-wrap hidden">
 %   }
 
-      <i class="col-md-auto">(<&|/l&>check to add</&>)</i>
+      <div class="col-md-auto"><span class="far fa-question-circle icon-helper" data-toggle="tooltip" data-placement="top" data-original-title="<&|/l&>check to add</&>"></span></div>
       <div class="custom-control custom-checkbox">
         <input type="checkbox" class="checkbox custom-control-input" id="AllSuggestedBcc" name="AllSuggestedBcc" value="1" onclick="setCheckbox(this, /^UpdateBcc-/, null, true)">
         <label class="custom-control-label" for="AllSuggestedBcc"><% loc('All recipients') %></label>

commit 8807f05c9c10e6de9562c23da3f95137ea2cb6b1
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Mon Mar 30 08:50:26 2020 -0400

    Update chart docs for JSChart

diff --git a/docs/charts.pod b/docs/charts.pod
index 30b9ba69a5..6c85ca4eff 100644
--- a/docs/charts.pod
+++ b/docs/charts.pod
@@ -12,14 +12,22 @@ came in RT 4.2. If you're running a version of RT earlier than
 
 =head1 Enabling Charts
 
+=head2 C<$EnableJSChart>
+
+By default this option is enabled, if you'd like to disable JS charting
+then you can set this configuration value to false. To use GD charts
+instead of JS charts ensure that the C<--enable-gd> option is being
+used.
+
 =head2 Installing GD
 
-While charts is a core part of RT, you do need to enable it using
-the C<--enable-gd> option and install the required dependencies when
-you install RT. If you didn't originally install with this flag, you can
-enable it by re-running the L<< C<configure> >> script from the RT
-distribution (including all previous options passed to it originally)
-or doing the following in your current install:
+While charts is a core part of RT, if you want to use GD charting in place
+of JS charting then you do need to enable GD it using the C<--enable-gd>
+option and install the required dependencies when you install RT.
+If you didn't originally install with this flag, you can enable it by
+re-running the L<< C<configure> >> script from the RT distribution
+(including all previous options passed to it originally) or doing the
+following in your current install:
 
 =over
 
diff --git a/docs/images/general-status-chart.png b/docs/images/general-status-chart.png
index 3d208f9013..90690f0b57 100644
Binary files a/docs/images/general-status-chart.png and b/docs/images/general-status-chart.png differ

-----------------------------------------------------------------------