[Rt-commit] rt branch, 5.0-trunk, updated. rt-5.0.0-119-g3444b766b4

? sunnavy sunnavy at bestpractical.com
Wed Nov 18 15:57:59 EST 2020


The branch, 5.0-trunk has been updated
       via  3444b766b48c8e224eba22edaab46d496f662035 (commit)
      from  7d217721d324b4d12754e13a7e13644c20d2863e (commit)

Summary of changes:
 t/web/admin_queue_lifecycle.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 3444b766b48c8e224eba22edaab46d496f662035
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Nov 19 04:43:21 2020 +0800

    Make admin_queue_lifecycle.t happy when RT_TEST_DEVEL is not enabled
    
    When DevelMode is off, there could be more lifecycle related warnings,
    e.g. the one caused by QueueSummaryByLifecycle:
    
        Can't call method "Name" on an undefined value at share/html/Elements/QueueSummaryByLifecycle line 121.
    
    This is becuase RT logs errors like that instead of rendering it to
    browser in production mode.
    
    Here we just need to check there is at least one lifecycle warning.

diff --git a/t/web/admin_queue_lifecycle.t b/t/web/admin_queue_lifecycle.t
index 82b0886607..e5565b27be 100644
--- a/t/web/admin_queue_lifecycle.t
+++ b/t/web/admin_queue_lifecycle.t
@@ -82,7 +82,7 @@ warning_like {
 ( $url, $m ) = RT::Test->started_ok;
 ok( $m->login(), 'logged in' );
 $m->get_ok( $url . '/Admin/Queues/Modify.html?id=1' );
-$m->warning_like(qr/Unable to load lifecycle for bar/, 'warning of missing lifecycle bar');
+$m->next_warning_like(qr/Unable to load lifecycle for bar/, 'warning of missing lifecycle bar');
 $form = $m->form_name('ModifyQueue');
 $m->submit_form( fields => { Lifecycle => 'default' }, );
 $m->text_contains(q{Lifecycle changed from "bar" to "default"});

-----------------------------------------------------------------------


More information about the rt-commit mailing list