[Rt-commit] rt branch, 5.0-trunk, updated. rt-5.0.0-134-gbd06a743f1

? sunnavy sunnavy at bestpractical.com
Mon Nov 30 11:56:55 EST 2020


The branch, 5.0-trunk has been updated
       via  bd06a743f113aba89b609b68314b4f4a4f9f5700 (commit)
       via  dfbcd096a4b28e8b11800959550dbfecfc65bc21 (commit)
       via  dc3d49e419fc15d3154bc67cdcbb53dbdfa05a2b (commit)
      from  037eab2fed9fba34b01dc2a672ee92339aefd961 (commit)

Summary of changes:
 share/html/Admin/Scrips/Create.html             | 8 ++++----
 share/html/Admin/Scrips/Elements/EditBasics     | 8 ++++----
 share/html/Admin/Scrips/Elements/EditCustomCode | 4 ++--
 share/html/Admin/Scrips/Modify.html             | 8 ++++----
 4 files changed, 14 insertions(+), 14 deletions(-)

- Log -----------------------------------------------------------------
commit dc3d49e419fc15d3154bc67cdcbb53dbdfa05a2b
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Fri Oct 2 17:35:33 2020 -0500

    Make inputs wider on scrip create/modify pages
    
    To make editing code easier, this commit changes the max-width to xl
    (1200px) to make titlebox wider. Removing mx-auto from content_class
    makes the content fill the total available space within titlebox.

diff --git a/share/html/Admin/Scrips/Create.html b/share/html/Admin/Scrips/Create.html
index 8cf6a7eeca..c22618e9c5 100644
--- a/share/html/Admin/Scrips/Create.html
+++ b/share/html/Admin/Scrips/Create.html
@@ -49,11 +49,11 @@
 <& /Elements/Tabs &>
 <& /Elements/ListActions, actions => \@results &>
 
-<form method="post" action="Create.html" id="CreateScrip" name="CreateScrip" class="mx-auto max-width-lg">
+<form method="post" action="Create.html" id="CreateScrip" name="CreateScrip" class="mx-auto max-width-xl">
 <input type="hidden" class="hidden" name="Queue" value="<% $Queue %>" />
 <input type="hidden" class="hidden" name="Global" value="<% $Global || q{} %>" />
 
-<&| /Widgets/TitleBox, title => loc('Basics'), content_class => 'mx-auto width-sm' &>
+<&| /Widgets/TitleBox, title => loc('Basics') &>
 
 <& Elements/EditBasics, %ARGS, Scrip => $scrip, Queue => $queue_obj &>
 
diff --git a/share/html/Admin/Scrips/Elements/EditCustomCode b/share/html/Admin/Scrips/Elements/EditCustomCode
index 553e0511df..ce4b508c7c 100644
--- a/share/html/Admin/Scrips/Elements/EditCustomCode
+++ b/share/html/Admin/Scrips/Elements/EditCustomCode
@@ -45,7 +45,7 @@
 %# those contributions and any derivatives thereof.
 %#
 %# END BPS TAGGED BLOCK }}}
-<&| /Widgets/TitleBox, title => loc('User Defined conditions and results'), content_class => 'mx-auto width-sm' &>
+<&| /Widgets/TitleBox, title => loc('User Defined conditions and results') &>
 
 <div class="form-row">
   <div class="col-12 comment">
diff --git a/share/html/Admin/Scrips/Modify.html b/share/html/Admin/Scrips/Modify.html
index a0f068c8dc..07e41c3de8 100644
--- a/share/html/Admin/Scrips/Modify.html
+++ b/share/html/Admin/Scrips/Modify.html
@@ -49,11 +49,11 @@
 <& /Elements/Tabs &>
 <& /Elements/ListActions, actions => \@results &>
 
-<form method="post" action="Modify.html" id="ModifyScrip" name="ModifyScrip" class="mx-auto max-width-lg">
+<form method="post" action="Modify.html" id="ModifyScrip" name="ModifyScrip" class="mx-auto max-width-xl">
 <input type="hidden" class="hidden" name="id" value="<% $id %>" />
 <input type="hidden" class="hidden" name="From" value="<% $From || q{} %>" />
 
-<&| /Widgets/TitleBox, title => loc('Basics'), content_class => 'mx-auto width-sm' &>
+<&| /Widgets/TitleBox, title => loc('Basics') &>
 
 <& Elements/EditBasics, %ARGS, Scrip => $scrip &>
 

commit dfbcd096a4b28e8b11800959550dbfecfc65bc21
Author: Blaine Motsinger <blaine at bestpractical.com>
Date:   Fri Nov 13 18:34:24 2020 -0600

    Center content on scrip create/modify pages
    
    This commit makes the label column smaller to make the value column more
    centered.

diff --git a/share/html/Admin/Scrips/Create.html b/share/html/Admin/Scrips/Create.html
index c22618e9c5..60d64858e5 100644
--- a/share/html/Admin/Scrips/Create.html
+++ b/share/html/Admin/Scrips/Create.html
@@ -58,7 +58,7 @@
 <& Elements/EditBasics, %ARGS, Scrip => $scrip, Queue => $queue_obj &>
 
   <div class="form-row">
-    <div class="label col-3">
+    <div class="label col-2">
       <&|/l&>Stage</&>:
     </div>
     <div class="value col-9">
@@ -69,7 +69,7 @@
 <input type="hidden" class="hidden" name="SetEnabled" value="1" />
 
   <div class="form-row">
-    <div class="label col-3">
+    <div class="label col-2">
     </div>
     <div class="value col-9">
       <div class="custom-control custom-checkbox">
diff --git a/share/html/Admin/Scrips/Elements/EditBasics b/share/html/Admin/Scrips/Elements/EditBasics
index 678efde633..9392440949 100644
--- a/share/html/Admin/Scrips/Elements/EditBasics
+++ b/share/html/Admin/Scrips/Elements/EditBasics
@@ -46,7 +46,7 @@
 %#
 %# END BPS TAGGED BLOCK }}}
 <div class="form-row">
-  <div class="label col-3">
+  <div class="label col-2">
     <&|/l&>Description</&>:
   </div>
   <div class="value col-9">
@@ -55,7 +55,7 @@
 </div>
 
 <div class="form-row">
-  <div class="label col-3">
+  <div class="label col-2">
     <&|/l&>Condition</&>:
   </div>
   <div class="value col-9">
@@ -64,7 +64,7 @@
 </div>
 
 <div class="form-row">
-  <div class="label col-3">
+  <div class="label col-2">
     <&|/l&>Action</&>:
   </div>
   <div class="value col-9">
@@ -73,7 +73,7 @@
 </div>
 
 <div class="form-row">
-  <div class="label col-3">
+  <div class="label col-2">
     <&|/l&>Template</&>:
   </div>
   <div class="value col-9">
diff --git a/share/html/Admin/Scrips/Elements/EditCustomCode b/share/html/Admin/Scrips/Elements/EditCustomCode
index ce4b508c7c..a553acb913 100644
--- a/share/html/Admin/Scrips/Elements/EditCustomCode
+++ b/share/html/Admin/Scrips/Elements/EditCustomCode
@@ -55,7 +55,7 @@
 
 % while ( my ($method, $desc) = splice @list, 0, 2 ) {
 <div class="form-row">
-  <div class="label col-3 labeltop">
+  <div class="label col-2 labeltop">
     <% $desc %>:
   </div>
   <div class="value col-9">
diff --git a/share/html/Admin/Scrips/Modify.html b/share/html/Admin/Scrips/Modify.html
index 07e41c3de8..99f3e78f86 100644
--- a/share/html/Admin/Scrips/Modify.html
+++ b/share/html/Admin/Scrips/Modify.html
@@ -59,7 +59,7 @@
 
 % if ( not $disabled ) {
   <div class="form-row">
-    <div class="label col-3">
+    <div class="label col-2">
       <a href="Objects.html?id=<% $id %>"><&|/l&>Applies to</&></a>:
     </div>
     <div class="value col-9">
@@ -85,7 +85,7 @@
 <input type="hidden" class="hidden" name="SetEnabled" value="1" />
 
   <div class="form-row">
-    <div class="label col-3">
+    <div class="label col-2">
     </div>
     <div class="value col-9">
       <div class="custom-control custom-checkbox">

commit bd06a743f113aba89b609b68314b4f4a4f9f5700
Merge: 037eab2fed dfbcd096a4
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Dec 1 00:40:36 2020 +0800

    Merge branch '5.0/make-condition-and-action-boxes-on-scrip-basics-page-wider' into 5.0-trunk


-----------------------------------------------------------------------


More information about the rt-commit mailing list