[Rt-commit] rt branch, 5.0/fix-rt-portal-iframe-height, created. rt-5.0.0-22-g406f3dcd3a

? sunnavy sunnavy at bestpractical.com
Wed Sep 16 11:38:44 EDT 2020


The branch, 5.0/fix-rt-portal-iframe-height has been created
        at  406f3dcd3a659a6dfa521cd196ce6e545ea44ec8 (commit)

- Log -----------------------------------------------------------------
commit 406f3dcd3a659a6dfa521cd196ce6e545ea44ec8
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Wed Sep 16 23:12:31 2020 +0800

    Set parent height to make iframe take up the whole height
    
    In RT 4 the structure is like:
    
        div.titlebox(height: 27em)
          div.titlebox-content(height: 100%)
            iframe(height: 100%)
    
    In RT 5, we added div.card-body in div.titlebox-content, i.e.
    
        div.titlebox(height: 27em)
          div.titlebox-content(height: 100%)
            div.card-body
              iframe(height: 100%)
    
    Since div.card-body's height wasn't set before(iframe does need it),
    iframe couldn't really take up the whole height. This commit sets height
    of div.card-body accordingly.

diff --git a/share/static/css/elevator-light/admin.css b/share/static/css/elevator-light/admin.css
index ca5a1c0093..d4c703069f 100644
--- a/share/static/css/elevator-light/admin.css
+++ b/share/static/css/elevator-light/admin.css
@@ -49,6 +49,10 @@ ul.list-menu ul li {
     padding-bottom: 0;
 }
 
+#rt-portal .card-body {
+    height: 100%;
+}
+
 .admin-hint {
     font-style: italic;
 }

-----------------------------------------------------------------------


More information about the rt-commit mailing list