[Rt-commit] rt branch, 5.0/inline-edit-extended-cf-grouping-class, created. rt-5.0.0-195-gd1299397d6

? sunnavy sunnavy at bestpractical.com
Thu Jan 7 13:25:10 EST 2021


The branch, 5.0/inline-edit-extended-cf-grouping-class has been created
        at  d1299397d6f99cadcb4040ff8798249fde7ec58e (commit)

- Log -----------------------------------------------------------------
commit d1299397d6f99cadcb4040ff8798249fde7ec58e
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Jan 8 00:21:51 2021 +0800

    Fall back to "RT::Ticket" item for extended classes in %InlineEditPanelBehavior
    
    This is initally for RTIR, which has an extended custom field grouping
    class named "RTIR::Ticket". As inline edit is only for tickets right
    now, there is no need to worry about other non-ticket classes here.

diff --git a/share/html/Elements/ShowCustomFieldCustomGroupings b/share/html/Elements/ShowCustomFieldCustomGroupings
index 21acacbc2f..652c696b67 100644
--- a/share/html/Elements/ShowCustomFieldCustomGroupings
+++ b/share/html/Elements/ShowCustomFieldCustomGroupings
@@ -122,8 +122,8 @@ my $TitleBoxARGS = delete $ARGS{TitleBoxARGS} || {};
 
 $InlineEdit = 0 unless $Object->isa('RT::Ticket');
 my %inline_edit_behavior;
-if (RT->Config->Get('InlineEditPanelBehavior')) {
-    %inline_edit_behavior = %{ RT->Config->Get('InlineEditPanelBehavior')->{RT::CustomField->_GroupingClass($Object)} || {} };
+if ( my $config = RT->Config->Get('InlineEditPanelBehavior') ) {
+    %inline_edit_behavior = %{ $config->{ RT::CustomField->_GroupingClass($Object) } || $config->{'RT::Ticket'} || {} };
 }
 
 my $edit_label   = $m->interp->apply_escapes( loc("Edit"), 'h' );

-----------------------------------------------------------------------


More information about the rt-commit mailing list