[Rt-commit] rt branch 5.0/asset-dates-custom-field created. rt-5.0.3-430-g5c75fc852f

BPS Git Server git at git.bestpractical.com
Thu Apr 6 21:07:06 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/asset-dates-custom-field has been created
        at  5c75fc852f81c041ab2d6bf7359a1e6fc3dd33e8 (commit)

- Log -----------------------------------------------------------------
commit 5c75fc852f81c041ab2d6bf7359a1e6fc3dd33e8
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Thu Apr 6 14:39:53 2023 -0400

    Disable legacy Table settings for asset date custom fields
    
    Pass Table => 0 to make asset Basics and Dates consistent with
    other portlets.
    
    Also remove the unnecessary extra div from Dates. The default div
    added by ShowCustomFields provides the form-row class.
    
    Fixes: I#37578

diff --git a/share/html/Asset/Elements/ShowBasics b/share/html/Asset/Elements/ShowBasics
index 9b54178643..b61f64818a 100644
--- a/share/html/Asset/Elements/ShowBasics
+++ b/share/html/Asset/Elements/ShowBasics
@@ -55,7 +55,7 @@
 
 <& /Elements/LabeledValue, Label => loc('Status'), Class => "asset-status", ValueSpanClass => 'current-value', Value => $AssetObj->Status &>
 
-<& /Elements/ShowCustomFields, Object => $AssetObj, Grouping => 'Basics' &>
+<& /Elements/ShowCustomFields, Object => $AssetObj, Grouping => 'Basics', Table => 0 &>
 % $m->callback(%ARGS, CallbackName => "AfterFields");
 <%args>
 $AssetObj
diff --git a/share/html/Asset/Elements/ShowDates b/share/html/Asset/Elements/ShowDates
index 56fe598d25..57a7247c23 100644
--- a/share/html/Asset/Elements/ShowDates
+++ b/share/html/Asset/Elements/ShowDates
@@ -59,9 +59,8 @@
       &>[_1] by [_2]</&>
 </&>
 
-<div class="form-row">
-  <& /Elements/ShowCustomFields, Object => $AssetObj, Grouping => 'Dates' &>
-</div>
+<& /Elements/ShowCustomFields, Object => $AssetObj, Grouping => 'Dates', Table => 0 &>
+
 % $m->callback(%ARGS, CallbackName => "AfterFields");
 <%args>
 $AssetObj

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list