[Rt-commit] rt branch 5.0/user-built-in-group-custom-fields created. rt-5.0.3-432-g2ed608cf2f

BPS Git Server git at git.bestpractical.com
Fri Apr 7 14:57:13 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/user-built-in-group-custom-fields has been created
        at  2ed608cf2fb2a10d66ab24caf7bcd1d4f927dd01 (commit)

- Log -----------------------------------------------------------------
commit 2ed608cf2fb2a10d66ab24caf7bcd1d4f927dd01
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Apr 7 22:36:13 2023 +0800

    Fix display layout of user custom fields in built-in groups on SelfService Prefs
    
    Pass Table => 0 to remove one unnecessary outer div. Also remove the
    unnecessary extra div.form-row: ShowCustomFields already provides it.

diff --git a/share/html/Prefs/Elements/ShowAboutMe b/share/html/Prefs/Elements/ShowAboutMe
index 62d30b7bdf..5790d5e2bd 100644
--- a/share/html/Prefs/Elements/ShowAboutMe
+++ b/share/html/Prefs/Elements/ShowAboutMe
@@ -69,9 +69,7 @@
 % }
       </&>
 
-      <div class="form-row">
-        <& /Elements/ShowCustomFields, Object => $UserObj, Grouping => 'Identity' &>
-      </div>
+      <& /Elements/ShowCustomFields, Object => $UserObj, Grouping => 'Identity', Table => 0 &>
 
     </&>
 
@@ -81,9 +79,7 @@
       <& /Elements/LabeledValue, Label => loc("Mobile"), ValueSpanClass => 'current-value', Value => $UserObj->MobilePhone &>
       <& /Elements/LabeledValue, Label => loc("Pager"), ValueSpanClass => 'current-value', Value => $UserObj->PagerPhone &>
 
-      <div class="form-row">
-        <& /Elements/ShowCustomFields, Object => $UserObj, Grouping => 'Phones' &>
-      </div>
+      <& /Elements/ShowCustomFields, Object => $UserObj, Grouping => 'Phones', Table => 0 &>
     </&>
 
   </div>
@@ -102,9 +98,7 @@
       <& /Elements/LabeledValue, Label => loc("Zip"), ValueSpanClass => 'current-value', Value => $UserObj->Zip &>
       <& /Elements/LabeledValue, Label => loc("Country"), ValueSpanClass => 'current-value', Value => $UserObj->Country &>
 
-      <div class="form-row">
-        <& /Elements/ShowCustomFields, Object => $UserObj, Grouping => 'Location' &>
-      </div>
+      <& /Elements/ShowCustomFields, Object => $UserObj, Grouping => 'Location', Table => 0 &>
     </&>
 
     <& /Elements/ShowCustomFieldCustomGroupings, Object => $UserObj &>

-----------------------------------------------------------------------


hooks/post-receive
-- 
rt


More information about the rt-commit mailing list